From:   "G, GurucharanX" <gurucharanx.g@intel.com>
To:     Bjorn Helgaas <helgaas@kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: RE: [Intel-wired-lan] [PATCH 4/9] i40e: Remove redundant
 pci_enable_pcie_error_reporting()
Thread-Topic: [Intel-wired-lan] [PATCH 4/9] i40e: Remove redundant
 pci_enable_pcie_error_reporting()
Thread-Index: AQHZK5c6m/p3pIPkpUKNgjAW8gdLRK6u+ciw
Date:   Wed, 25 Jan 2023 10:34:06 +0000
Message-ID: <BYAPR11MB3367BD0B7644182528FC599BFCCE9@BYAPR11MB3367.namprd11.prod.outlook.com>
References: <20230118234612.272916-1-helgaas@kernel.org>
 <20230118234612.272916-5-helgaas@kernel.org>
In-Reply-To: <20230118234612.272916-5-helgaas@kernel.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JZ+ycHHKGxeQHDNrhoxNjyq1vBQ0mbk9B9nTTxIUdijBa+NgdbFZtci3bHIP?=
 =?us-ascii?Q?fDWn5GOn4xSLEd33xODTVFkt2WpAabd3RwAup1Lpb2avUHZ7fdy+e4+wxXaU?=
 =?us-ascii?Q?hVyo9iwyKE5A83eOUrcSoW+HJHap22OLcI7d25DRPyPPOntIPQoIuy1wvepo?=
 =?us-ascii?Q?z9iG/T6zObnwLvn3rbws9yovVaAJkZjeEXEiB52IHP5V2JN2vhJTzSwGCtIy?=
 =?us-ascii?Q?eB4oYCrgf7JaKelRaPV7E0TyGiCMbRCL15QrwORKl1L+L+itZScM7wvIVrQV?=
 =?us-ascii?Q?ZWrb0Xw2ddfYc9iPSUpEmQT7MyKTXKMeGZ1kuV6UkLm3rCKqsDlmY3CE8fE1?=
 =?us-ascii?Q?CKGLXe9qTlSiHuH1Y8/eOx1SoOpLXavzCJ/WzPLSMYOlC/ExD5f7+VatqkOv?=
 =?us-ascii?Q?A6sQNaV6oHXFGkTQmJfD/t/R+mV10Zkb+e7mQRv5FOZbhgmGZ350/L8prZjX?=
 =?us-ascii?Q?sHR8L+GHkMwiIp4idrJ9LATYpfCXwmUX4k9EULDFXqIZbHxrm/C8rl4GV/pn?=
 =?us-ascii?Q?sqwlDGfrNIKbHTOe4RIpI0QNEpkShDjvlPwYK1jKdrwsco4mya0V07SUhvCt?=
 =?us-ascii?Q?jXu9e3TUdbbZG4rT6Ed19kZ/tl5DPB2E+ZY3d+0cO2a0/2BGjvz6Bo2Yd/rZ?=
 =?us-ascii?Q?aOCeb08Fs69ShDaHCVPzV4YVu/rlFYpF5rAZ4YeVD5OWt2zUYF618TJL3LS9?=
 =?us-ascii?Q?CknZtxERXHlUdm3ppNY5KysRxXrR/P6G7bDJ2Hm2JZfw6FoyxkWkp3zvj2i/?=
 =?us-ascii?Q?KHKwCD3jh26LrUWUr/4TdKJgFbcxixwCNQ8hAjiel9y/8UnQcz9pFuTD+4Z0?=
 =?us-ascii?Q?jdUHb1HRTZ/QwzOLCslp6QwZBfnDrPtwlrCPHEj3ZxCH9z2p+Oez9E3dqV31?=
 =?us-ascii?Q?JkXJtyRnGl2nQ/1N998n1F8braypssdAVXpDYr3BCsmLMucPhSVMi0dSoAK2?=
 =?us-ascii?Q?lnGhcSIKsoUW6GFWr8yBDMbynR/JvQ/d3Jt0Hrz5zhGEuf9CyMzdhB+lvU6l?=
 =?us-ascii?Q?gEDaOOr7EnAdBjrxBHFMaH19+SgJE58KfsuvOCkeqFI2oAcKUhch1tY57QXW?=
 =?us-ascii?Q?BfULXd1yA0EoIe6kZ0hIDqvESMOyUp0bqMEpeLOKyfoAnni9pFAQokeFJzUh?=
 =?us-ascii?Q?ZwP/GzEsJg19t/8PT3CRUXMZVfyjSyoe1idqtn3hlBjjfh3abv//nmABGIo4?=
 =?us-ascii?Q?YIzpak2T0ZsdYkigcMhPZL8xxClDbNcbRMU5c++EuVxJQ0eAmRH9ahnAQ+2t?=
 =?us-ascii?Q?aEY1uZ9OX+g/oPiGn1JaQrFy0YXwWB/WcyfxvHz8atd5lk5Yuhjb2cqHar9h?=
 =?us-ascii?Q?Yk3I/Mgqf327L1m0IX4IPU1MLYBanzmPWx4PYkvvmb9nJzAacI5+Eb3LQuiT?=
 =?us-ascii?Q?ZQ1r4Lz4r5Kkvm2t8eL0OzDXTsIovIEnzBAcDRKlzyLBoXk3Nl6CVznusraZ?=
 =?us-ascii?Q?4EkhODRYEgK5A1NiFdMxqqSIpHoug7sxUDWPTcU1LuKU+MNorHinVo92EMHN?=
 =?us-ascii?Q?Od+62p41wrk49FKj/bs5QXjPCaMpfz5g1WX3SU7TiR3i0yvVJHJ31Rwx6fkd?=
 =?us-ascii?Q?gDL2rM8qmGLYCR/STe0ObwtapFjSXwsAqnatglOy?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3367.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 388ad12d-6754-4cb2-161a-08dafebfafa9
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jan 2023 10:34:06.5180
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gCBNyDpP9SzVqibk/AKJ7lJg9aGnUhtT5m9ivCErBJ9cqRYd+6mqv7sdYLYGSkq4Q1x3PlK9nVW/h7TvruAZIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6109
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Bjorn Helgaas
> Sent: Thursday, January 19, 2023 5:16 AM
> To: linux-pci@vger.kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Brandeburg,
> Jesse <jesse.brandeburg@intel.com>; intel-wired-lan@lists.osuosl.org; Bjo=
rn
> Helgaas <bhelgaas@google.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>
> Subject: [Intel-wired-lan] [PATCH 4/9] i40e: Remove redundant
> pci_enable_pcie_error_reporting()
>=20
> From: Bjorn Helgaas <bhelgaas@google.com>
>=20
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages.  Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER =
is
> native"), the PCI core does this for all devices during enumeration.
>=20
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>=20
> Note that this doesn't control interrupt generation by the Root Port; tha=
t is
> controlled by the AER Root Error Command register, which is managed by th=
e
> AER service driver.
>=20
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
> Cc: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> ---
>  drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ----
>  1 file changed, 4 deletions(-)
>=20

Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at I=
ntel)