Message-ID: <32db06ef-e6c1-d8ed-8624-cf91db5b3e53@linaro.org>
Date:   Wed, 25 Jan 2023 11:37:41 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH] ARM: dts: mstar: align UART node name with bindings
Content-Language: en-US
To:     Daniel Palmer <daniel@thingy.jp>
Cc:     Romain Perier <romain.perier@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230123151523.369225-1-krzysztof.kozlowski@linaro.org>
 <CAFr9PXn+XMzz8uZzNwDNdCpYeN4Nf6rc6nXWvuf_TCRe2B_PXw@mail.gmail.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <CAFr9PXn+XMzz8uZzNwDNdCpYeN4Nf6rc6nXWvuf_TCRe2B_PXw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 25/01/2023 11:20, Daniel Palmer wrote:
> Hi,
> 
> On Tue, 24 Jan 2023 at 00:15, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> Bindings expect UART/serial node names to be "serial".
> 
> snip
> 
>> -                       pm_uart: uart@221000 {
>> +                       pm_uart: serial@221000 {
>>                                 compatible = "ns16550a";
>>                                 reg = <0x221000 0x100>;
>>                                 reg-shift = <3>;
>> --
>> 2.34.1
>>
> 
> I have this change in my changes to use the proper uart driver that I
> need to fix up and resend but it doesn't hurt to fix it now.
> 
> Reviewed-by: Daniel Palmer <daniel@thingy.jp>
> 
> But we don't have anything queued up in our tree to send a PR for so
> maybe this should be merged via soc.

I can take it with my other cleanups. Thanks.

Best regards,
Krzysztof