Date:   Wed, 25 Jan 2023 08:53:24 -0500
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Sven Schnelle <svens@linux.ibm.com>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        maple-tree@lists.infradead.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v4 15/49] ipc/shm: Use the vma iterator for munmap calls
Message-ID: <20230125134558.mm3dopfa7cxqux5h@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Sven Schnelle <svens@linux.ibm.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        maple-tree@lists.infradead.org, linux-s390@vger.kernel.org
References: <20230120162650.984577-1-Liam.Howlett@oracle.com>
 <20230120162650.984577-16-Liam.Howlett@oracle.com>
 <yt9dh6wec21a.fsf@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <yt9dh6wec21a.fsf@linux.ibm.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eIGQdTGsSttPWImOj6bprnLNFFvqdhXSlUuMoPJPxmkHc1s5peC/9RzPD0bU?=
 =?us-ascii?Q?UbwEOw3FmLFClKQqKliSL+HzTGxU2tpCTKnjnTV7T3C2FOok8YXW/+3r7Jyq?=
 =?us-ascii?Q?dT5+DU6lEBeltaWAw8hITKW1ZapzETCTv6HFlgIePnskcvbW+Vwf3SvMgxkn?=
 =?us-ascii?Q?Qm/pwVG6cQA139PC00Zf3Gk2OO6oic5KOd/iUVHtjm6u5Nctbeh+Pn9aGQEd?=
 =?us-ascii?Q?GYCHE6his9fkOuxVUImua1U2LS2VAb8wUcQvRBKU4flNo0ReQq06Q9mMOFjm?=
 =?us-ascii?Q?uSNeEzwNetdBO+nqGLGjTXbN6bhzACcy3JwTNhTst0vXf0l+90oqKfZBxmAZ?=
 =?us-ascii?Q?2ZsGGz4ymrqVPqBHj7is3Q6OWvBmBlhfI7gN+9pqCBybv159lkMUy2tglzkk?=
 =?us-ascii?Q?6NTyNpx7uSb00Unken3uupqDYNe0IcBK5Yai+d4giAAyFhy0w96b5qVu7JWt?=
 =?us-ascii?Q?9ZSZV3uBo5ufiJaX4I+73VFndX/F4wB4rti/yPnHdYiuhTyYqCJa1PXPpSK4?=
 =?us-ascii?Q?Dss+Ku5bVfCkFDXhFj69y0eLHSH0DP1vpSMNIUUqYtAlR6iDvncxJcrXkRDR?=
 =?us-ascii?Q?/uZ/0jIkz2FtP0HBfwvk1RoVFT8OT1M7YFGZsFBBlZ2NCtbp63yDjvnX/xMW?=
 =?us-ascii?Q?S+cCxxLdLMs5i9d/qXW7PJTPqNs3uPX4Cu0mZ/ec2ya7pqpKu/dwpMOi+m2L?=
 =?us-ascii?Q?dBkCtC/KJSSUF7PVhyUid4F0lm2tj9pOSyJTvzTCrH5MNZ25E3P9yR8qeh/y?=
 =?us-ascii?Q?WoXP6MYF4sX8owbvBMnaMwbYC1jXYSo3AM03FGdvscXOxN2+l1ADjh35VCWw?=
 =?us-ascii?Q?3bU/+iFQcXk0b7LUeWAtopLwML/2i4wBZzjeI3Z+gicSmvOxW/DwPDLEvX2j?=
 =?us-ascii?Q?THX8M+b8xSlSK8LoEE+Q4e9A+HfZbAJh9UlroOm++QV7W0HIIywqRIcN6aL8?=
 =?us-ascii?Q?34DgXTB88xszJu4RXnQ3F3uJuEkbB9rXZfwedHD+uUCc8+v+0YyDqMu5LRNC?=
 =?us-ascii?Q?aoCEibKq1sGqgSuC4m5Dr3lwySBvhG3UaHvRKxzS4tLiF4mCgvNgvOjZKEpu?=
 =?us-ascii?Q?VEk/38wSFuzxFr9SbNwfqm9kFP1rtW62ZdicExtRVaxDL9hZo2EtYaO90IzL?=
 =?us-ascii?Q?VuItMkYnqjboH4fQ3CdcPUo/PL3wrmLsZ5GY/u6ExJ1dOoZoGEljpnSUrriW?=
 =?us-ascii?Q?TPnNy5D+RwvSP7HtYdPB56WBuCH8g+VewHUF1FBXXwJNSz0uwKr0hnV5jmYQ?=
 =?us-ascii?Q?5gl8fFwv2wcZ+vxvXAzrVRBRi85BZJjm0C3pLIDmab1zJfZgS2J3RjwI4TnE?=
 =?us-ascii?Q?h309HD/du1Oak7wbTc0GOqHqIJemZXIj1sEJBOdJlecp/oPoH/rj7cyVyBYP?=
 =?us-ascii?Q?6dCjtFOdDCl7A+bRv9VDSGfJ5QoHZTxSWdg8Fn9b0BG8kjMmywKk2jUK52uA?=
 =?us-ascii?Q?2XIcav0ukmO10FiccIgvYWtyjqRWQBPaNkZVk0eli4ldEha6C+Vnkkq05cEs?=
 =?us-ascii?Q?58/zactv2r1OiAuNW/Pzle6nUeMFZBMBvw7JC5xrx3qxb/cmvKmQhgmFVren?=
 =?us-ascii?Q?hRP4LXUKzJWIVjh48brTnn+oQP1rPu43TExpQ6lTRJa1+2usXLQu7ng1QWb9?=
 =?us-ascii?Q?JA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?4CZssZdL8QacIkvgcAv9o1rScaLAl/9f75+rtpxcySZ86Eav7Ros8JK0RVbQ?=
 =?us-ascii?Q?v04q5IRGKWIQfsd5kuZiTDdd2I3wzwv9TRCZtPtrCvhqgI1s74YGdO7/W8vy?=
 =?us-ascii?Q?t7nrfRWC10Goa7hOdp+1YXhc4UOzD75JSZTMJ+inRP9qH5sY5oMz+mP8X4BU?=
 =?us-ascii?Q?zcGtTexhswFvqCK2YZTXxDgzOg3/vrmWgaUKQSKdbTzNHHGRRerK/jlKnz+O?=
 =?us-ascii?Q?fVYr7w6XkGoxBPRIi921tbIbv1XD+w1ws4GLOXksrnwa03ysahqedwfQdEME?=
 =?us-ascii?Q?pQWSiG53Ck+NfbCJegG/FgzyIojc/VYqLyuvRfp5F/RT8Zg9RGLG4Nbh9WbQ?=
 =?us-ascii?Q?O20qIfHqc5vcHyEE+1FRObL37m+X09oRrp5dHWEbpOArlDi79xWVjBCOouE4?=
 =?us-ascii?Q?wdIxIK+zwymYKkfKINUyVWYo2M1yPP+I0/nwwBt4Ccdq6jZXDy46lG9Qa2s9?=
 =?us-ascii?Q?CpuK1IYcn866t4AkpQFPKKGusYAQs7W3gaE80UkXRmvsPlA+DwColAQu/ONK?=
 =?us-ascii?Q?Mz35IAZ+v4OvreHA+FYLIOax7Ywy/bP0jga8MUmXa7urbMpHy9d4ylkBTCb3?=
 =?us-ascii?Q?Dvxzkr71FAa9K8IavWjXmP2v4dk+Q1ULaWyoPOm3sSd+qESui2vauAKEMLbA?=
 =?us-ascii?Q?xnv81aJeYj7B2pJtajv53S5MfqVEdkZM/N9iCsjgb0mOOhLnu4SfBP4cH0mc?=
 =?us-ascii?Q?rjwwJ0ibEvSGX+ZZZJ0gCs+NWN3AOFH0i6q9cK8H7/YwRA4wisUF1PTCWiEY?=
 =?us-ascii?Q?FlRfemmAtFemkBU9LhXWQDfvWKLU7YOVWOoGFQRAj4+h8RyeyvanizN09Ta3?=
 =?us-ascii?Q?zCtntIVs7Ou8vb0890Eb3Xm3K3Ppl+eokLX8qaVIgniDsxCa38QjeudV6vJy?=
 =?us-ascii?Q?FDbe5qMec2/xO9p/brl1uBav5f5Zc1nxBJCBF5L6ankuHMphcK+62reEhRcw?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6223306f-d9ed-4ef8-c7b5-08dafedb888e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 13:53:26.9635
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Acn8r4wqt6V+RgK9/kxoXD6BMvpesfxlUrH1rWzNdjtiNSDJO+ZOTmJVsTwLrcUibeDayq5ACI2eIjIEHPO30g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4487
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-25_08,2023-01-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301250124
X-Proofpoint-GUID: Txn8jwZDvPGkKT8ilawF-yN1aof5lB-W
X-Proofpoint-ORIG-GUID: Txn8jwZDvPGkKT8ilawF-yN1aof5lB-W
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Sven Schnelle <svens@linux.ibm.com> [230125 06:00]:
> Hi Liam,
> 
> "Liam R. Howlett" <Liam.Howlett@oracle.com> writes:
> 
> > From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
> >
> > Pass through the vma iterator to do_vmi_munmap() to handle the iterator
> > state internally
> >
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> > ---
> >  ipc/shm.c | 11 +++++------
> >  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> git bisect says this breaks the shm* testcase in ltp on (at least) s390:
> 
> # ./test.sh
> tst_test.c:1558: TINFO: Timeout per run is 0h 00m 30s
> shmat01.c:124: TPASS: shmat() succeeded to attach NULL address
> shmat01.c:92: TFAIL: shmat() failed: EINVAL (22)
> shmat01.c:92: TFAIL: shmat() failed: EINVAL (22)
> shmat01.c:92: TFAIL: shmat() failed: EINVAL (22)
> 
> Summary:
> passed   1
> failed   3
> broken   0
> skipped  0
> warnings 0
> 
> #
> 
> Can you take a look? Thanks!
> 
> reverting the above commit fixes the issue.

Thanks for testing this and letting me know.

I'll have a look.

Regards,
Liam