MIME-Version: 1.0
References: <20230118144747.24968-1-fabrizio.castro.jz@renesas.com> <20230118144747.24968-4-fabrizio.castro.jz@renesas.com>
In-Reply-To: <20230118144747.24968-4-fabrizio.castro.jz@renesas.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Wed, 25 Jan 2023 15:27:32 +0100
Message-ID: <CAMuHMdXGDETQfOZ4S6_0AZa6QCJ3Kv=hMVHHS7j7tcNJ76GaTg@mail.gmail.com>
Subject: Re: [PATCH 3/3] arm64: dts: renesas: v2mevk2: Add uSD card and eMMC support
To:     Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>,
        linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Chris Paterson <Chris.Paterson2@renesas.com>,
        Biju Das <biju.das@bp.renesas.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Jacopo Mondi <jacopo@jmondi.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Fabrizio,

On Wed, Jan 18, 2023 at 3:48 PM Fabrizio Castro
<fabrizio.castro.jz@renesas.com> wrote:
> The RZ/V2M EVK comes with a slot for a uSD card, and an eMMC.
> Add support for the both of them.
>
> Please note that the pinctrl driver for RZ/V2M doesn't support
> interrupts yet, therefore the card detect pin has been connected
> to the SDHI IP directly in this patch.
> We'll connect the card detect pin to its corresponding GPIO when
> we'll have driver support for interrupts in the RZ/V2M pinctrl
> driver.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts
> +++ b/arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dts

> @@ -50,6 +81,22 @@ phy0: ethernet-phy@0 {
>         };
>  };
>
> +&emmc {
> +       pinctrl-0 = <&emmc_pins>;
> +       pinctrl-1 = <&emmc_pins>;
> +       pinctrl-names = "default", "state_uhs";
> +
> +       vmmc-supply = <&reg_3v3>;
> +       vqmmc-supply = <&reg_1v8>;
> +       bus-width = <8>;
> +       mmc-hs200-1_8v;
> +       non-removable;

Does this need "no-sd" and "no-sdio"?

> +       fixed-emmc-driver-type = <1>;
> +       max-frequency = <200000000>;
> +       status = "okay";
> +};
> +
> +
>  &extal_clk {
>         clock-frequency = <48000000>;
>  };
> @@ -78,6 +125,68 @@ i2c2_pins: i2c2 {
>                 pinmux = <RZV2M_PORT_PINMUX(3, 8, 2)>, /* SDA */
>                          <RZV2M_PORT_PINMUX(3, 9, 2)>; /* SCL */
>         };
> +
> +       sdhi0_pins: sd0 {

[...]

> +       };
> +
> +       sdhi0_pins_uhs: sd0_uhs {

[...]

> +       };
> +
> +       emmc_pins: emmc {

Please move up to preserve sort order.

The rest LGTM, so with the above clarified/fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>


Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds