Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6057C54E94 for ; Wed, 25 Jan 2023 15:06:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235711AbjAYPGo (ORCPT ); Wed, 25 Jan 2023 10:06:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235059AbjAYPGn (ORCPT ); Wed, 25 Jan 2023 10:06:43 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8851B7EC4 for ; Wed, 25 Jan 2023 07:06:41 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id mp20so48382761ejc.7 for ; Wed, 25 Jan 2023 07:06:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hZ+XWT7x3GIrVuC5smdu5kaGnAEgwF0jVXjRtih1Jog=; b=cH3hA1DNTFYYXcYv2dYsdfs/F0a4Fo0x393HAZwW7sg2/ZjfnFAD1GtMUOqjWL6CnP ZvzRjkIG0subDN66xQFmo5RPvHMO3JcQFlvxD4ONkyFtfwzAB0ttmle/4y/TihRmks2S QXEXCp8Wf6YgFDGr3UNW6Zg1acdhVDLA6TZFsp2afNANCN/FBWcfLjqRBqIzEzy0hs2+ Iu7AQIKZKCjwH1r3tr76JeJWLqDPeFtDwhkwh4CwUKs4fBH3dkJgQS9oXUFzIuRCTvAV wz10ylaivnJCsis/1BoziUFwpkgIXGHitA8M5eSFjzZ2tVIZ5zMWatWzwaCmwmELkutj aVZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hZ+XWT7x3GIrVuC5smdu5kaGnAEgwF0jVXjRtih1Jog=; b=p2trIhr46sOzsuQ1cUKotQ9w0jCEPevF3AtqVBrO9Od6OOt19rMx9lcCh340uHd3P+ VDfxFxQCqNxH2Vog2Hsy7rrEWCbuQxYyQydyU8o6Yu7CdiX4I8eI4XJjxLDoNdD5nBtI PkxQxRdg9ZEB5eI+MS37YOT1lHpktxPM5SHP0M/v1CKBh/NIpedECA/joI89T2H5fqKY Hxo7gFpkQ8eIL3HsHmdaokk6mB2YARAxSwFdxyNkNoCxkoz2+tOmsn2Vfpa9kcVALuFB xLJOqeO3tNSZRj5NDlzDymP3ZNA5ky5tEqDoBbiNpxbsHI1A8euvYNiFtZqalph8rWIp CXrg== X-Gm-Message-State: AFqh2krs26aHHAzY2X4lTa3jvTfo1KOCOv7lSiEPr0t6UX/JvwbIeG/6 dW7g0x00uXe2Z9X+bl8ntTgAX4Tij7nfAg7ShqchHQ== X-Google-Smtp-Source: AMrXdXvqJOlDJST3w87/gr/ZwRFOMtImwLKSDqGCZTr2eYhDs7UWmBPmEUcE54nfAXRo5cLYHmUUvd9VLSwpRS2TOrc= X-Received: by 2002:a17:907:c243:b0:7c0:e391:c548 with SMTP id tj3-20020a170907c24300b007c0e391c548mr5314680ejc.18.1674659200062; Wed, 25 Jan 2023 07:06:40 -0800 (PST) MIME-Version: 1.0 References: <20230124131717.128660-1-bchihi@baylibre.com> <20230124131717.128660-5-bchihi@baylibre.com> <5dd5c795-5e67-146d-7132-30fc90171d4c@collabora.com> In-Reply-To: <5dd5c795-5e67-146d-7132-30fc90171d4c@collabora.com> From: Balsam CHIHI Date: Wed, 25 Jan 2023 16:06:04 +0100 Message-ID: Subject: Re: [PATCH v11 4/6] thermal/drivers/mediatek: Add the Low Voltage Thermal Sensor driver To: AngeloGioacchino Del Regno Cc: daniel.lezcano@linaro.org, rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rdunlap@infradead.org, ye.xingchen@zte.com.cn, p.zabel@pengutronix.de, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, khilman@baylibre.com, james.lo@mediatek.com, rex-bc.chen@mediatek.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 24, 2023 at 4:31 PM AngeloGioacchino Del Regno wrote: > > Il 24/01/23 14:17, bchihi@baylibre.com ha scritto: > > From: Balsam CHIHI > > > > The Low Voltage Thermal Sensor (LVTS) is a multiple sensors, multi > > controllers contained in a thermal domain. > > > > A thermal domains can be the MCU or the AP. > > > > Each thermal domains contain up to seven controllers, each thermal > > controller handle up to four thermal sensors. > > > > The LVTS has two Finite State Machines (FSM), one to handle the > > functionin temperatures range like hot or cold temperature and another > > one to handle monitoring trip point. The FSM notifies via interrupts > > when a trip point is crossed. > > > > The interrupt is managed at the thermal controller level, so when an > > interrupt occurs, the driver has to find out which sensor triggered > > such an interrupt. > > > > The sampling of the thermal can be filtered or immediate. For the > > former, the LVTS measures several points and applies a low pass > > filter. > > > > Signed-off-by: Balsam CHIHI > > Reviewed-by: AngeloGioacchino Del Regno > > On MT8195 Tomato Chromebook: > Tested-by: AngeloGioacchino Del Regno Hi Angelo, Thank you for reviewing and testing it. Best regards, Balsam