MIME-Version: 1.0
References: <20230125050359.339273-1-void@manifault.com> <20230125050359.339273-5-void@manifault.com>
In-Reply-To: <20230125050359.339273-5-void@manifault.com>
From:   Alexei Starovoitov <alexei.starovoitov@gmail.com>
Date:   Wed, 25 Jan 2023 08:06:11 -0800
Message-ID: <CAADnVQJ18MRB+z5feD-hu8zdV2s=rhTW--RWW06NWp-kQaBhag@mail.gmail.com>
Subject: Re: [PATCH bpf-next v3 4/4] bpf/selftests: Verify struct_ops prog
 sleepable behavior
To:     David Vernet <void@manifault.com>
Cc:     bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@meta.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Kernel Team <kernel-team@meta.com>, Tejun Heo <tj@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 24, 2023 at 9:04 PM David Vernet <void@manifault.com> wrote:
>
> In a set of prior changes, we added the ability for struct_ops programs
> to be sleepable. This patch enhances the dummy_st_ops selftest suite to
> validate this behavior by adding a new sleepable struct_ops entry to
> dummy_st_ops.
>
> Signed-off-by: David Vernet <void@manifault.com>
> ---
>  include/linux/bpf.h                           |  1 +
>  net/bpf/bpf_dummy_struct_ops.c                | 18 +++++++
>  .../selftests/bpf/prog_tests/dummy_st_ops.c   | 54 ++++++++++++++-----
>  .../selftests/bpf/progs/dummy_st_ops_fail.c   | 27 ++++++++++
>  ...{dummy_st_ops.c => dummy_st_ops_success.c} | 19 +++----
>  5 files changed, 94 insertions(+), 25 deletions(-)
>  create mode 100644 tools/testing/selftests/bpf/progs/dummy_st_ops_fail.c
>  rename tools/testing/selftests/bpf/progs/{dummy_st_ops.c => dummy_st_ops_success.c} (72%)

It fails on s390:
dummy_st_ops_success/dummy_multiple_args:FAIL

Please add to DENYLIST as part of this patch.