Date:   Wed, 25 Jan 2023 17:45:59 +0100
From:   Frank Wunderlich <frank-w@public-files.de>
To:     =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= <arinc.unal@arinc9.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>
CC:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        erkin.bozoglu@xeront.com, Sean Wang <sean.wang@mediatek.com>,
        DENG Qingfang <dqfext@gmail.com>
Subject: Re: [PATCH 1/5] arm: dts: mt7623: add gmacs to mt7623.dtsi
User-Agent: K-9 Mail for Android
Reply-to: frank-w@public-files.de
In-Reply-To: <20230120205318.519493-2-arinc.unal@arinc9.com>
References: <20230120205318.519493-1-arinc.unal@arinc9.com> <20230120205318.519493-2-arinc.unal@arinc9.com>
Message-ID: <BAF25F3F-7B1B-4E9D-A0D9-89DB663B0AB3@public-files.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:6Q2eUUuj21g=;XdBoI5gTcoxhHyv/16CUTI0rkiX
 Lku+RnjSg6IIMWmsm6IMFxfkoklB7XWpcx7fTsPBCrP263NlO0Tq/Yu4Qac0gQIOboEOVWTAH
 Zc/YuSEBUl47WrfzM6U1dHRfuPrDWeoxkeTjfTFGUUIDnx01lFHdpRLETZPWIvuDWC4Vz9P9H
 osOQ9P9dCnQubBay1EevAal5aLJKSKf71e2hatqFrvClCZgspIiujBow0Og5iNveaG+Iu8lYK
 z7CTtuiHLExs6RR/aaGlMujT56HqGR2KO5FD8WY1iUE8TncAOFFMWxcuiYNupF7sBFaTHOy1Y
 ergIMtRCQcOV/t9B3CE70Dmey4KLdoG21TyoCOVdHKwl8L+tQS5N2Y9vJ9JQuC0jtQk0NsQ2M
 p21szIFVD6EGIKSC4u/e7dsgB3s7gErnDTNrM67HKUKPLSY+Gy0APiB72KRVFbSTRWWBQKrFZ
 PNCNvQP5NNTL+hzudoSDtFs3vd65Am9RzCKc/iSvGK2teT22tHjxIIMXIN5jnuFLLpqET7bb/
 f+Sm42wzMgW8hUdFgfIJaCURVyNiBk+lXTHhiIC61hR/jGTIdaWbV7M2MaZE5C15XrPK+SG9/
 ORbLE7aO2pMbnLVv7klSFbmCFs2HuhiHwoa/qduAjTxGQl14ZiJkFB6epGaOgRqtNOEP511KO
 v5qaZjn41QW/nRqVayNdl39hqkwjMVcGWeT3xhLla2YzuEjC0d6W8tpq/p+jY8cpTSk3AYbT5
 NVSO3A93UjJBCHPxk2MaJfNX2TYiFTKcR6BqRglbEKekbLyTjYYMCirnAUogemHlaWNEKVpAg
 n6vUfjjJTbSS+fKVNUEPzjnOLb0GiMnSoDN3+AOrOcFa3kmSD10vI25s9gt/MGOCeLNBFsBLr
 VRoQ5/wXmzeznbm4Gl7JwRdBVbkThcC/IIq6+p1nhtSIPITKvI9B4x5cme8buR2qfMYHN+Ori
 t1a6JUKV+v1jOlHx4x9uNPh/Hfo=
Precedence: bulk

Am 20=2E Januar 2023 21:53:14 MEZ schrieb "Ar=C4=B1n=C3=A7 =C3=9CNAL" <arin=
c=2Eunal@arinc9=2Ecom>:

>index 25d31e40a553=2E=2E5eb698a90d34 100644
>--- a/arch/arm/boot/dts/mt7623=2Edtsi
>+++ b/arch/arm/boot/dts/mt7623=2Edtsi
>@@ -981,6 +981,20 @@ eth: ethernet@1b100000 {
> 		#address-cells =3D <1>;
> 		#size-cells =3D <0>;
> 		status =3D "disabled";
>+
>+		gmac0: mac@0 {
>+			compatible =3D "mediatek,eth-mac";
>+			reg =3D <0>;
>+			phy-mode =3D "trgmii";
>+			status =3D "disabled";
>+		};
>+
>+		gmac1: mac@1 {
>+			compatible =3D "mediatek,eth-mac";
>+			reg =3D <1>;
>+			phy-mode =3D "rgmii";
>+			status =3D "disabled";
>+		};
> 	};
>=20

>diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2=2Edts b/arch/arm/b=
oot/dts/mt7623n-bananapi-bpi-r2=2Edts
>index 5008115d2494=2E=2Ea5800a524302 100644
>--- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2=2Edts
>+++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2=2Edts
>@@ -175,9 +175,7 @@ &eth {
> 	status =3D "okay";
>=20
> 	gmac0: mac@0 {

Should node not be accessed with label (&gmac0) instead of defining it aga=
in and shadow the one from dtsi?

>-		compatible =3D "mediatek,eth-mac";
>-		reg =3D <0>;
>-		phy-mode =3D "trgmii";
>+		status =3D "okay";
>=20
> 		fixed-link {
> 			speed =3D <1000>;

Same for other boards=2E

regards Frank