Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3331FC27C76 for ; Wed, 25 Jan 2023 16:51:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235945AbjAYQvA (ORCPT ); Wed, 25 Jan 2023 11:51:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235986AbjAYQuX (ORCPT ); Wed, 25 Jan 2023 11:50:23 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 364EAA5C4 for ; Wed, 25 Jan 2023 08:50:21 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A565D4B3; Wed, 25 Jan 2023 08:51:02 -0800 (PST) Received: from bogus (unknown [10.57.77.84]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BDBC13F5A1; Wed, 25 Jan 2023 08:50:18 -0800 (PST) Date: Wed, 25 Jan 2023 16:50:15 +0000 From: Sudeep Holla To: Samuel Holland Cc: Mark Rutland , Lorenzo Pieralisi , Dmitry Osipenko , "Rafael J . Wysocki" , John Ogness , Kai-Heng Feng , Luis Chamberlain , Petr Mladek , YueHaibing , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tangmeng Subject: Re: [PATCH v2 2/2] firmware/psci: Switch to the sys-off handler API Message-ID: <20230125165015.cpar5hcw53wq5rek@bogus> References: <20230101181715.42199-1-samuel@sholland.org> <20230101181715.42199-3-samuel@sholland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230101181715.42199-3-samuel@sholland.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 01, 2023 at 12:17:15PM -0600, Samuel Holland wrote: > Any other poweroff handlers registered at the default priority will > run before the legacy pm_power_off() function. Register the PSCI > poweroff handler with the correct priority to ensure it runs first. > > PSCI_0_2_FN_SYSTEM_OFF never returns, so the value returned from > psci_sys_poweroff() is meaningless, but that function must return > some value to have the right prototype for a notifier callback. > Reviewed-by: Sudeep Holla Tested-by: Sudeep Holla -- Regards, Sudeep