Message-ID: <560cac2d-ab47-9846-e641-503060b4596c@oracle.com>
Date:   Wed, 25 Jan 2023 16:55:52 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH v3 06/11] perf pmu-events: Remove now unused event and
 metric variables
Content-Language: en-US
To:     Ian Rogers <irogers@google.com>, Will Deacon <will@kernel.org>,
        James Clark <james.clark@arm.com>,
        Mike Leach <mike.leach@linaro.org>,
        Leo Yan <leo.yan@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kan Liang <kan.liang@linux.intel.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Florian Fischer <florian.fischer@muhq.space>,
        Ravi Bangoria <ravi.bangoria@amd.com>,
        Xing Zhengjun <zhengjun.xing@linux.intel.com>,
        Rob Herring <robh@kernel.org>,
        Kang Minchul <tegongkang@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Sandipan Das <sandipan.das@amd.com>,
        Jing Zhang <renyu.zj@linux.alibaba.com>,
        linuxppc-dev@lists.ozlabs.org, Kajol Jain <kjain@linux.ibm.com>
Cc:     Stephane Eranian <eranian@google.com>,
        Perry Taylor <perry.taylor@intel.com>,
        Caleb Biggers <caleb.biggers@intel.com>
References: <20230124063320.668917-1-irogers@google.com>
 <20230124063320.668917-7-irogers@google.com>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230124063320.668917-7-irogers@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnUwbHZ2ZDRYSzJ6Wkl5WkNTNWxyc2Z3azZRVDJ5YXRlWWVjd2lhcTZJQ0dt?=
 =?utf-8?B?Z1NxT09jMEFpTDVhdk1aTGtLME95ZlRGZFg5RXJ3WXJieW9pT1REdVJCLzI3?=
 =?utf-8?B?TFprUHBTQVA2NjNxT3dvMk45N0RyaXhnV3dRNWRaRXpSUkozRS9kTjFMS1Yv?=
 =?utf-8?B?MXpxc0d2QmtaendSeDRxNkc1TFFFTVFSUmdCSjFDZFBXZDI0YXMzTEVIN3ky?=
 =?utf-8?B?MnN0NXphaFZuQkJPT3ZLdkhjekV6ZXZSRWxqbGYrLzZ4RU9iQzlYcndGNjFO?=
 =?utf-8?B?VmtEN2JLY3l5dXpVL3hOKzJnVkxPa2ROZXNBQXI1UXA2ellZUlRDNWJzditE?=
 =?utf-8?B?VnI1a2RMV3BVbW5xRFhOUS83OGJ1RStPaWdrdXdVRkV4bkNQam9DanFxRTdx?=
 =?utf-8?B?blc5RXlvZTZmS2RTNlVBbmNVSlNQV1ZQWkFWcjl6S3BJWUpJb3kxNkJxcUxt?=
 =?utf-8?B?MHh6U1NpdnlYNzlIaWpBemNaZXpZUWg2RzlzRlkzZm9kc1JXTDgzRkFuNTBn?=
 =?utf-8?B?cDV3Q2hLTmI5aTduM0FvVTErcmZSOEVOUWgrbkVWS3pHbk5wckF5a0hOQUNj?=
 =?utf-8?B?TFlQc2N4TEljRG0xWkxuUFFmaVRNLzdXOTI3d09OYU9wcnJwc0p6bDdpNlBD?=
 =?utf-8?B?d2VuVEF0VmdmZmNXT3dzRk1FcUZlbHFXcGl3alltY1pzcktrb3lnaUVQRVZC?=
 =?utf-8?B?WEs3TDlsYTQ3TXpWQjRpN3EyMnJvT09TeGZJTy8yRDB2ZW1qWWtxdlNqenZK?=
 =?utf-8?B?YXVkek9SMVUrem83SFNQVHdaMTFtNkR3YzF1V3hZUVJPdVc2M0MxVVdvVlM2?=
 =?utf-8?B?R0o0bWk0cFVrWGx4ZzMzMUdZRlhZOExLcEVpZjNlSG1zWTV5Y1BTMEJDbHpp?=
 =?utf-8?B?UXBpZE9Bay9MREIveXZNSjJOdkdGZngwVWlRYTJGWjFRTlhrMUNKQ0tDU3Z2?=
 =?utf-8?B?a3pwNGY0TzJiWDBLV3Y1OEdCL0dldGxYWG5MOUMwK2xVcUhsbHJWWjlpQ0ln?=
 =?utf-8?B?MDJUdzhWa0VKaUdnZmwwNU1YV2dnWGhFWEhtak1nL1IvZ25YNHZXdnZQSTRJ?=
 =?utf-8?B?eHJ2dVJSUWpNWjl6VmhyZEJ5ZWZ5Mnd5NzJHdEFuT0plenUvczlFaW1tNWpv?=
 =?utf-8?B?dU1xbzBhT2pNTlM1aUxMdSs0dWxrL0daVWVPNElzZGY5YUpGK2RUUStGY3c1?=
 =?utf-8?B?T1RHZmVxcFhxMHV3dlhNeEZyekg1Z2RwbGV3a3A3ekdRVkJsMTRLQU1ZcHRT?=
 =?utf-8?B?NzlYR2pmcC8zcUt6WU12TVB6Sm4zbjVDSUlJU1pROEhjdEc2ZGpGblFXVmVK?=
 =?utf-8?B?ODBJVHpSNmkxUTZYR043QXU3Wm91bFQvaG1FRFpNY1JTNEJMeXRuSGdPckhl?=
 =?utf-8?B?U0RITmRWd3MzMytPcU5uRTlSN3hVY0dZR0ZJVjF6ODczZnZUYmY3enRIQzRH?=
 =?utf-8?B?bGNBbFgwNmRSeGM1QUp5Z2tRZGE3UHRKNFc2VklKRmd1NzMycnJvcWJOYzNu?=
 =?utf-8?B?bHI3TlAreHoxUXlsS2o0SjBMOHZHZE1PME96bHpiOVQwTzhEdDl1MUp1aTlm?=
 =?utf-8?B?MzBRK2h0RTF1amFKZWNpQzZLK25ubG1obDh6Qi9NaHV1b3ltVUdISWJPcCtY?=
 =?utf-8?B?N1d3dnlGWnNRWERUbXNBL2NXSGcxclZCK0JjRmdlUzF1NVFkUVFJZmtkZkRK?=
 =?utf-8?B?MlJqaTBENGZyVVdoVE9FK3hSRjVhOXVNbDcrRG0xelh3eUlxSUxrd0U4VHg4?=
 =?utf-8?B?Q1NlMVVXR2hCZURvSVJjcks4TlU1eGxuQjJOVmt2WVg4RXZpYmNXbFUzcFlB?=
 =?utf-8?B?MUFlZzFYVC84NzhxbTFZWmZqNGdURHFsd2ZDaURkOFFjRlVhd0xCTmxFa2lX?=
 =?utf-8?B?U3dSdmRCRWFoSlkwWkpzdjZweFBZL3Y5eWRCeFcrMXAwRENDdHArZlJFMVJS?=
 =?utf-8?B?NVRCMzZScnVHenRLakJpOWZ3UkFHbjNTaS9MS2tuazRNM2VTcjVWSGlaMGlM?=
 =?utf-8?B?dzNJcFNSckdiTmRDdjVUZmZKeFVJSk04VS90cHZFRzI4T0c3aVBOTkZkR3N3?=
 =?utf-8?B?RWdETWlSZXI4ekl3SndENWwvK1kyZjJCcDllOXdZdExJeUU4ZkhwdFcwSlZv?=
 =?utf-8?B?ZGkzUVZkM1kvcDFYRE1uYjQxWlg3aUxIQmxSdktiYXJCdk5rbUtlRXdMZnZV?=
 =?utf-8?B?dnc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?NFVQZ3FWeXdtOUpFa2dFUlo5NXVjODJWNFY2ek13ckp0N3JPTnY5djc5RU1Y?=
 =?utf-8?B?R0w2TlZZWWVZeUdOcTNVTWljYVVkeitmYlArOWhZeGd2ZzFKVFNldHpRVm5U?=
 =?utf-8?B?TS9EaFR1OGtNeVJpMDk1NUdqeS9XbWFXMDdaelUvS1JsWjNtTXMrSVF5N0Ix?=
 =?utf-8?B?SEpkR1RqanFVQ2E0QmdIU2FNMGhPbWZiLyszSnlrNHB4YVliUFFDeFg1TklP?=
 =?utf-8?B?a1ZGeitRUDJwV3p4NTdPV0VnelJOT1VXL3lHTm1ZV2N1Q2tmcFhXY093SEtM?=
 =?utf-8?B?L3kzVWRqdGRaQmRGbUt1bi9KVDZqdzlES0xFK0xvL2kxVFdFck9FZWlGWTQ2?=
 =?utf-8?B?aTMvaVdEazVRZG8zT3Avb0hEL3FwY0Jsd3Jadko1em5zS1QzOTZydUEyamI1?=
 =?utf-8?B?Vk4rZU8zOFJRYVlndXNzTHNZNGx0dFVRRndIdHFxM1RlVGRrOFNqcUdwbkQ5?=
 =?utf-8?B?QXlWckhBZ0RVSXVRaktrdFBHQzh5WlF6bVZTSDhBR0JLYUdVM2s3M0NDSUxl?=
 =?utf-8?B?V1czcjRwTFhjbHk4OXdmWjNXQU0rWTNaa0l6My9kdlg1ZjZ1a2pNSXNQcFV1?=
 =?utf-8?B?Q0dXU0puenpqTEZEUXZmWVdMQU5qRFBTbDFXTHNpdXByVHc0bkhWSUkxZW9Z?=
 =?utf-8?B?QnRpdFprUUZ1UlhEMjR3VVBad3FlL3dYWlF4Z2QwYjdCVHBGSWZib2V3MGsx?=
 =?utf-8?B?Nm16ZUlQeHhMdGorUkNtczZiRVVEU1dheEhISFlUWVU1Q3NlbzZ2Zm5pNGhk?=
 =?utf-8?B?REVneFZnUnhiZzArV2hSd3UvdDczUVJMdlkxbVRVNldwakUyOXFjV0k3ZzBu?=
 =?utf-8?B?OG1MbW1CSmxsUTR2NnV5TWpwTWZhS1hONittUnJoSE9OTHFnNTlWS2Z2T3NO?=
 =?utf-8?B?TVBLaW9MRWMyaDVFeTRoSGFHRjlXcjNRNU9EK3JPZktwSmsyZ2p6QVNEaUF4?=
 =?utf-8?B?N25ZNFZPZDRVSzlDditpckJOSWpaNW9FQTJjMkdpTWFad2dhUHozU24rbk53?=
 =?utf-8?B?WDdERGN3Yy8rYWxiTTNLRllTcnZYajR3MFpLY1dFbVFhY01aN0tDSk1iV0xu?=
 =?utf-8?B?V3lLOG9QU0l2TkF0OG9mQ2cvbitYU09aNTZFMWR5QnIxbHV6YWMvNU1NRWs0?=
 =?utf-8?B?TlIrL0xuRUNCMUQ1SHlCR3hua2Z6a1c5M2ZOMXlsWDk4VUg0MmZva051OC9m?=
 =?utf-8?B?VFh2eFhIdTZDeUJQNHM1RlNmL1RrclRzN1F1dkNMcVJMaGs0cDMxOWdTeWx3?=
 =?utf-8?B?Y05LZ2pCOWdmeWZwNzA1Z1EwZ1ZsVEN4YmFpRGxPZ1B1cjNjelJrRG5kVjhD?=
 =?utf-8?B?Qkpkd2ZWcGREbUtzcnVDbmFEeWI1Z1hBYjRualc1RkxFMGFjUVdNK2ZneXNM?=
 =?utf-8?B?YjdveGZkYlAvZE5GanphOUtZcVdmM1lRSW5tc3NjcTloZDZmZlU4N1pQaHRI?=
 =?utf-8?B?ZlFMQlhTdWIyQWZnOWhjb2Z5Q1FVTjlNc3d2cml6SEgrQmJRSkxPcm1UL2ph?=
 =?utf-8?B?UmgrTGV4ZG02Q0ZRODRsL0paUlRHSkpLb0RKcWJNd0dtZEhZQjY5blZzRnJM?=
 =?utf-8?B?S0Z5WlhlcmlySWVTYWlOYWhWMkZteFRDazZjL2w2cnJ6NnQ1cHJaWnVuOEwy?=
 =?utf-8?B?YVFuR2pjSmlIdXhQL3BsVlh5TGxHOW84OURoQzNPaER4WnlsdklZN2FUNmsx?=
 =?utf-8?Q?kbk12emFUUrW+L3CVRyc?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c51e42c-e245-4781-a2b8-08dafef5090c
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 16:56:00.1594
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JSAupMYZl5l45DbAFzyXJvzet/hIjV8j1d5eAkKswlsKBbkZXYFgNxoVQImxpPFd19dDrrut3DXg7E3C5WuzzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6138
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-25_11,2023-01-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 adultscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301250151
X-Proofpoint-ORIG-GUID: XKzyLQFfdjNi7ya18NweW0HQfCDYs-VA
X-Proofpoint-GUID: XKzyLQFfdjNi7ya18NweW0HQfCDYs-VA
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 24/01/2023 06:33, Ian Rogers wrote:
> Previous changes separated the uses of pmu_event and pmu_metric,
> however, both structures contained all the variables of event and
> metric. This change removes the event variables from metric and the
> metric variables from event.
> 
> Note, this change removes the setting of evsel's metric_name/expr as
> these fields are no longer part of struct pmu_event. The metric
> remains but is no longer implicitly requested when the event is. This
> impacts a few Intel uncore events, however, as the ScaleUnit is shared
> by the event and the metric this utility is questionable. Also the
> MetricNames look broken (contain spaces) in some cases and when trying
> to use the functionality with '-e' the metrics fail but regular
> metrics with '-M' work. For example, on SkylakeX '-M' works:


Reviewed-by: John Garry <john.g.garry@oracle.com>