Date:   Wed, 25 Jan 2023 18:36:59 +0100
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Lee Jones <lee@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the
 GPIO providing driver
Message-ID: <20230125183659.7dd9e0f5@md1za8fc.ad001.siemens.net>
In-Reply-To: <CAHp75Vf5MAsiYKdmF2oQ2rNDjKUVW9nk5FjPhUcD3b-4r_u6yg@mail.gmail.com>
References: <20221007153323.1326-1-henning.schild@siemens.com>
        <Y8mv8PzL1UsP9gNh@google.com>
        <20230123214859.725cd1c3@md1za8fc.ad001.siemens.net>
        <CAHp75VfSHgdikX5=Qba62BwWofVf7gHhS2hq2OuBwHFz9riCWQ@mail.gmail.com>
        <20230124143514.1abf933f@md1za8fc.ad001.siemens.net>
        <CAHp75Vf5MAsiYKdmF2oQ2rNDjKUVW9nk5FjPhUcD3b-4r_u6yg@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TGgVHBQKhtwzzYEnh6XcMmVL6yyVkr3W+YTjOxUodp28zao4y8CPVnha9oy3?=
 =?us-ascii?Q?IBLpC5NkhyHuTuTh4T9vmhrXuoCBOhmZEWjl3wqVmAPpSVPvY/NJ5ftbDHfi?=
 =?us-ascii?Q?7W5xGR3N/OxNbVKv4m1/9Y4a3Hr+Cm9Kvy9HXiJuJCuuMnXgRarlwXGNdFK/?=
 =?us-ascii?Q?eanjsGQosugSNZ1yjntmOmQFTdArrAFVJiHkUSYfyvuB6poA/Ve6cktNl4iE?=
 =?us-ascii?Q?HX5FNbZR4Pl8JWSkYrZ3reunboX8tsEbwRtfTgixEidPHQH3PsLujaHMnxLZ?=
 =?us-ascii?Q?b0IAfyAF3GE1wfvN8f84OeNF7eaF+mj8gtf+cgCiNw3wREAQ9+5yMRKhtoRE?=
 =?us-ascii?Q?X+FfM5iW3eo39B70Er/7OzQ2zW6YQces0FnnMIg5BC/8Gd1kngKXD7MzzuKB?=
 =?us-ascii?Q?qsUUxkV7bmMLS5me81nnPLfzpissO0hd9KSnl7dd0g4F/HbtV4I753kKtRHn?=
 =?us-ascii?Q?nwYywcG4TNtGiyv+obzs/2kNwEN++6GUS4OzG0Las06CmCg1Y2gaSVFoNDQh?=
 =?us-ascii?Q?h2iu+AlJ9cCusB+w580ajSDwzJ6U7RDoe+UY64xAttWWx0RD4S79q+sIQxMi?=
 =?us-ascii?Q?0nrV7xH3XEDtBkRpzyXvCwvHsGsS1LszrGgOOZMpVGmb+tZV+GwVxwF4INSm?=
 =?us-ascii?Q?ev6cChjsLS/Wg2LAagqwUgh+3Ypnz2HkB8W4ugiXV3F8RwrC4kO7MVIcwVyy?=
 =?us-ascii?Q?/G/PYPdwJ2ltv0/nDIGYM8rv0hu6DZdlZRjePiwsWjppgKKFUVlC9BKjuOOk?=
 =?us-ascii?Q?1Jq+/7fjdK/J8XYRralm+a3ZtJsFbBQLsoG5lJ1YX+BQHzQSc1LzCSZf+gH/?=
 =?us-ascii?Q?B2dKftUcJjqNOGqQ9umqtGujkOGK8aeKhtsh83Ah1NmlG4lfbF1JxnCG/WJK?=
 =?us-ascii?Q?LH1ap3XZo7/HlpsrLv0ta7JCwaQPN+AAk87kbb6Q8Ay+tixsr2Q/n1NRAc82?=
 =?us-ascii?Q?vWh8CMnMl8YXOvF4P7lgbtEi5DjXAqg3gtUHDTY56MS4mSx6NOMXjnutCca7?=
 =?us-ascii?Q?rUKO4spqeh5oQPNzlt3yh6CmdMDP8F09E9fo+ct3Y/FaPNIBZADYTUEqPDSW?=
 =?us-ascii?Q?9qvh/4Fcgd6T5Sk7OyUdwj78/u6sStkqbjij5s+CuYtNJFVh+QdjZ8GI5sER?=
 =?us-ascii?Q?lM+eLz30oWbipoWVQkfwhEuQjWD+ygvfQd1zJhO11n0C+lijgA58cX2a7g5V?=
 =?us-ascii?Q?5BiLeXZ7gj6mh8G9Xcf7jcDOx0V5H72BgfX4jZN2pSrU/PWIC56F0p4Q5UPD?=
 =?us-ascii?Q?QsCI60CIrRD4pz/X6XAc0yL0qB133BmXgMNrWNAWnlaS3BwD3Y+SN8kXe75k?=
 =?us-ascii?Q?zxOCKC6I+Wd32OjXz1A2KwEerKRsW481GQrAmS01gKFUpWT91za8DyDOGb/W?=
 =?us-ascii?Q?9INz0bEX8LqZGiokrcj5jWi5XrGnFryBD90Vr8zBbnt8MS9qBfTZR/3YRUCq?=
 =?us-ascii?Q?2txWSvUmJpOWkl4SeQMl8xEfUUV+PDm8350qAS9wCoZPxTuwaCkrMROm/AwV?=
 =?us-ascii?Q?DcvId96wsIUiIzlvdo2XwyT124goFw6A5Liva+EUyFrFmLxmb9K5/LJt6sY/?=
 =?us-ascii?Q?z0U4Ph2VhGC2OGiYOYY5DbDa2coPLae/g1i0kygt8XPceFnks3+Ya/QrkwjQ?=
 =?us-ascii?Q?/5HHDIRjB6fZzFz2wCAO9+F4zSordBygeyvsOEdCYJCHXXv+N42naXuTn6ze?=
 =?us-ascii?Q?UNbv2Q=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b08adede-8ec7-4065-1acd-08dafefacbdb
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5780.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 17:37:14.4415
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eg0YFNvpe2hoSkvxbVSFczfX8Zm6Z4oBSHFjEny4K+oglkrao+EMWadi8M1eLupgWeiDqyu9PDrulgO5dmM9XyZt4hIzFH1xhNQ4/FY62J8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR10MB7505
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Tue, 24 Jan 2023 15:46:01 +0200
schrieb Andy Shevchenko <andy.shevchenko@gmail.com>:

> On Tue, Jan 24, 2023 at 3:35 PM Henning Schild
> <henning.schild@siemens.com> wrote:
> > Am Tue, 24 Jan 2023 11:46:34 +0200
> > schrieb Andy Shevchenko <andy.shevchenko@gmail.com>:  
> 
> ...
> 
> > I would like to keep the number of files and CONFIG switches low,
> > with a focus on the config switches. Every new CONFIG=y/m has to be
> > requested in countless distros. So far i only dealt with debian
> > where ubuntu might follow, did not check others with recent enough
> > kernels ... like fedora if they have the SIMATIC stuff turned on or
> > need to be asked to do so.  
> 
> If you put the proper defaults, you can get good results without
> torturing distro configurations.

Meaning i could try sending a patch to set "default m" for all three
SIEMENS_SIMATIC_IPC
SIEMENS_SIMATIC_IPC_WDT
LEDS_SIEMENS_SIMATIC_IPC

I was so far too shy for that. I would even go further and add
GPIO_F7188X
W83627HF_WDT

Henning

> See how 8250 has been splitting over the time, we have +~5 new Kconfig
> options and their defaults are to keep the current behaviour without
> the user needing to do anything in their configurations.
>