MIME-Version: 1.0
References: <20221007153323.1326-1-henning.schild@siemens.com>
 <Y8mv8PzL1UsP9gNh@google.com> <20230123214859.725cd1c3@md1za8fc.ad001.siemens.net>
 <CAHp75VfSHgdikX5=Qba62BwWofVf7gHhS2hq2OuBwHFz9riCWQ@mail.gmail.com>
 <20230124143514.1abf933f@md1za8fc.ad001.siemens.net> <CAHp75Vf5MAsiYKdmF2oQ2rNDjKUVW9nk5FjPhUcD3b-4r_u6yg@mail.gmail.com>
 <20230125183659.7dd9e0f5@md1za8fc.ad001.siemens.net>
In-Reply-To: <20230125183659.7dd9e0f5@md1za8fc.ad001.siemens.net>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 25 Jan 2023 19:47:28 +0200
Message-ID: <CAHp75Vez1LarRnRDKm+pn52-hwh6dWCnkoHntw9pOqyZ_5C6wg@mail.gmail.com>
Subject: Re: [PATCH v4] leds: simatic-ipc-leds-gpio: make sure we have the
 GPIO providing driver
To:     Henning Schild <henning.schild@siemens.com>
Cc:     Lee Jones <lee@kernel.org>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Pavel Machek <pavel@ucw.cz>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jan 25, 2023 at 7:37 PM Henning Schild
<henning.schild@siemens.com> wrote:
> Am Tue, 24 Jan 2023 15:46:01 +0200
> schrieb Andy Shevchenko <andy.shevchenko@gmail.com>:
> > On Tue, Jan 24, 2023 at 3:35 PM Henning Schild
> > <henning.schild@siemens.com> wrote:
> > > Am Tue, 24 Jan 2023 11:46:34 +0200
> > > schrieb Andy Shevchenko <andy.shevchenko@gmail.com>:

...

> > > I would like to keep the number of files and CONFIG switches low,
> > > with a focus on the config switches. Every new CONFIG=y/m has to be
> > > requested in countless distros. So far i only dealt with debian
> > > where ubuntu might follow, did not check others with recent enough
> > > kernels ... like fedora if they have the SIMATIC stuff turned on or
> > > need to be asked to do so.
> >
> > If you put the proper defaults, you can get good results without
> > torturing distro configurations.
>
> Meaning i could try sending a patch to set "default m" for all three
> SIEMENS_SIMATIC_IPC
> SIEMENS_SIMATIC_IPC_WDT
> LEDS_SIEMENS_SIMATIC_IPC

No, default to another symbol which will be the core part. Again, look
how 8250 is organized. There is no default m (at least new ones, I
don't remember about any historical defaults as such).

>
> I was so far too shy for that. I would even go further and add
> GPIO_F7188X
> W83627HF_WDT
>
> > See how 8250 has been splitting over the time, we have +~5 new Kconfig
> > options and their defaults are to keep the current behaviour without
> > the user needing to do anything in their configurations.


-- 
With Best Regards,
Andy Shevchenko