Message-ID: <0be2faed-6b95-0c15-1016-3b4d1a980998@amd.com>
Date:   Wed, 25 Jan 2023 12:31:34 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v13 1/4] virt/coco/sev-guest: Add throttling awareness
Content-Language: en-US
To:     Dionna Amalie Glaze <dionnaglaze@google.com>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        Paolo Bonzini <pbonzini@redhat.com>,
        Joerg Roedel <jroedel@suse.de>,
        Peter Gonda <pgonda@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <Borislav.Petkov@amd.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Venu Busireddy <venu.busireddy@oracle.com>,
        Michael Roth <michael.roth@amd.com>,
        "Kirill A. Shutemov" <kirill@shutemov.name>,
        Michael Sterritt <sterritt@google.com>
References: <20230124211455.2563674-1-dionnaglaze@google.com>
 <20230124211455.2563674-2-dionnaglaze@google.com>
 <724f03d8-91e9-e870-f063-65c2e98b6ee5@amd.com>
 <CAAH4kHbdLe5-hY5raoSyqhXru9Rz4050_RMDsq8EAEBnWZcKRQ@mail.gmail.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <CAAH4kHbdLe5-hY5raoSyqhXru9Rz4050_RMDsq8EAEBnWZcKRQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzVST2VjVk12RStRTXFQM3dUQlQ0V2RLa0w2YzBjdUt5a3cvaVpPRDJUUDl1?=
 =?utf-8?B?MWd3S1NaVUlnYmZQM0tuR25vVDlRTVFGUWd0cTFZVWN1L3Z4UWZrbURTejl5?=
 =?utf-8?B?OEZ1VE1zK01wRS9jdmo5MWpSc0t3Zml3ZzVCVGM0YmZQOFFNUW1JdFlZU0Nk?=
 =?utf-8?B?MnpGQmV1dDNCU1dCNyt2cnJpNDVnbTk1cTFub0NVMlRrcnhPNE1NOGNVeDFT?=
 =?utf-8?B?ZWJ1NVdyT3dvY1hMcURQVld2OFF6N0UvRS9VTDJIeHhOaFRCbE1VL29KR2tM?=
 =?utf-8?B?ZjNRbHF3VVhJcHFVUnp2Z3ZrVDBNYkNHTDdyMGtnZ2NHL3UxRTRYb3VPRFdR?=
 =?utf-8?B?YldCeWZPUUlqV015U3pRWXFMdUhTQllmZU8yWTFoOStKa251cmt5b2xoZmVS?=
 =?utf-8?B?RFRyQ0F5bEtreldvanB0UkJERVB3Y3ZCTmNuVGZxbldzTDA3NHVEMUZPV3Vq?=
 =?utf-8?B?WlVVTStyL1N4ZHZQRUlIc205V1JUVGdncTN0WWlRTkhjQmFibk43TVNCSTZK?=
 =?utf-8?B?UGJ0QU5RenZRZSsvM0tSLzR4elBGLy9MSCtSMWlLTDliRW9nclE1UnJKbk5Y?=
 =?utf-8?B?YmxxZ2JOUTAyS2Y3TTQyY0tDcnQrUkRRank3WnRVdS9zMUNEOVhxUnRDMGNr?=
 =?utf-8?B?N1RjeFpNRTY2YlFFUzhWbGhBbTAvaG1CTm9seXlYaUx0Q0FYcnFSY1BVdWk5?=
 =?utf-8?B?ZjFKbzJwQUx3clA3SVZtSGRUOGk4dW96aDJMN3hFcm1IRmdwT2J3Q0RnK2JM?=
 =?utf-8?B?VERCUlhUaW4rVEtlbWJXdklYVXdSaHYrcjFEQWcrc0x3TmlNMjFKK29Ncisx?=
 =?utf-8?B?TERKaGRRZWwrU3lTWkoxL3MwNlZnT0ptYWlIN09ackxRRWdLeE9Sc24zYVpU?=
 =?utf-8?B?bjBkTkVSYW94ay95L2RvcUNITTFGUWZhYWZxWjB2UllodDhTWnRGclJISldZ?=
 =?utf-8?B?ZEhVejl1eUs4Zk9yemZBTE00eTNhemxPajlKNkxoaGoxdVJodGlaWFpWaXRi?=
 =?utf-8?B?cGhCbjVBajV5a1VjSlZic0pSUXFqN3g5YnVOYzdEYXVDdjhYUlFKZnpRaUFW?=
 =?utf-8?B?TG1EVThmZjBkOWRMQjNMb1doY29zem16RHhuZE5vZG1zSzNxNFU1U1B2aWZw?=
 =?utf-8?B?KzJjTVJoU09OZ2t3Y05wRGR1VWtwTFNBM1poVzc0a042ck1TdzlaVDg2VUV2?=
 =?utf-8?B?QmZTYktCMTFXVGJpUzIvaHFiNXlWOVVrRFRGWjJROElyaG85Z3FUajJCT0Z5?=
 =?utf-8?B?YUVwcDJXdXN1YVRPZXFDQVRpeUZ4NnJzaWlSUTJIZFF4eW5jNTUwT1loemdE?=
 =?utf-8?B?cEhhNXMzbW9MS2trVzN1RExWMjNzMkUyR2I3OVJLUUdEcUd2bnUrK3hzV3Nr?=
 =?utf-8?B?MFNVbVRQOWpjN3d4V055dDdSR1oycWliczA4Q0ZDNkViSU1RZUU1a2RuRFNU?=
 =?utf-8?B?bC9TZFpSb0VRcGNQYk1iN1dCNy9XS0J6T3hIamc5eEhMQW4zamJIUDJFNmxS?=
 =?utf-8?B?YjEzVlc3YTg3N282ZHRWTnRmMXJaNGpGYmVPNDd4N2MwcEEzWG80RVF5VjFD?=
 =?utf-8?B?dkhRaGNYdnQ1dlpFNDg2cHFRNEx5U2lGcXRsdWtqblZJVjZSckVxSXV5TU5k?=
 =?utf-8?B?QzNVeDVvczlyMWwyYjZwLy8zUnBFb0VZVDlyam5NT0FubE5raWo1ODJYV2Qx?=
 =?utf-8?B?Mm93R3RUcWZaY2Fmclk3Y2FSSVdiQnFPWVl5K3RtSm4vbXc5TmFWQWdxY3Nr?=
 =?utf-8?B?SUh6V1VpTGYxOHc5RjRucktHeE8rdFFrQ0hqWERUbmNadW5JTk9TNHhicVgv?=
 =?utf-8?B?MDhRZ1dmR2ZqZmQrcTJ5VTZVTnp1QUg5c1VCNmpxY3VDR3lvNHR6a2dISTR1?=
 =?utf-8?B?N1BpZ0dDUkxZaWVnQngxUDhYVDVkWXhld28wdXUwUUUrZ0h6VFFXdmdpaVda?=
 =?utf-8?B?Q1BHNmpicHVNcjZtVXFIQ0F1UExHbUl2dnFPc3ZPU3RwU0VrS2hDcjVlMlZp?=
 =?utf-8?B?K1Z5M0txRHdTR2Fnd2p0MjVLRVNmd1RlcTBIYWsvSDRWK2gzWkd0NDdZNmww?=
 =?utf-8?B?RmhBOEZLN0JQTzVwODJobVBIMmpMUVhEdW9FWlN5MFJiNkpUYklvWWdvSEV5?=
 =?utf-8?Q?czOj7W/rfdp+b+gV/khrdhHMi?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ee119060-f64a-4830-0fb4-08daff026535
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 18:31:38.1058
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TnqeeOnvlsjVtTvuJ3aP1q+/sO920BfHM5axM6UbR4i/FQLLOSKED5hsy/m+T0SBm38Bc71ERdvbCyy+hnhIAA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5472
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/25/23 11:48, Dionna Amalie Glaze wrote:
>>
>> So these should really be:
>>
>> #define SNP_GUEST_REQ_INVALID_LEN       (1ULL << 32)
>> #define SNP_GUEST_REQ_ERR_BUSY          (2ULL << 32)
>>
>> Thanks,
>> Tom
>>
> 
> Patch 3/4 cleans them up with just such a shift. They also move from
> arch/x86/include/asm/sev-common.h to include/uapi/linux/sev-guest.h.
> Is it okay to delay that cleanup until after the fix patch?

Yeah, if they're being deleted later and fixed up, I'm ok with that.

Thanks,
Tom

> 
> 
> --
> -Dionna Glaze, PhD (she/her)