Message-ID: <f9566605-c4f8-0306-7f07-86b9e0abebfd@oracle.com>
Date:   Thu, 26 Jan 2023 00:29:11 +0530
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.5.1
Subject: Re: [PATCH 5.15 13/20] exit: Put an upper limit on how often we can
 oops
Content-Language: en-US
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     stable@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kees Cook <keescook@chromium.org>,
        SeongJae Park <sj@kernel.org>,
        Seth Jenkins <sethjenkins@google.com>,
        Jann Horn <jannh@google.com>,
        "Eric W . Biederman" <ebiederm@xmission.com>,
        linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
        Luis Chamberlain <mcgrof@kernel.org>,
        Vegard Nossum <vegard.nossum@oracle.com>,
        Darren Kenny <darren.kenny@oracle.com>
References: <20230124185110.143857-1-ebiggers@kernel.org>
 <20230124185110.143857-14-ebiggers@kernel.org>
 <033ca877-5091-cbfb-6e6c-e49c4adb9a10@oracle.com>
 <Y9F4hxtZnE2GssUo@sol.localdomain>
From:   Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
In-Reply-To: <Y9F4hxtZnE2GssUo@sol.localdomain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3ZCVE9XVzd0RWY2MjZzMm1JMUxmSmlMcjV2NmUzaXYrYVVaN0lCdG52cmJu?=
 =?utf-8?B?NVM5R05PNzBlaVRPRVh0a1Z6S3Y4eE9rQ0ltU3FNdkFabDBUd1Vvb1hLaVRH?=
 =?utf-8?B?Wkl2UloyL3V5NTJhZkttTCt2K2Z3dEgvSWhUM25FUFlHVUdrM092bi9yUTlv?=
 =?utf-8?B?dEN1WjdpbkkrV2dlbHBZNUJNTHNpaXJRTHlsc2pVRkVEemdGcE1aSjY5THJs?=
 =?utf-8?B?WTZXQU5HbmhYL0pidk5aY3JWUEMwdHlRVkdCM21HMEVaYVA1d2VPYlJsNis3?=
 =?utf-8?B?aE9kRkV6UWFWdkRrRDhKak9oVERXbW9IRzBBamNGMjVmbURKTzBaOW01V3No?=
 =?utf-8?B?VkYvT3QvMzVYOHcwd3IvN3l5Tm82cCtLaC81Tm5xMWJpeU5kRkxUWmlIa2N5?=
 =?utf-8?B?OEUxTmMvdC9BM3FDSklNdzhweUpzaUh2cER4d2Y3Z1JSb2FjRGp2cTRGYXJB?=
 =?utf-8?B?dXhlb0hFMm1yWEl2Z2FNVThNRGxuZk1tUGFvN25pOEw5NmpWSGZGeGZITkFa?=
 =?utf-8?B?Z1htV3c5amk0TXdhd20rSmV5NTlOSmVsU0pwSi9obWdLdUw0TStnQW4xbEQv?=
 =?utf-8?B?Q3gyY0VzM2NNMlM3cjhUK25ZTmZmRUQ3WlhPK0VldHFoZE9sNHdKc3lPTDlS?=
 =?utf-8?B?QUtKSS9DVXFvaHMvbnVLSGMvS0RjMWNmdWJkOE45R2p2b2poM1FSY2tRcFdt?=
 =?utf-8?B?NDUxTHoxSThoWTdXTGx6d0QzV0l6Kytic3dkcGhzSGdzaHd6SU9TeHhmL2Zx?=
 =?utf-8?B?cU55TmNtS1o4ZWZlbG9uYlowUE5xVjh6akdqSGdMRjhqdmFHN3VqQ0tPWXNV?=
 =?utf-8?B?L0RZSnlqUjUvdFRpL2plMk56UjczSFFFMys0WVdvQXNSS1JKbkR3S0c5aTAx?=
 =?utf-8?B?OU1sQ1NGNC9kbkxEOW43a1JqRUFtbnhyT0dIY1pFTmVIa2xyOGk4dkxtbXRY?=
 =?utf-8?B?N1Z6QXJBRkFwSUhjUWZ2bkI1djV4cFZvWHU5dVBDUlRnenVRMTBQN2tsdksr?=
 =?utf-8?B?WjhmQ01JdkNtMEVISzdMSy9WaEZTYzFWYWUwZUJmdXJQdlJKNlpWaXY0Z1JH?=
 =?utf-8?B?RGovbEtSTGxkQzBiYUJRN05GMnBPQ1F0KzJJaVF1cmhVY0VxZm9Ncno2ZFFn?=
 =?utf-8?B?WmxpbnNnTnhyMVF6YzJEUVB0dlpabkxlSjJxcDQxOFNEZkswNnpJejFQeC9W?=
 =?utf-8?B?RURyQUk1TU5XRDYrTVNQQzVPVThSTjlRSWcvSXVSUlV6UERmMWJnWWZJcHdZ?=
 =?utf-8?B?RDM5eUVRYUNMYmhYUW55VHVPeGFnRHNGd2VyN2hzZ2hPRnFUM2dkKzU2aTJM?=
 =?utf-8?B?YmYxNXgydjl6UjRPOXlCY0dxaEpqbVlJOHVFU3B0MW15eVIyYUlVSGJEbGQ1?=
 =?utf-8?B?b2V1REdURmlHSFFRNHArbUdBNnBLMXlrSHQ1dXVTQ0VhbFBZa3FFWnhTbEtL?=
 =?utf-8?B?TUFPODI4emNzUnI4UnhKV1h1Z2lIaEtrMXkyWFR2VXQ3NkRsK0VTcFBieWh2?=
 =?utf-8?B?YVQyemtNNVBsUEdmWkNsOVFBN0N2QTgxMnlmY0FaYU9zbUdqSjA3bGtOSVVh?=
 =?utf-8?B?Yk5RNXJTMGJPV2x2SllqTXVncUFjVTl3ZjlsUEpwQ2taTS9ITnIyOHQ5MklS?=
 =?utf-8?B?aVpSc2p2RmFuQVcxVVZ3YVNoWUZ1c0pKTm5ZaFJUTldNWFcrUUw3dHlpcU1m?=
 =?utf-8?B?ZHIvUkZ3Wk9FSUJ0UlBpWVZVbDdKK3N2eGxYdTEyTHltVWJBZ2NwYldQSVp1?=
 =?utf-8?B?a0Nya2oyWk1LRUliMStxZno3SnJhbUIzM0hJZTZFT0NEUmxmb1l1VXRXY2py?=
 =?utf-8?B?OFA1WEp1RWppbkxtYmhvaWh1ME9pdmRsa0RVUnFrMHJ5bkJrRWF6b2ZHMXV1?=
 =?utf-8?B?NDBiZFdwc3RQSE5uUnp6QkdlaWNINWNLUlJ6c2pnL3A4U0N2a2tGT1h6WGxT?=
 =?utf-8?B?OXQvZTkvVUd2eUhjdGdwY3MvWVN4YVBLempsaEpLTVpVYmw0bXV5RGVFTHNV?=
 =?utf-8?B?N0FQNGRkR25ZVUFkdnBES3Zaek1YUjd6VS91SmlpcW1qcVRaZjdpTmhvbzAv?=
 =?utf-8?B?Y1JFaEJZM3h1QVZnN1hIcllVUzE5UnhhaU5PSm9JeElrZExHRmtoVUFTclpJ?=
 =?utf-8?B?MThBOHB4QmVUbnhkdnd2ZnlJVVB1ZmhxdkRzZEluRG80djVxZmxRVGgyeW5q?=
 =?utf-8?Q?KQkuVQn2P5yQIGITAnrN/nQ=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?SjV6SjVKeUVyTnVXM3pUTFVnZGJBUnRsTWdCaUdKMmJaWm1BQm9MUHhSV3VP?=
 =?utf-8?B?WlpmeUt6UW5VZTY1eUxHTnhwYkdxNTdHZEdpekNNbjhYaUgwS0puaGNhNFhu?=
 =?utf-8?B?K0FueXAvdm5wcE9pV0FTV2dPRUFxbVpKc0dhdVo4Y2N1K1g2K0dvenBJUm5C?=
 =?utf-8?B?MXBNVXNSQ3VEeTA5VE9QQnhmOWxpQk5rdlhBZkF3a3lUWUZKSmZJSGJSMSsz?=
 =?utf-8?B?cHZyMXp6Z294WDRoLy8vM0JnSTV5SFNxTEw0OUFhWGEwcGczUmhZMmhNb0dM?=
 =?utf-8?B?c1B2TU1WSVNMRzZtSTArSy9rYlRIcHRTRVBYMXdBNzR2NnAyWURxbnYyN01W?=
 =?utf-8?B?NW9KVTh1VStwSmlac1VwL2xlLzBubzN2YnMyTEc4L3FPRWdCem1DeWk0N3Qz?=
 =?utf-8?B?b3pLT2JZYlM3SFpXZVUvM1FpbkVlWkxkeWZhWlN0bjhBZTVvbkhGWlpOREFW?=
 =?utf-8?B?YXJZMkhaRWx4ZllwQ3BFVTdIeTdUNEZKSDJIa0RwVVk3dGVNcm9tS0NIVXNI?=
 =?utf-8?B?d2srU2IzMW9GaENmeU5KellVN01HZDkxQnE5Y3Z4ZHNFUUd0emg5NjJUbTVJ?=
 =?utf-8?B?UmJBMnJvWnRLWnV1aVp1NVF1S0kwTkszVnVBMk0rbk5PRGJWWHhiSHltaTBY?=
 =?utf-8?B?aTRpaTJGdGp0RHBONEJZOGhCL25tOWxza3ZXT2dvVThxQjFhUUJCdFdPNU5i?=
 =?utf-8?B?Wk0vcXptV29xUjNnSzJiMEh3QVk5cTBpbkJOU1kweTZwZE8rSDI0a2YrZzFo?=
 =?utf-8?B?bklweG94cWFEMkhIV0JGRWNFd3lTZGQyQ2thYkhYSktBdE9Cckgwd2pwSDU5?=
 =?utf-8?B?TkZhTHVJRnJuekpiV05TQ1JhQ2hhb0h1RHllL1hnd2pwWXJ4TmZFanFXcW1N?=
 =?utf-8?B?TWVOZG9lYlRhRm5lQ2V0NzJaTm9YRnFOV2pFdXVUbU9wang3NXFTeGQzYjlo?=
 =?utf-8?B?N2pmZWFUUFhwTHByVzF3bmhhc1ZQZk90dmRiZ2VxMmh0WWQ0d0k3NDBjeE96?=
 =?utf-8?B?aEd0eDEwTml3TXo5L0U3L1pCOFdyYWVwQk8rRGFoM3JSalhHSU5PQmpUL2gx?=
 =?utf-8?B?SXNveTU0aWxHdW9jcmJoYm5qQ09pWnBDMlk1NUNKbTBQSzd5MER6M3dBODVO?=
 =?utf-8?B?YWZyOGt1Zko1Ly9ELyt3Qjk4YWkyRTVoa21HOFljY3NkZ1NUYjhpUlcrSTNm?=
 =?utf-8?B?alR5bncxanBjNDZsbFFRazVJclB4ck9iRFNwMDVKVkx0L1EyQU4rcUFWeEVH?=
 =?utf-8?Q?tIknm9mVYqDU36A?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5d0b3b7-ed6f-4c0f-b01b-08daff0648d7
X-MS-Exchange-CrossTenant-AuthSource: PH8PR10MB6290.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 18:59:28.6139
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dqLUgXoFLOkud3nY5FRMq2lUYm6AvDgEE+gPzJ4PWwLPd1AABNmUDWZB75Di+iqMIplpiwponEdGiBNNRwHZS5lusVIR2qJVMgvXUTaKDfLmL3LvPsaR8zmvLhbkS9bM
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6468
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-25_12,2023-01-25_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 mlxscore=0 suspectscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2301250168
X-Proofpoint-GUID: 4KDu0CNmIFRXkrCQzSUSMn5-znP7sC9W
X-Proofpoint-ORIG-GUID: 4KDu0CNmIFRXkrCQzSUSMn5-znP7sC9W
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Eric,

On 26/01/23 12:14 am, Eric Biggers wrote:
> Hi Harshit,
> 
> On Wed, Jan 25, 2023 at 07:39:10PM +0530, Harshit Mogalapalli wrote:
>>
>> Thanks for the backports.
>>
>> I have tried backporting the oops_limit patches to LTS 5.15.y and had a
>> similar set of patches, just want to add a note here on an alternate way for
>> backporting this patch without resolving conflicts manually:
>>
>> Here is the sequence:
>>
>> * Patch 12:  [panic: Separate sysctl logic from CONFIG_SMP]
>> --> Cherry-pick Commit: 05ea0424f0e2 ("exit: Move oops specific logic from
>> do_exit into make_task_dead") upstream
>> --> Cherry-pick Commit: de77c3a5b95c ("exit: Move force_uaccess back into
>> do_exit") upstream
>> * Patch 13 which is Commit: d4ccd54d28d3 ("exit: Put an upper limit on how
>> often we can oops") upstream, will be a clean cherry-pick.
>>
>> The benefit may be making future backports simpler in make_task_dead().
>>
>> This was the only difference, so your backport looks good to me.
>>
> 
> It's certainly an option.  The reason why I didn't do it that way is to reduce
> the impact of any potential bugs where do_exit() is still called when the new
> make_task_dead() function should be used instead.  With my series, the effect is
> just that oops_limit won't take effect in such cases.  If we also backported
> commit 05ea0424f0e2 ("exit: Move oops specific logic from do_exit into
> make_task_dead"), then do_exit() will lose various other things, such as
> panicing when called from an interrupt handler.  That would increase the chance
> of regressions, unless we made absolutely sure that everywhere that should be
> using make_task_dead() is indeed using it instead of do_exit().
> 
> Commit 0e25498f8cd4 ("exit: Add and use make_task_dead."), which I backported,
> did the vast majority of conversions to make_task_dead().
> 
> Some architectures still have uses of do_exit() that got cleaned up later,
> though.  It seems it was mostly unreachable code, and some cases that should
> have been doing something else such as BUG() or sending a signal to userspace.
> So, generally not super important cases.
> 

Thanks a lot for explaining!

> Still, getting all that would bring in many more patches.  We could do that, but
> since this is already a 20-patch series, I wanted to limit the scope a bit.
> These extra patches could always be backported later on top of this if desired.
> 

Sure.

Regards,
Harshit
> - Eric