Message-ID: <e9277836f6797a1b2aaca2300190da9a.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230125104520.89684-4-quic_kathirav@quicinc.com>
References: <20230125104520.89684-1-quic_kathirav@quicinc.com> <20230125104520.89684-4-quic_kathirav@quicinc.com>
Subject: Re: [PATCH 03/10] clk: qcom: Add STROMER PLUS PLL type for IPQ5332
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Kathiravan T <quic_kathirav@quicinc.com>
To:     Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
        agross@kernel.org, andersson@kernel.org, arnd@arndb.de,
        bhupesh.sharma@linaro.org, broonie@kernel.org,
        catalin.marinas@arm.com, devicetree@vger.kernel.org,
        dmitry.baryshkov@linaro.org, konrad.dybcio@linaro.org,
        krzysztof.kozlowski+dt@linaro.org, linus.walleij@linaro.org,
        linux-arm-kernel@lists.infradead.org,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mmc@vger.kernel.org, marcel.ziswiler@toradex.com,
        mturquette@baylibre.com, nfraprado@collabora.com,
        quic_gurus@quicinc.com, robh+dt@kernel.org, robimarko@gmail.com,
        shawnguo@kernel.org, ulf.hansson@linaro.org, will@kernel.org
Date:   Wed, 25 Jan 2023 12:35:13 -0800
User-Agent: alot/0.10
Precedence: bulk

Quoting Kathiravan Thirumoorthy (2023-01-25 02:45:13)
> From: Kathiravan T <quic_kathirav@quicinc.com>
>=20
> Add the support for stromer plus pll, which is found on the IPQ5332
> SoCs. Programming sequence is same as the stromer pll, so we can re-use
> the same.
>=20
> Signed-off-by: Kathiravan T <quic_kathirav@quicinc.com>
> ---

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

I'm amazed that we need so many different register layouts for PLLs. Was
it really never standardized? So sad.