MIME-Version: 1.0
References: <20230125143425.85268-1-andriy.shevchenko@linux.intel.com>
 <CAMUOyH2Kc6hL4564sYDZdGRjiJJYmDA5WXEsF92p_xN8iZGMsg@mail.gmail.com> <Y9GKje/7t79cxecC@smile.fi.intel.com>
In-Reply-To: <Y9GKje/7t79cxecC@smile.fi.intel.com>
From:   =?UTF-8?B?SsOzIMOBZ2lsYSBCaXRzY2g=?= <jgilab@gmail.com>
Date:   Wed, 25 Jan 2023 22:54:58 +0100
Message-ID: <CAMUOyH163WY3Csbs8QOy6VssrR9TXZRi6ChnqPn=PO7z12rZOQ@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] usb: gadget: Use correct APIs and data types for
 UUID handling
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Jan 25, 2023 at 9:01 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, Jan 25, 2023 at 06:31:36PM +0100, J=C3=B3 =C3=81gila Bitsch wrote=
:
> > On Wed, Jan 25, 2023 at 3:34 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > We have two types for UUIDs depending on the byte ordering.
> > > Instead of explaining how bytes should go over the wire,
> > > use dedicated APIs and data types. This removes a confusion
> > > over the byte ordering.
> >
> > Thanks for pointing this out. I was unaware of the exact UUID
> > functions, as I'm still quite a newbie here.
> >
> > I compiled and tested your patch in my test setup and it works perfectl=
y.
>
> Thanks for the testing. According to Submitting Patches documentation
> you can provide a formal Tested-by tag.

Thanks for pointing this out to me.

I'm not really sure how to do that though.
On https://docs.kernel.org/process/submitting-patches.html#reviewer-s-state=
ment-of-oversight,
it says:
> Both Tested-by and Reviewed-by tags, once received on mailing list from t=
ester or reviewer, should be added by author to the applicable patches when=
 sending next versions.

So I guess you could do that at your convenience on any next version.
Or is it already ok, if I just add the following line in my comment?

Tested-By: J=C3=B3 =C3=81gila Bitsch <jgilab@gmail.com>

I'm still quite a newbie in the kernel development community, so
thanks for bearing with my ignorance :-)

Best regards and thanks a lot,
J=C3=B3


>
> --
> With Best Regards,
> Andy Shevchenko
>
>