Message-ID: <b24dbfb4-8b02-bb30-d859-a313a4aaa363@linaro.org>
Date:   Thu, 26 Jan 2023 00:33:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.7.0
Subject: Re: [PATCH v4 1/3] clk: qcom: smd: Add XO RPM clocks for
 MSM8226/MSM8974
To:     Stephen Boyd <sboyd@kernel.org>, Rayyan Ansari <rayyan@ansari.sh>,
        linux-arm-msm@vger.kernel.org
Cc:     ~postmarketos/upstreaming@lists.sr.ht,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Luca Weiss <luca.weiss@fairphone.com>
References: <20230121192540.9177-1-rayyan@ansari.sh>
 <20230121192540.9177-2-rayyan@ansari.sh>
 <06d53a3fa48080d902476b71308e69bd.sboyd@kernel.org>
 <4c531c68-b74f-2f90-e8f6-98a4b0316cd4@ansari.sh>
 <a7058fb92642a1661995d7d3ca6411bd.sboyd@kernel.org>
Content-Language: en-US
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <a7058fb92642a1661995d7d3ca6411bd.sboyd@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 26.01.2023 00:00, Stephen Boyd wrote:
> Quoting Rayyan Ansari (2023-01-25 14:25:08)
>> On 25/01/2023 20:58, Stephen Boyd wrote:
>>> Quoting Rayyan Ansari (2023-01-21 11:25:38)
>>>> Add the XO and XO_A clocks to the MSM8974 clock list, which is also
>>>> used on MSM8226.
>>>
>>> Why was this missing for so long? Does this break suspend? Why are you
>>> adding it now?
>>
>> I am adding it because of a recommendation from a maintainer on an older 
>> patch version.
>> See 
>> https://lore.kernel.org/linux-arm-msm/20230119023337.h6a7f56lizhv4tcy@builder.lan/#t
> 
> So nobody has tested this on msm8974? Can you add this information to
> the commit text?


And can it be tested on msm8974?
+ Luca

^ could you, please?

Konrad