Message-ID: <4ec549dcec8686b9d1eed619965fde0b17736f17.camel@nxp.com>
Subject: Re: [PATCH v2 2/6] drm: lcdif: Drop unnecessary NULL pointer check
 on lcdif->bridge
From:   Liu Ying <victor.liu@nxp.com>
To:     Marek Vasut <marex@denx.de>, dri-devel@lists.freedesktop.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Cc:     stefan@agner.ch, airlied@gmail.com, daniel@ffwll.ch,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com,
        krzysztof.kozlowski@linaro.org, LW@KARO-electronics.de,
        alexander.stein@ew.tq-group.com
Date:   Thu, 26 Jan 2023 10:10:38 +0800
In-Reply-To: <d035621a-33a6-ca38-1bb3-726b3dd0eab4@denx.de>
References: <20230125064030.1222121-1-victor.liu@nxp.com>
         <20230125064030.1222121-3-victor.liu@nxp.com>
         <d035621a-33a6-ca38-1bb3-726b3dd0eab4@denx.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3JHek10SkoxbFFlaXpkVE1kNzF5UUxiNnREc1lqUXQwb3h1ZFpBckZUNEtG?=
 =?utf-8?B?cmNXcDFxSUo2TlpEbmljMjN0N21NcFk3N0JZY2kybTgvLzVKamNVZitLSUlp?=
 =?utf-8?B?WmNHT2VENEh1ZXZ1K2s2RnFrSkdnOC9ydnJWSnFLbko5UGJCVmF4STRlY3RJ?=
 =?utf-8?B?T2d5K3NFL0drVGFrMnNLQnY2NWNsUWZaSHlhV1hVWk1ZdjhVMFBVaEJUR0c3?=
 =?utf-8?B?ZUxqNFJtUTI5TXVNZGs4Y1dVWlZla0drSDcyOUdxTnpJNFBhZTdaRklBeGto?=
 =?utf-8?B?T24vWVBCcGxsN21RNE1BbjFoWU1HY0JMOEdqei9wMUk5RmtkbW1HeTBDUWdE?=
 =?utf-8?B?anpicWZSRlNjZ0RaVHM0YnN3V3dQUmtVWVk1QkJBYzhZNDYzMmhLWkhqTEtl?=
 =?utf-8?B?ZXhhQlZOdDY3VnN1NkRBVytYenZ0OFZKSXFkc0c0Y05xNmRhR1lLRVNHQzZK?=
 =?utf-8?B?RTRITHZCRVR0YmY4aDBaem1pOUpsQ3dndGl2U3c4aStCWlJWTE1QQzh0Rjl5?=
 =?utf-8?B?T1VYWWJtb2xkNHBWTTM3K0M5MWlVZG53WHB2L0lLYll2UHErUGFuOHdLVk4z?=
 =?utf-8?B?NjF3V2xGMWs3VVB2TmhGU1RpUUdvSWJCMmxSUE1LS0puL1lPbS9vV0tOL3Nz?=
 =?utf-8?B?RGtwUi9rU082dGM1YmltZ0M3YnY3NUtkdHFzZ0txa3hWNytROVZMbzRSWWdy?=
 =?utf-8?B?RE9lVkszQzVBc0ZMWVlxS3NXL3pmeG1ZalhBdmFmZEZsb1czeUlOVTAvOGZY?=
 =?utf-8?B?WVBHUDQyY0gwVDE0bGg5eGJmRnh3VHBlY3pSbWhPMVFhRDVzd2JMczJLQ25J?=
 =?utf-8?B?QTFVLzlxdXVCVks0eHZ1RkIvT0ZVaHZNTFZzWGhmVzdqeDZ0WGREK3hybWRy?=
 =?utf-8?B?NDgwWXkzSm5uWE4yNWhkZCtrY2dkTFZxOUx2d0ZXVWZzLzIwL2QyZFM2Wkwz?=
 =?utf-8?B?dCswY2tYS3NOYXVLdFFxQlFoNVI1QzhvYURRTFFrQnpsanZ1Y3hpdU5PNGVC?=
 =?utf-8?B?Wkh0YXhSUjdXK2htVE9EaG5IR1B5V2xPT3lRV2NiMFlFMW1HQlpKT1V2WWV4?=
 =?utf-8?B?Q3JYUlhFdG9HQ0hPT2hUWVhZNzNyc0lrZUZzUGRYMm1taW1HTTFXN09nVmpH?=
 =?utf-8?B?Y3kyelE1Q3Fyb3gzVGJBMXpJd0xlOGxJRmFLZnFJcUtXY29UaUtpbE5QSjVv?=
 =?utf-8?B?eE45bytXYlVnZVhINDNUMWFJTW9EQ0FPcEg1S3BpSUtOd3BheE5HOThMOWJB?=
 =?utf-8?B?NWF1OEpmeTlUK2hSa0NEejFDaE5aWDdlWjk3blhveWRlanpObC82Um5xdzVk?=
 =?utf-8?B?ZEExUU92dGM2VUdRSmJPOFZzenFxVkhTQlY5aW1jNHM4Wlc4eE9TUEp4QmdR?=
 =?utf-8?B?YjVKcXJ5OTZUdGlWR0l4ZkJZajZmR0xZbHJPOVNqc09PK3R3bTYwNEwremZT?=
 =?utf-8?B?c1Zyc2FtRGN3SmxGYzV3Y1NaRXA4b0NrZmlWVGVvZ3pITkpTOUt5ZHRhc1h1?=
 =?utf-8?B?NWsyK0lEYzdiRk8wNnp5Sk4wZVFPS2pZRXR0aHpkc3NlZWlLTi85YlplOGxl?=
 =?utf-8?B?Rml2bmpRSjVZeDhFY0xFRjZiNnJ4MzAxT25VbEhOSzhqaWZvUnIxTSt4YlZv?=
 =?utf-8?B?UktSQUNkekVrWnA3N25Zb1M1ZGVFK3EzQ1c3Y05COUZVeFBUTlQxQVhIZ2dX?=
 =?utf-8?B?SzlPRGNsQmV6ZTM0ekE0Y1RmV0VRWkpHak1ZMXoveDg0V1J3MkU2UDdYZXZ4?=
 =?utf-8?B?WjA1Mi81dzBQcGRJS2pTNk02V05yZ2JDemUvbEpKUFRlemcvZjA0TEdGR2Rv?=
 =?utf-8?B?OFNLRDJlZzJTOU5XbitkRjR4S1NqdlRnSmtZR1lZYzNNVm9ETWtDL0V4RDlL?=
 =?utf-8?B?eHN0b0pZL3VLZ2tBdUhBSjV0aEJ4T1FDWWhIM2xSR0pwbVZiZ09kYlRWM05K?=
 =?utf-8?B?cTNZamY2K3BNaTFkS2xxZ3ZaR0Q0ZlphSlVad203MzNZWll2UW5raWh5Q1lp?=
 =?utf-8?B?TTVaOXN4UCtTcDI4Tm9oL1dEZVNVblJQRVRMTGlKQlA0eW0rNVRTZjlXWThX?=
 =?utf-8?B?WWNHMjZiYWNxRHhZTGtDUUlHRlA0Mzc1Mk0xdXAwc3pBZm5KRk1Xa05PODhl?=
 =?utf-8?Q?qZcxIamDR7/7XuwjI9VxqMikt?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8019d23d-c4af-4a5a-d9aa-08daff429893
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 02:11:12.2690
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LZ/YELYN9zq8W+EcA0C/n1LaxE8VEVyJlpRS6UPPddXmGku8cEs0owkBAHMKsxhHfrr9ad42fcKOCUhXSIwRSA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9404
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2023-01-25 at 14:56 +0100, Marek Vasut wrote:
> On 1/25/23 07:40, Liu Ying wrote:
> > A valid bridge is already found in lcdif_attach_bridge() and set
> > to lcdif->bridge, so lcdif->bridge cannot be a NULL pointer. Drop
> > the unnecessary NULL pointer check in KMS stage.
> 
> Is it possible that a panel (instead of a bridge) be attached to
> LCDIFv3 
> e.g. in case of iMXRT ?

According to IMXRT1160 and IMXRT1170 reference manuals, it looks like
LCDIFv2(similar to LCDIFv3, but not the same) may connect to a parallel
display panel through a mux(either eLCDIF or LCDIFv2).  That mux could
be a bridge.  But, it doesn't matter, because devm_drm_of_get_bridge()
may create a panel bridge if a panel is connected directly(See
kerneldoc of devm_drm_of_get_bridge()).

Regards,
Liu Ying

> 
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > v1->v2:
> > * Split from patch 2/2 in v1. (Marek, Alexander)
> 
> Much appreciated, thanks.
> 
> [...]