Date:   Thu, 26 Jan 2023 09:31:37 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Jonathan Corbet <corbet@lwn.net>, Stefan Roesch <shr@devkernel.io>,
        linux-mm@kvack.org
Cc:     linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org
Subject: Re: [RESEND RFC PATCH v1 10/20] docs: document general_profit sysfs
 knob
Message-ID: <Y9HmCY5zEiD/yCPi@debian.me>
References: <20230123173748.1734238-1-shr@devkernel.io>
 <20230123173748.1734238-11-shr@devkernel.io>
 <Y89Zko/TWYcphmJA@debian.me>
 <87h6wfhpi8.fsf@meer.lwn.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="yNjPRXiGv58sTMBT"
Content-Disposition: inline
In-Reply-To: <87h6wfhpi8.fsf@meer.lwn.net>
Precedence: bulk


--yNjPRXiGv58sTMBT
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 24, 2023 at 09:21:51AM -0700, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>=20
> > Seems like the wording is confusing me, so I write the improv:
> >
> > ---- >8 ----
> > diff --git a/Documentation/ABI/testing/sysfs-kernel-mm-ksm b/Documentat=
ion/ABI/testing/sysfs-kernel-mm-ksm
> > index 7768e90f7a8fef..5309a912ab679b 100644
> > --- a/Documentation/ABI/testing/sysfs-kernel-mm-ksm
> > +++ b/Documentation/ABI/testing/sysfs-kernel-mm-ksm
> > @@ -56,6 +56,6 @@ What:		/sys/kernel/mm/ksm/general_profit
> >  Date:		January 2023
> >  KernelVersion:  6.1
> >  Contact:	Linux memory management mailing list <linux-mm@kvack.org>
> > -Description:	Measure how effective KSM is.
> > -		general_profit: how effective is KSM. The formula for the
> > -		calculation is in Documentation/admin-guide/mm/ksm.rst.
> > +Description:	Measure the KSM profit. See
> > +		:ref:`KSM documentation <monitoring-ksm-profit>` for details
> > +		on the calculated formula.
>=20
> So the original at least attempted to tell us what "KSM profit" is; the
> "improved" version makes no such effort.  I don't think that is actually
> better.

I overlooked that, thanks!

--=20
An old man doll... just what I always wanted! - Clara

--yNjPRXiGv58sTMBT
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY9HmCQAKCRD2uYlJVVFO
o47gAP9Pr/JO3RwPkqRmtfmLZ7BhyCG3fv7UG8NSuCjLg7nthQD/bpZeTPQb+WXZ
5VZo8azAg6zACdVjLL40ChkmXlNWPQg=
=FWAf
-----END PGP SIGNATURE-----

--yNjPRXiGv58sTMBT--