Date:   Wed, 25 Jan 2023 19:33:25 -0800
From:   Josh Poimboeuf <jpoimboe@kernel.org>
To:     Michal Kubecek <mkubecek@suse.cz>
Cc:     Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: check that module init/exit function is an
 indirect call target
Message-ID: <20230126033325.kuww43xyqykikuw4@treble>
References: <20230118105215.B9DA960514@lion.mk-sys.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230118105215.B9DA960514@lion.mk-sys.cz>
Precedence: bulk

On Wed, Jan 18, 2023 at 11:52:15AM +0100, Michal Kubecek wrote:
> Some out-of-tree modules still do not use module_init() / module_exit()
> macros and simply create functions with magic names init_module() and
> cleanup_module() instead. As a result, these functions are not recognized
> as indirect call targets by objtool and such module fails to load into an
> IBT enabled kernel.

I'm struggling to understand why a manually created init_module()
wouldn't create the ENDBR.  Does it only happen when init_module() is
declared static?

-- 
Josh