Date:   Wed, 25 Jan 2023 23:43:18 -0500
From:   Gregory Price <gregory.price@memverge.com>
To:     Oleg Nesterov <oleg@redhat.com>
Cc:     Gregory Price <gourry.memverge@gmail.com>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        avagin@gmail.com, peterz@infradead.org, luto@kernel.org,
        krisman@collabora.com, tglx@linutronix.de, corbet@lwn.net,
        shuah@kernel.org
Subject: Re: [PATCH v6 1/2] ptrace,syscall_user_dispatch: Implement Syscall
 User Dispatch Suspension
Message-ID: <Y9IE5tBjY1GlFCFH@memverge.com>
References: <20230125025126.787431-1-gregory.price@memverge.com>
 <20230125025126.787431-2-gregory.price@memverge.com>
 <20230126003008.GA31684@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230126003008.GA31684@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?UDXE8rul8qXVhfn0umWIZ1yHHOFVJVPxbidN1ZLpJfm0fXhl1uEQ8P6wnuW0?=
 =?us-ascii?Q?dmWdTe2QD0H5L1LAsmJW8goDvzU0NYSTubGo/hs3xsBg9stplifzS0iPyxG/?=
 =?us-ascii?Q?D7SUmQjxC5sYoz0uxt6x1dSrqbmYyxK3JvS/y2U/DOGvJ3G8eNGi8paaWlHj?=
 =?us-ascii?Q?T6qHjCBO+BgXplgIopnFVIKBzazw0Zg6Lob5FaLziuZrvE5vjYRzFHR7dDSf?=
 =?us-ascii?Q?rZYHumhj/xQAY2knSy/jaq27KDpxUGQaAu+eOyMsC+WvvdgoUQKYEliPV2as?=
 =?us-ascii?Q?7hAGjk621bi0HWn849w6GuGCAahvdw4zmEyfrPlswdHmex0eMTlZ79ULhev2?=
 =?us-ascii?Q?r+kG56GuAo5v3iz91xicty6LOXsDvxRUXF1+1NGbt28LiJ3fEOb6Yq3GX3YJ?=
 =?us-ascii?Q?q1T+A7vkazYE1j/3cvmlD0gUzgvwX+U1pmGGJO7Rr3S2rk0/beSuQs14IJa9?=
 =?us-ascii?Q?rN1NDHnk46c1IqcWhh9SNDZcvn+sF+G0swUDdKMKQ2u9Cpi7s2Z/uJULX4vU?=
 =?us-ascii?Q?ZLLwfg6poqDrC+GAIisxwhEHb90rYIRuT71H4B9EPiGAVkAJna/GKPGKacQj?=
 =?us-ascii?Q?FGeV1hgZT6/0lehjD7KFO3q7HALAsDp9WKijPZ+XeZ4Qvea/QqfChJiy6RoM?=
 =?us-ascii?Q?Qzd6u/DYxEw6mDG9vLsdzcfoyyI0HvHX5X9Jb3hNd/Dpnag+MDzK86FwHxah?=
 =?us-ascii?Q?o+iwvg94Miq5UDYyJXgJl5UH/Ixvg73lZL9l3CXulRBbkO3UozOR1ObP8jod?=
 =?us-ascii?Q?4jEtzORjM/x55Erecc1/8mYxMfrOqG9BlMuNX1IE9MlxwTBTG9tri4QuRnkK?=
 =?us-ascii?Q?CXSMaBWDJVYxMAVM2MvTlg+GVvnAgtVbe6swft7OXQ6qwNyjPfAMUxQmjTsk?=
 =?us-ascii?Q?B21gwTXiS4v5tAiKH8jclaKJ5PzmquAtUvBx2Xy+IM6tlVjf4bklSoREWJoV?=
 =?us-ascii?Q?RGfb2qWwxhWU89W5+SvR+3GiIUE/Byx4AjzVqhoOMp0qfEei7zocJ5nJWxPA?=
 =?us-ascii?Q?QM9a6jDoAfjBrjNv14yF9R7cJoRQvZTuXSvA/F4old/8f33x+GH8k2jXIDu/?=
 =?us-ascii?Q?b82VRqQHTt2ZAOCyUgmmEBOWd/orJZgMg9rJ0T6TYJL3O8jjb4L1cs8h/Ply?=
 =?us-ascii?Q?RnxIl1LwywSL26foX+gksCtoS7YUkYOxMZ7Z8oMG+nxfeMWdSLAOJEAmloSB?=
 =?us-ascii?Q?s8ylvwUJ7sqoZRtDlwdJ6oWlfs7ZnDmxQZgCQOmqiDIaUQmEVbr8vPr4RUle?=
 =?us-ascii?Q?jcu6Xpxo+DCqWwitsVu+aw5+gqwBQQfxuc8T2LqAjbI5DeHt4spYbscJZ7cA?=
 =?us-ascii?Q?PFZG7BmgDHzncETDdnRmPC91BrkmZzRcxyI8DHHkeoxOsScYOKG3ixRoEjS5?=
 =?us-ascii?Q?ab0/02qEx4pl+sojEkfU4GtZrwb/bur62Z6WCKDbcVohnVxBgx/SdwH3BfKw?=
 =?us-ascii?Q?km5vF5hT9wEjNojjQxLqgbHKFzNnX2u6dbc9K722uY4jgUNpkrIARK+K0Fji?=
 =?us-ascii?Q?jg52Xs2LitgiBvyX6sUrenyQ4pIb8zWrejT8dnXnC0waZClZd2WvMqKqroI5?=
 =?us-ascii?Q?wuZVq+rYxzk/K2UMlDVDmUPiyZYbIF4WWQqYFDokYzWBmhBleSGAco9Q2UR8?=
 =?us-ascii?Q?fA=3D=3D?=
X-OriginatorOrg: memverge.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c3d04389-0a7c-48c7-79c6-08daff57de1d
X-MS-Exchange-CrossTenant-AuthSource: BN6PR17MB3121.namprd17.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 04:43:28.2245
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5c90cb59-37e7-4c81-9c07-00473d5fb682
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: s+iXwA9uAuqZrPvFZzkYLZNx6DS9kyL4u+f/jXunFZMsoLos857rV3G237I511YVB6M/Nv1gQaY23QVBNdiUH3z4VREfE7mD59HqhiuEGqo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR17MB5857
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jan 26, 2023 at 01:30:08AM +0100, Oleg Nesterov wrote:
> On 01/24, Gregory Price wrote:
> >
> > Adds PTRACE_O_SUSPEND_SYSCALL_USER_DISPATCH to ptrace options, and
> > modify Syscall User Dispatch to suspend interception when enabled.
> >
> > This is modeled after the SUSPEND_SECCOMP feature, which suspends
> > SECCOMP interposition.  Without doing this, software like CRIU will
> > inject system calls into a process and be intercepted by Syscall
> > User Dispatch, either causing a crash (due to blocked signals) or
> > the delivery of those signals to a ptracer (not the intended behavior).
> 
> Cough... Gregory, I am sorry ;)
> 
> but can't we drop this patch to ?
> 
> CRIU needs to do PTRACE_SET_SYSCALL_USER_DISPATCH_CONFIG and check
> config->mode anyway as we discussed.
> 
> Then it can simply set *config->selector = SYSCALL_DISPATCH_FILTER_ALLOW
> with the same effect, no?
> 
> Oleg.
> 

After further investigation, I believe we can drop 1/2, but for a
different reason:  It's actually insane behavior during the quiesce
phase.  Quiesce allows the program to run until a particular state,
which means we can't turn it off lest we interfere with intended
behavior - (cough cough prior review said this cough cough i'm dumb).

I'll drop patch 1/2 and resubmit (there's an unused variable warning i
need to clean up).

Thanks again for the reviews all
~Gregory