Message-ID: <4b13c48e-1677-3947-42e5-5ba241bcb96a@amd.com>
Date:   Thu, 26 Jan 2023 07:58:53 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] dma-buf: actually set signaling bit for private sub
 fences
Content-Language: en-US
To:     Danilo Krummrich <dakr@redhat.com>, Arvind.Yadav@amd.com,
        sumit.semwal@linaro.org, gustavo@padovan.org
Cc:     dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230126002844.339593-1-dakr@redhat.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20230126002844.339593-1-dakr@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDdtQmRBWEVhaHoxZCtWQXVSZGNOTHNZTE9QanpPVWc4YUhwbWRaWXlWMnBI?=
 =?utf-8?B?TGlJOXhpWit6WDQrTXJIN2hMS3p3Z0VKWjZIVVVBajhqRmc3NVByc1NGT085?=
 =?utf-8?B?Rkh3ZTRpQjN6RzZRazh0SVYxU25yeDZEK1h5cHluQmxYVWJjeThyYXBtclNL?=
 =?utf-8?B?dTRLTmV0ZDNlbnh5NVJVRStLNkk0ai9QdWFyalgvK2ZsVUpDeG5vcmlHTllp?=
 =?utf-8?B?dzdIc2pwSExRNU5vczA3R05pYTBZVWlhRW9vNzFVNzdkbXhVd0N1MFBZOG1j?=
 =?utf-8?B?RGJUZnRoNzdadko1elJmYlA2N3JSN2NxT3lXTHVDMjJiMHdIeVV1QWE0akNL?=
 =?utf-8?B?NFdoQUp4WTBXVlNQTGRuWVBtUmxobmk3THI1N2xyMzhtd2FWM2dJQWErRHEy?=
 =?utf-8?B?ZWJuejdGY3AwdHZtN3hKa2g2WE8xWTYvSm83WXhnTDI1UnNBY01XdnRCdlRV?=
 =?utf-8?B?cktFT0ppNWZQejRQcXNmbjBMRFNUdHl6eG1lWFpEK1JMcTVVRzAvblg2b3NU?=
 =?utf-8?B?L1FOSjRSNVp2Z3ArdDE4dEc3VVE0NUgvbGMyTURMSXdXaEpCOVd3bVVjcnBp?=
 =?utf-8?B?c1pzemZaS3dZMnJ4eW1EY0VlRkk4NGFDZVRPMHd6M1l2U3VwYkFrTjYvRmxN?=
 =?utf-8?B?Yi9kYU1POUVrYnM4RHhiY3lEek52THJ4TFF2K3VBSW9laktYZGsxQ2JXclNP?=
 =?utf-8?B?c05nalF3OXFIZlU5eGFZZTk5Z3VMNUR3NWZlaFVYdm5yb3ZFY0huY0R3WTZp?=
 =?utf-8?B?NXNoREw3enF6dTVxajdVb29qOWNacFRabTI4MktEZy9PRTlVMmNGNUh4QWhC?=
 =?utf-8?B?K1BmZmQ5NG1DMk1meEY1ekdBT2pqNm05MXJvaHIxemRaeXBpaGx4YlFFN0Nz?=
 =?utf-8?B?ckpNL2N6aWUxaGFHMjQwVUllZW5PWGJaMTBvLzc3OUVWZU5TWmxWZlczbUQ0?=
 =?utf-8?B?cE1vQjIzWnBvdlpKUHQ1Q0hSV3p1Nmw5N0RWK3daczRrMExxWjZLWnJhajRa?=
 =?utf-8?B?RTFZZ2hIUmhsVmZHb0luNVVyTE01Q2pnb09CWEdoVlphVFdlQlRXd1N1ZHV3?=
 =?utf-8?B?cXQ2a0F0dFVmWFF6d2RJS2RkNWdZbk1rSHluSXRYWVhRTTJlbVk0ZXBiNWFD?=
 =?utf-8?B?L25yRldCT0JwOGVNbXNGVkVqdjB2UE01cjJFakFXY2krOU1BbTh4UDMzK3A4?=
 =?utf-8?B?c3FtTmNkQjA5bXlFc2JnUGdIWGNEVlAzL1pxWFF4SHJ1dkRhRW9xSUIwNTBo?=
 =?utf-8?B?dEI5dkdJTFQ5aVprYkVSbDI3RzVMbGQzVzFFUVJZY3FCR1lIMzZrQ0N3RW8x?=
 =?utf-8?B?clZUMnRpSGpTZUlCcmFGYWxHeFJwUExIR3JzOTFmY0ZsYzA3aE44SDFpbzV6?=
 =?utf-8?B?MEFwMFpmaDlLNmNkWW1aTWpOM3kyempiN2EvZlg2enFEOEU3SjhNT2cvcmVs?=
 =?utf-8?B?WktMVzNNQkFFOVVFWFh1eXhUWFpNZm1kbmlPeUZtQUdqaUQyWllXNmZvSjNI?=
 =?utf-8?B?Ky9ZRk8vNG0ybTgwY1h6NXd0eDI4RmtWRXFzTVVxajVLaXVYbEk0WHRUaXJ4?=
 =?utf-8?B?akgwWGpNNENVa0V2cUgyaGpHWDJkdU5DMURFMU9DUDA2NW8rZnpKUFZiNlZE?=
 =?utf-8?B?Q1NjMzZIb2F3M3V2eWV4TmJwMi8yR2o4Y1VEZWFJMXJVbTJ0MTBoSi8xN3dQ?=
 =?utf-8?B?d2JwZllTcFlUaUxYbHV6U0F0MTVnK2U3bzRua3A4elBNcmI3VFdxZmd5Z1BO?=
 =?utf-8?B?cnhQcUJ2S2I0eDdWR2E5bStJZ282bVpWTXQvZ0NqamQ5WXgrclk2UlozaUNE?=
 =?utf-8?B?YlRnNHBiYWpXWFdBNVJGaVlnc0N5Ymd2WFJrNXJpaEVkV2VsZkY3NGY3ZlpN?=
 =?utf-8?B?Q1VwTWFlQ0dLOFhoT3l5VHY4dlUzY3lVbWZhcWZaYVA1Z0tBdkZxVjByekR3?=
 =?utf-8?B?alZmSTJUbWR4bDRjb1BFTWNFUHlsY0hFejc5N09pTTZqY0JJTjFuUndJeEZv?=
 =?utf-8?B?eHZ6NGtSdDNVZ2pIZ1ZFY2YyMkpDaE1uL08weUJxY1YyZm1xMlROSlVEQU83?=
 =?utf-8?B?cHlHc2tTQzFhMXZhZndOYmFObjRPVGU0YWRaa3lxTVVGbWQ0eGs5WVQrdVcx?=
 =?utf-8?Q?/s+KEhE9gxcZeOEfh1Yz1BbvD?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33da7f99-88eb-4a1b-04a3-08daff6acd20
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 06:59:00.3296
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L9RByopz1bg9iiL3LOgOEVg+qvJ9PrzUWhNHMNw+VDNLFf0IEDp8MSSFcwYmI1oC
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8250
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 26.01.23 um 01:28 schrieb Danilo Krummrich:
> In dma_fence_allocate_private_stub() set the signaling bit of the newly
> allocated private stub fence rather than the signaling bit of the
> shared dma_fence_stub.
>
> Fixes: c85d00d4fd8b ("dma-buf: set signaling bit for the stub fence")
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>

Good catch, Reviewed-by: Christian König <christian.koenig@amd.com>

Should I push it upstream as well or do you have commit access?

> ---
>   drivers/dma-buf/dma-fence.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 406b4e26f538..0de0482cd36e 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -167,7 +167,7 @@ struct dma_fence *dma_fence_allocate_private_stub(void)
>   		       0, 0);
>   
>   	set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
> -		&dma_fence_stub.flags);
> +		&fence->flags);
>   
>   	dma_fence_signal(fence);
>