MIME-Version: 1.0
References: <1673847684-31893-1-git-send-email-hongxing.zhu@nxp.com>
 <1673847684-31893-5-git-send-email-hongxing.zhu@nxp.com> <20230126064728.GQ20713@T480>
In-Reply-To: <20230126064728.GQ20713@T480>
From:   Shawn Guo <shawnguo@kernel.org>
Date:   Thu, 26 Jan 2023 16:37:21 +0800
Message-ID: <CAJBJ56+7x9-zMRHQZjzQ9JG-VuR-bLrW9YzM0hX0sGkyQsPk0A@mail.gmail.com>
Subject: Re: [PATCH v5 04/14] arm64: dts: Add i.MX8MM PCIe EP support
To:     Richard Zhu <hongxing.zhu@nxp.com>
Cc:     l.stach@pengutronix.de, bhelgaas@google.com, robh+dt@kernel.org,
        lorenzo.pieralisi@arm.com, kishon@ti.com, kw@linux.com,
        frank.li@nxp.com, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel@pengutronix.de,
        linux-imx@nxp.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 26, 2023 at 2:47 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Mon, Jan 16, 2023 at 01:41:14PM +0800, Richard Zhu wrote:
> > Add i.MX8MM PCIe EP support.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mm.dtsi | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index 4ee89fdcf59b..8124761f629c 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -1293,6 +1293,26 @@ pcie0: pcie@33800000 {
> >                       status = "disabled";
> >               };
> >
> > +             pcie0_ep: pcie_ep@33800000 {
>
> Hyphen is more preferable than underscore in name node.
>
> I fixed it (and the other two patches) up, and applied all DTS patches.

Dropped them, as I just noticed there is v6 of DTS patches being discussed.

Shawn