Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70AEC54E94 for ; Thu, 26 Jan 2023 12:19:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236929AbjAZMTx (ORCPT ); Thu, 26 Jan 2023 07:19:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237223AbjAZMTq (ORCPT ); Thu, 26 Jan 2023 07:19:46 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8942A16AD7 for ; Thu, 26 Jan 2023 04:18:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674735526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I9Pg4QUbNxEbqQg5rlyFX3DNaClmlULemPiPESaUQkE=; b=GNeS5sbPyHCBktL6Bz9x2qI6aJysIMXM3wCbRzTmNyD8X+20ljEI4kQsoGPK9SO/iyjaJ0 OzCMpDLD9XYmQGlWZnBAm3KBjiTwxNa3H/N7KZ1EIjVzZJwy7gH/tMdNNq8ipTEaNJP+uF uuRdFTLu2FAUQ8qLA/5bO4JosZiHNJE= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-286-qX3TVsWiO3mGfoIVkSbvyw-1; Thu, 26 Jan 2023 07:18:45 -0500 X-MC-Unique: qX3TVsWiO3mGfoIVkSbvyw-1 Received: by mail-qv1-f70.google.com with SMTP id f16-20020ad442d0000000b005376362aa66so977124qvr.1 for ; Thu, 26 Jan 2023 04:18:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I9Pg4QUbNxEbqQg5rlyFX3DNaClmlULemPiPESaUQkE=; b=uihJ4fsLx5eJkakOP/ChvIxSMuqBNCx2RbuPaRyxDLHU2eiV3bGKJmKNuV73SnXFk7 nUIldd/hZdyouYmxWzFgZn9WA6RTfG74ZdPbiX7zol3XXZJu0e8DinI6Ji19RqKUaivd DPkdaDNIaZKLwwRmLUhAC6guGywG1Kd5MqgnRow8uFcOf/XQjZs/7RsOSTwnwX2hHWsP f0l1o3jjeuycEGb0xFPLnWJeAteRHd81CO38OI0QFJDiMqUKECP0ii0jNqbSFVOV+365 qCbJZ1cflfSSeoPXm5VTlH2P5htNVdXaJbXKVcQJJPX2p9WcqU52hcSPckrUx0mmaAiv Jw1A== X-Gm-Message-State: AO0yUKX72O+JgQPgCpQJE9Lgfk+wNYcMpfVypTgoyAZgfyoi7wbc3mBR Z4gZI0tN1pN4NguRBzp3diLiVyVz1vO8RGsMZUYnvHTsFiy75Z2E0ZmQkVYTd18htzYUw5FRcs+ Plxo2mYzui6JH4wM71Oo72peO X-Received: by 2002:a05:622a:1b9f:b0:3b7:fb43:e745 with SMTP id bp31-20020a05622a1b9f00b003b7fb43e745mr12125497qtb.39.1674735524639; Thu, 26 Jan 2023 04:18:44 -0800 (PST) X-Google-Smtp-Source: AK7set/LpzPPRNyX46aBCgsS1xFZrPlr8YJl6tz+anqlXRntKC1x8THXiiUIltDWpqrLib/RmsI1nQ== X-Received: by 2002:a05:622a:1b9f:b0:3b7:fb43:e745 with SMTP id bp31-20020a05622a1b9f00b003b7fb43e745mr12125469qtb.39.1674735524334; Thu, 26 Jan 2023 04:18:44 -0800 (PST) Received: from [192.168.0.2] (ip-109-43-177-174.web.vodafone.de. [109.43.177.174]) by smtp.gmail.com with ESMTPSA id b17-20020ac84f11000000b0039a610a04b1sm632086qte.37.2023.01.26.04.18.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 04:18:43 -0800 (PST) Message-ID: <6594a21f-6372-0b69-3bb3-6ed1b1387e6e@redhat.com> Date: Thu, 26 Jan 2023 13:18:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v6 10/14] KVM: s390: Refactor absolute vm mem_op function Content-Language: en-US To: Janis Schoetterl-Glausch , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Heiko Carstens , Vasily Gorbik , Alexander Gordeev Cc: David Hildenbrand , Jonathan Corbet , kvm@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-s390@vger.kernel.org, Paolo Bonzini , Shuah Khan , Sven Schnelle References: <20230125212608.1860251-1-scgl@linux.ibm.com> <20230125212608.1860251-11-scgl@linux.ibm.com> From: Thomas Huth In-Reply-To: <20230125212608.1860251-11-scgl@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/2023 22.26, Janis Schoetterl-Glausch wrote: > Remove code duplication with regards to the CHECK_ONLY flag. > Decrease the number of indents. > No functional change indented. > > Suggested-by: Janosch Frank > Signed-off-by: Janis Schoetterl-Glausch > --- > > > Cosmetic only, can be dropped. I'm torn between unnecessary-code-churn and nice-to-get-rid-of-one-indentation-level here ... anyway, patch looks sane to me, so: Reviewed-by: Thomas Huth