Message-ID: <07ba0fcf-8842-27d8-9dac-862981734c3a@redhat.com>
Date:   Thu, 26 Jan 2023 08:17:21 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v7 0/4] lockinig/rwsem: Fix rwsem bugs & enable true lock
 handoff
Content-Language: en-US
To:     Ingo Molnar <mingo@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
        Boqun Feng <boqun.feng@gmail.com>,
        linux-kernel@vger.kernel.org, john.p.donnelly@oracle.com,
        Hillf Danton <hdanton@sina.com>,
        Mukesh Ojha <quic_mojha@quicinc.com>,
        =?UTF-8?B?VGluZzExIFdhbmcg546L5am3?= <wangting11@xiaomi.com>
References: <20230126003628.365092-1-longman@redhat.com>
 <Y9J2HkiyLDmGPWyn@gmail.com>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <Y9J2HkiyLDmGPWyn@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/26/23 07:46, Ingo Molnar wrote:
> * Waiman Long <longman@redhat.com> wrote:
>
>> v7:
>>   - Add a comment to down_read_non_owner() in patch 2.
>>   - Drop v6 patches 4 & 6 and simplify the direct rwsem lock handoff
>>     patch as suggested by PeterZ.
>>
>> v6:
>>   - Fix an error in patch 2 reported by kernel test robot.
>>
>> v5:
>>   - Drop patch 2 and replace it with 2 new patches disabling preemption on
>>     all reader functions and writer functions respectively. The other
>>     patches are adjusted accordingly.
>>
>> It turns out the current waiter optimistic spinning code does not work
>> that well if we have RT tasks in the mix. This patch series include two
>> different fixes to resolve those issues. The last 3 patches modify the
>> handoff code to implement true lock handoff similar to that of mutex.
>>
>> Waiman Long (4):
>>    locking/rwsem: Prevent non-first waiter from spinning in down_write()
>>      slowpath
>>    locking/rwsem: Disable preemption at all down_read*() and up_read()
>>      code paths
>>    locking/rwsem: Disable preemption at all down_write*() and up_write()
>>      code paths
>>    locking/rwsem: Enable direct rwsem lock handoff
>>
>>   kernel/locking/rwsem.c | 161 +++++++++++++++++++++++++++++------------
>>   1 file changed, 115 insertions(+), 46 deletions(-)
> So as a first step I've applied the first 3 patches to the locking tree,
> which are arguably fixes.

Thanks for merging into tip.

Cheers,
Longman