From:   Adrian Ratiu <adrian.ratiu@collabora.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
Cc:     u.kleine-koenig@pengutronix.de, matthias.bgg@gmail.com,
        weiqing.kong@mediatek.com, jitao.shi@mediatek.com,
        linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        kernel@collabora.com, thierry.reding@gmail.com
Subject: Re: [PATCH 0/2] pwm: mtk-disp: Fix backlight configuration at boot
In-Reply-To: <20230123160615.375969-1-angelogioacchino.delregno@collabora.com>
References: <20230123160615.375969-1-angelogioacchino.delregno@collabora.com>
Date:   Thu, 26 Jan 2023 17:31:02 +0200
Message-ID: <87h6wdxqh5.fsf@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Precedence: bulk

On Mon, 23 Jan 2023, AngeloGioacchino Del Regno 
<angelogioacchino.delregno@collabora.com> wrote:
> Since the pwm-mtk-disp driver was fixed to get PWM_EN state from 
> the right register, an old two-wrongs-make-one-right issue 
> emerged: as a result, MT8192 Asurada Spherion got no backlight 
> at boot unless a suspend/resume cycle was performed.  Also, the 
> backlight would sometimes not get updated with the requested 
> value, requiring the user to change it back and forth until it 
> worked. 
> 
> This series fixes both of the aforementioned issues found on 
> MT8192. 

Thanks for the series. This also improves backlight on MT8183.

I've been testing using the panfrost driver on a ChromiumOS 
userspace on a jacuzzi board and I've had issues like the screen 
going blank then not coming back, which these patches appear to 
solve. Many thanks!

Tested-by: Adrian Ratiu <adrian.ratiu@collabora.com>

>
> AngeloGioacchino Del Regno (2):
>   pwm: mtk-disp: Disable shadow registers before setting backlight
>     values
>   pwm: mtk-disp: Configure double buffering before reading in
>     .get_state()
>
>  drivers/pwm/pwm-mtk-disp.c | 34 +++++++++++++++++++++++-----------
>  1 file changed, 23 insertions(+), 11 deletions(-)
>
> -- 
> 2.39.0