Date:   Thu, 26 Jan 2023 18:40:46 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Arnd Bergmann <arnd@arndb.de>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: mscc: ocelot: add ETHTOOL_NETLINK dependency
Message-ID: <20230126164046.4sk5qaqiwgygt2cg@skbuf>
References: <20230126163647.3554883-1-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230126163647.3554883-1-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PWVT4VGGbNY9NG9rM8GLqqVHp79ZURd2KPOq1mSef6kziI/aO+h6Qcw1SSph?=
 =?us-ascii?Q?skjentAFQOaTxkQbaV/niaOUVWMPd8YlbafCBXAsOxJJ1zWioBhhZBRpNWWI?=
 =?us-ascii?Q?n3gWgrXTb8fss5cdyyQLZ8nUfuosUU6OAkHUlrOr8iPnIgDwt8OpUEI1a62s?=
 =?us-ascii?Q?c3PP84lUV6BPTThtxuWzF4A2rT7JyM13uCTFfrCE9zWNCl4knbuVBmhDL+gY?=
 =?us-ascii?Q?1kZmbFjQqgtTY3l65RM4Pa8y07Pc+xmlsdu/k3HhX7SrIvcxSe/dt7J6RHb3?=
 =?us-ascii?Q?skwsBEdfDTqzzn0dzXVVdVHsxG1zC5SOU2DRnn+iA7pJB50iBK63ZSs/T4kd?=
 =?us-ascii?Q?zW8jOAcqIJqjvPcCmAjZpqGe56FNGW5N2lTFYAAws+ctlgF2ebk6QZMOrj57?=
 =?us-ascii?Q?YuRCpdLg62orP3m44NwD9TSYRnWFEz9SlUpwvNtzecsGRi/2pxA+yyDlKM4H?=
 =?us-ascii?Q?+15utbWXdcuyzuRqGM+bcwOkRkzZFRdgKFh5/Jc5b3PwTuKwvYReg6JkDExn?=
 =?us-ascii?Q?BKhL6uCLrprP/heQLIM8gO6yCBeNL9L6Sw8tCTT6arz9N3IkrRKaaRFvf1ia?=
 =?us-ascii?Q?nyJnAdTAHpRWfYXqY9ioN5QG7uZdvGAAYVcRgp98lsJ7Rl9GpFYkD+2Tki4V?=
 =?us-ascii?Q?HOcYvpjNL2OvUN+M1wIqgcRNvx0quHLEz5izVgTR7BnRRbj1nMZTewfoiAHL?=
 =?us-ascii?Q?hGn2VO6unGUEI8qKOgV5EeP6UImvo+BVERQNn0H01/Q+pm9ZX0b6kyRy9wl1?=
 =?us-ascii?Q?kMiYOHPK7oZ/24Ywtn9VAZRRkID2KdtFs3O0uCB/iCKteBCx3I4WYFt1kFZv?=
 =?us-ascii?Q?yWWhuUex0GugbVdNQCnp7DQOD/n/BUX0yho49+25kDY2otIxHUzBIRK//3aj?=
 =?us-ascii?Q?lK1MeW/5UNG6hSV4/TTuAUz2rjDwLLfYhMRcrBsOD4nDwMPe28cA6hskIGbR?=
 =?us-ascii?Q?tWM1HhgS0lX2yt+0i8CPUkOkz1hA9Mm/doZe6d3OI3TmHY5w/gF7OWYnonsf?=
 =?us-ascii?Q?EmVHSykq/xBqa1esd1nfHn/PJubaRrnlf5VkMSQLbhbgUKEHw53VWdOxM8PK?=
 =?us-ascii?Q?UQkseeApDJHmSkfXVUgSjjOM0cWBau9Ja8DCLwYfrjeYl3HkeBuufBFG0kJW?=
 =?us-ascii?Q?zWrLbhQNP6PTIW4NzhJLoJkHdTP9iKLdZr84N/ib9JjsbVQC5adRKXbZBd5H?=
 =?us-ascii?Q?tIhKjIx1soPSYNXLNM9nsBpg0O/AtkMrsSTq9gQuwnHswQuAEGNNMmCItkp8?=
 =?us-ascii?Q?FS/rZsE+O55P+BvBCo1S2YmK6SnUzRrQYQMO1VE9bKnV+fl43e3uwkqP8iEw?=
 =?us-ascii?Q?Pv1JYiIaz8iBhePvaDmjXuyAqtmuFnPmLUl8fE2As2kwui3ZSXuYE/sPllpa?=
 =?us-ascii?Q?3S1DByfCoOOUfY+eo4oq+pleK+td3bG8WWIlgyle/BkgIP8K+vKcIFx5hYSY?=
 =?us-ascii?Q?dpcgLxgp65EzEQR8wtDrjQNiCjfCMuRc4+wAoMxcS0hFsljrtvtlvPQUDFJ2?=
 =?us-ascii?Q?5+BEvlznSrhc9rM+ykDnozHnmkFLythEiD/rZjKoxtRwni9gYOnKtXw43DCl?=
 =?us-ascii?Q?BlwCLNC6Hh26jqM8AlzkRWxp+QvEcqgIZNS1X8MPwz1CqiMFmuwtqveZISBm?=
 =?us-ascii?Q?3Q=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5dc034e3-2405-4d80-f4ff-08daffbc15b6
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 16:40:51.4592
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YBFViJGJ/8gZJ9nBoSe/hlBljuCtG1fAdlWn4l322hK9W8zELUVz0TNAjW6SZEx1laBJsSekbAq0qK4KR6O4nA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9240
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

On Thu, Jan 26, 2023 at 05:36:36PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver now directly calls into ethtool code, which fails if
> ethtool is disabled:
> 
> arm-linux-gnueabi-ld: drivers/net/ethernet/mscc/ocelot_stats.o: in function `ocelot_port_get_pause_stats':
> ocelot_stats.c:(.text+0xe54): undefined reference to `ethtool_aggregate_pause_stats'
> arm-linux-gnueabi-ld: drivers/net/ethernet/mscc/ocelot_stats.o: in function `ocelot_port_get_rmon_stats':
> ocelot_stats.c:(.text+0x1090): undefined reference to `ethtool_aggregate_rmon_stats'
> arm-linux-gnueabi-ld: drivers/net/ethernet/mscc/ocelot_stats.o: in function `ocelot_port_get_eth_ctrl_stats':
> ocelot_stats.c:(.text+0x1228): undefined reference to `ethtool_aggregate_ctrl_stats'
> arm-linux-gnueabi-ld: drivers/net/ethernet/mscc/ocelot_stats.o: in function `ocelot_port_get_eth_mac_stats':
> ocelot_stats.c:(.text+0x13a8): undefined reference to `ethtool_aggregate_mac_stats'
> arm-linux-gnueabi-ld: drivers/net/ethernet/mscc/ocelot_stats.o: in function `ocelot_port_get_eth_phy_stats':
> ocelot_stats.c:(.text+0x1540): undefined reference to `ethtool_aggregate_phy_stats'
> 
> Add a dependency on ETHTOOL_NETLINK, since that controls the
> compilation of the ethtool stats code. It would probably be possible
> to have a more fine-grained symbol there, but in practice this is
> already required.
> 
> Fixes: 6505b6805655 ("net: mscc: ocelot: add MAC Merge layer support for VSC9959")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---

Thanks for the patch and sorry for the breakage. This is now fixed by commit:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=9179f5fe4173