Date:   Thu, 26 Jan 2023 17:41:19 +0000
From:   Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To:     Markuss Broks <markuss.broks@gmail.com>
CC:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        <linux-kernel@vger.kernel.org>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Zhigang Shi <Zhigang.Shi@liteon.com>,
        Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Paul Gazzillo <paul@pgazz.com>,
        Shreeya Patel <shreeya.patel@collabora.com>,
        <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] iio: light: Add support for AMS TCS3490 light
 sensor
Message-ID: <20230126174119.000056da@Huawei.com>
In-Reply-To: <a782a0d9-c47e-4328-774f-6bef78161d81@gmail.com>
References: <20230123231028.26073-1-markuss.broks@gmail.com>
        <20230123231028.26073-3-markuss.broks@gmail.com>
        <Y8+xamtH/U4vK75e@smile.fi.intel.com>
        <a782a0d9-c47e-4328-774f-6bef78161d81@gmail.com>
Organization: Huawei Technologies Research and Development (UK) Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 26 Jan 2023 17:54:56 +0200
Markuss Broks <markuss.broks@gmail.com> wrote:

> Hi Andy,
> 
> On 1/24/23 12:22, Andy Shevchenko wrote:
> > On Tue, Jan 24, 2023 at 01:10:25AM +0200, Markuss Broks wrote:  
> >> Add a driver for AMS TCS3490 Color Light-to-Digital Converter. This
> >> device provides color and IR (red, green, blue, clear and IR) light
> >> sensing. The color sensing can be used for light source detection and
> >> color temperature measurements.  
> > ...
> >  
> >> +AMS TCS3490 DRIVER
> >> +M:	Markuss Broks <markuss.broks@gmail.com>
> >> +L:	linux-iio@vger.kernel.org
> >> +S:	Maintained
> >> +F:	Documentation/devicetree/bindings/iio/light/ams,tcs3490.yaml  
> > Shouldn't actually be added with the schema patch?
> >  
> >> +F:	drivers/iio/light/tcs3490.c  
> > I dunno what's the rules but it feels a bit inconsistent in case the schema
> > will leave while driver got, for example, rewritten (as brand new) and reverted
> > (as old one). In such (quite unlikely) circumstances we may end up with the
> > dangling file.
> >
> > Rob, Krzysztof, Jonathan, what is yours take from this?

Ideal is update the file listing as files are added, but I rarely care
enough to fix it up or complain as the patches almost always go
together.