Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-85-gd6d859e0cf-fm-20230116.001-gd6d859e0
Mime-Version: 1.0
Message-Id: <5313ee39-7313-493b-9b66-a9c697962831@app.fastmail.com>
In-Reply-To: <Y9LDIvWiG9gSl9f2@unreal>
References: <20230126135454.3556647-1-arnd@kernel.org>
 <Y9LDIvWiG9gSl9f2@unreal>
Date:   Thu, 26 Jan 2023 19:41:19 +0100
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Leon Romanovsky" <leon@kernel.org>,
        "Arnd Bergmann" <arnd@kernel.org>
Cc:     "David S . Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        "Jakub Kicinski" <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "Rob Herring" <robh+dt@kernel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
        Netdev <netdev@vger.kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wiznet: convert to GPIO descriptors
Content-Type: text/plain
Precedence: bulk

On Thu, Jan 26, 2023, at 19:14, Leon Romanovsky wrote:
> On Thu, Jan 26, 2023 at 02:54:12PM +0100, Arnd Bergmann wrote:
>>  
>> @@ -139,6 +139,12 @@ MODULE_LICENSE("GPL");
>>  #define W5500_RX_MEM_START	0x30000
>>  #define W5500_RX_MEM_SIZE	0x04000
>>  
>> +#ifndef CONFIG_WIZNET_BUS_SHIFT
>> +#define CONFIG_WIZNET_BUS_SHIFT 0
>> +#endif
>
> I don't see any define of CONFIG_WIZNET_BUS_SHIFT in the code, so it looks
> like it always zero and can be removed.

Good catch! Evidently the original idea was that this would
be set to a machine specific value through Kconfig. I've renamed
the constant, removed the #ifdef and explained it in the changelog
text now.

     Arnd