Message-ID: <a23c80c4-933c-9be0-6d36-4d4238b13f23@intel.com>
Date:   Thu, 26 Jan 2023 11:55:18 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 5.10 1/1] i40e: Add checking for null for
 nlmsg_find_attr()
Content-Language: en-US
To:     Natalia Petrova <n.petrova@fintech.ru>, <stable@vger.kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC:     Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>
References: <20230126135555.11407-1-n.petrova@fintech.ru>
 <20230126135555.11407-2-n.petrova@fintech.ru>
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
In-Reply-To: <20230126135555.11407-2-n.petrova@fintech.ru>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cE1sTWJtWE5Jd3ZtbDcxbDBORUJ6VnpQck1OcmY1enNYeDJJMml3c01HZUcz?=
 =?utf-8?B?dXJodHZablI4SkptY3RKZEVtc1dLM2RCb1c0UUR5TmdkbGUyUDVqbWRJd0R0?=
 =?utf-8?B?Y0JIaUE0dldRMjZWVktuQTYreUVzb1pleE8ySXBZTEhVZXIxL3RORXNzRzJ2?=
 =?utf-8?B?TktKTFhwbCs3RDdGcTNUemV4bkpJNCswY0hQM3FXZy80d0xLUm9FSC9RTkpv?=
 =?utf-8?B?V293UkF5bkttaWU3TjlpbGhDSGZkRjhydTlqNHZ3NXc5SU83VkVUMzFuQ0lY?=
 =?utf-8?B?Ly9RQWFkdW50MzlrT29IMER1M09XUndPcWJGcnp0a0cyNUhONDF1dTdUcGts?=
 =?utf-8?B?bGs5bWNaRW9MbHFMRjU4VXhwVnhWY0E4Q2lsbDd2UzdLdUt3M2VCcHlubmVt?=
 =?utf-8?B?ZVh3bm1GVE5pRm5mVjBUUlBjU21EZEpMSENpYWprTm5sdHZPWG5TWlRrM2wr?=
 =?utf-8?B?TnV2ZlNkMUllVVRLSmZhZUc3VXFRelVpZ3FLdmlzMkdzZk1RbzIrSkhiQVVh?=
 =?utf-8?B?MnJJVlBVc3l6a0FSY2lLOVJhbU1BWDRYT2ZlYVVSbGdpL1A3UGU4SThXNjEy?=
 =?utf-8?B?YlE3WjZOMUozS3lkbmsrNW1Hd09WblZMbzhkaTdZNDZDUGRvendnQXl6NTRq?=
 =?utf-8?B?SWxWMWpnYzF2Z2hGS0xZK2VrQ1EwQ3NDeFo2dk9rREtJZTJ0RXN2Qnh3bXVp?=
 =?utf-8?B?enR1ZEtBSkwvUVpJRXhGSzR1cGVPZUlVVkdkSUl6QlE3M0ZjaU1sNjhOR29Q?=
 =?utf-8?B?UnZWQlB0a3Y2VDIzVCtpOGhmUEdZVGZKb2U4YXRqQ3N4OXBUVEVDOHdYYVlC?=
 =?utf-8?B?MzY2Rkk5aWpCbCtTNDBtSFZpMkV6cThQSGdrNU81NVAzZUhCSmNaZnJJVncr?=
 =?utf-8?B?TUpBaERCMmd5MWRvWFpBcVZYbTZ5Zi92OUVrWFYyNTRaQ2lRWnZZY2RuTDZG?=
 =?utf-8?B?aXBBUDdKWWtFTGkybjM2VGVYdjJodnE3cStwSVZRSUowU3h4UG9saG92dzZQ?=
 =?utf-8?B?L2NpdmV1VjIxV1FvVkZXYjdnZGw1dENaUmUyeXhyN2hvTWMyNlBEbHlHUkR0?=
 =?utf-8?B?cjREd09ndTl4dDZCbGJCWUloT1pjMU9mdWtZVmFlakxCNlR3RElWRmZXUnpv?=
 =?utf-8?B?eVdvQVdJZlgwY1lmOHkrMjZJT1RCczNiUEtEdDVxZzgwb2JsUEs3R1l4N3R4?=
 =?utf-8?B?VDFIaVB5SlBaMklEa0Q5dVlpRXFxUUprMkFkYnc1TGpvb3lFRlpDY3U0REtj?=
 =?utf-8?B?Wjh6RFloL21naEg0S1hvdmpjaUxVZGtHQjllWG9oRzV0K1pnd29LcGZiTXZM?=
 =?utf-8?B?b0UyODI5TCtZdW1pUmkrVlhTZjZ2WWttWHB5ZGxFcTJyNnZOMVpiOWJrSmpK?=
 =?utf-8?B?akpNL2tMa2gzbytSTnEveDBUblFqVnN6R1lkc2tYQTVFMzlBWVViSzJkYmUr?=
 =?utf-8?B?eG5CdlRyZWN2Vjc2VkdNQXd6TDFyMUJXVHB5bUE3S29HZGJsRng1L0swWGtJ?=
 =?utf-8?B?bTErdk00ZjRMemlSZVZBMlVtU0FvNzc1SXlMSmk5bmpVU2lndDJUVnNEaHBy?=
 =?utf-8?B?NHd3YUZpNzVaR1YvbGlzeXp5MzZEVm1GZkhhdXZKNWx6Uk5laGhleDNteFZZ?=
 =?utf-8?B?VmtCZjJFU3hOdWtOV3FJSjV1d25hOW9SakcyM3R4ZnlIS0FmN0xRYld2NHJV?=
 =?utf-8?B?ZlFsY2NEZWwwYlBSQ3g1eEJ4U0I1TzdmTzhQb2lXSmhXbFpMV3ptVTNIR01J?=
 =?utf-8?B?VjlMaklGcXc4ais3QUJuZTdycVNmeG5wVzNmMnBUaWYzcDFHQXRHUXhvWEpX?=
 =?utf-8?B?WU9VQzVPc2FPcW0yODFTQmdFNlpEWkNFeE9vZnBnN0VvVy9nYkJZY3VWZ1RE?=
 =?utf-8?B?ZytoRnd3b3ZVY0Zram5MVk10dklLTXMxQWVUZHdMOFpJVzZJN2xFQWMxUThE?=
 =?utf-8?B?bkJ4eW5xZ0NWQjFhN3Q5QWxmeW01V0pWTmVUOStPUGRPd0xFSHFBeFRGaWt2?=
 =?utf-8?B?SXVBZGhrUmJtcURBUUh2bmdjNjhOMmliK0VaRHB1WTVnT1llclMwQmhFbFVz?=
 =?utf-8?B?enduWldqWUJEc3J2ZmYwaCtkUFo2OTNLcDRBL2tMNmF3aWNRbVZxSmtQMTFG?=
 =?utf-8?B?STA5Mi9XZHpGbERiNzFCQ2xuRkpNMkljaFZWcDcrcUVxVVZ1bzNvWUQrck03?=
 =?utf-8?B?NGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0aa88719-7838-4540-2d94-08daffd74151
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 19:55:20.6643
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cIaMkxswm/CLYj/YGH+cqSsWJdhvQQ/hDJY/LXuYbhOUWNhJAlpMTY97nQqmWswn5SCPWphJfaG2v6ItMOltd8bDTwgxedxK9qOot2RWTzk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8210
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/26/2023 5:55 AM, Natalia Petrova wrote:
> The result of nlmsg_find_attr() 'br_spec' is dereferenced in
> nla_for_each_nested(), but it can take null value in nla_find() function,
> which will result in an error.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 51616018dd1b ("i40e: Add support for getlink, setlink ndo ops")
> Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
> ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
> index 53d0083e35da..4626d2a1af91 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> @@ -13167,6 +13167,8 @@ static int i40e_ndo_bridge_setlink(struct net_device *dev,
>   	}
>   
>   	br_spec = nlmsg_find_attr(nlh, sizeof(struct ifinfomsg), IFLA_AF_SPEC);
> +	if (!br_spec)
> +		return -EINVAL;
>   
>   	nla_for_each_nested(attr, br_spec, rem) {
>   		__u16 mode;

Makes sense to me. Thanks.

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>