Message-ID: <287458c5-3e56-8a0b-f993-92e2b6ba9adb@intel.com>
Date:   Thu, 26 Jan 2023 11:59:37 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 5.10 1/1] i40e: Add checking for null for
 nlmsg_find_attr()
Content-Language: en-US
From:   Jesse Brandeburg <jesse.brandeburg@intel.com>
To:     Natalia Petrova <n.petrova@fintech.ru>, <stable@vger.kernel.org>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
CC:     Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>
References: <20230126135555.11407-1-n.petrova@fintech.ru>
 <20230126135555.11407-2-n.petrova@fintech.ru>
 <a23c80c4-933c-9be0-6d36-4d4238b13f23@intel.com>
In-Reply-To: <a23c80c4-933c-9be0-6d36-4d4238b13f23@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXpBRS8zV1Zod3VRemZ0QVRuQzI0NDZCb2tIK2xiY1pxbWJ0YkFvRHYzdlhZ?=
 =?utf-8?B?K09GclIwNkQzcjFtMUZrN3g0a29Ld29MUysvclVTWjFYdUI0U0xyODExSXF5?=
 =?utf-8?B?NGwraHlIVWFUNFl2RGM3M2xkUkFpNVNJRTA5OU9vcG5tVEVJQjJ2Nldna1Na?=
 =?utf-8?B?U3BXT2lzNmx1d3ByZGFHenRuZzFwL3EvSW8rdVB6MEJXMkZ2NmEvd2hvS3kw?=
 =?utf-8?B?SUpWR0Raa2wzOG9uRVVnTUlEMFJMTUtjUk5lY1llUzZyRElvbFcyQjBPeDRt?=
 =?utf-8?B?Z3hIZmJqTEJLNWhvSERFdUFUWjZmUWFrbGhJdEk5K29heGEwQldkeC92UTVN?=
 =?utf-8?B?dVQ0VnI0alhOZVhhbkZvcTR5WHRYMnF3MkgyQkxMUWdwNnp5U29oTXVrVGZT?=
 =?utf-8?B?SHVxYVZzbTZsSlFFMEsxcm9IbzcyRC9rdEpRN0lwb0xycnJrMnVldTQ5UGFV?=
 =?utf-8?B?NlY1RE9YbnQ2ZWx4U1FCM0VRY0hlUjNPU0FYK1VUckdXTXZIZnlDMDF3a3Bh?=
 =?utf-8?B?T1A1bFgybG5LUFlrdjhWWm82Rmt3cm5GcG1KcTNmaENzWEp2ZlQxSjJDbFlw?=
 =?utf-8?B?Tm9CaDF3MW9xYWlIZWdtY2l0VHRJNG1ONUUxSkFxa1lOOER0NmFTUzZ4aHh3?=
 =?utf-8?B?NkVlMmRjZHMra2hxTUF1cVdxSGNxS2FwWDd1MDEyVytqRlhqQkNJdEViTFZv?=
 =?utf-8?B?cnMwZzQzK3pEMDdXeStOTml0Mzl0RUlyNDBYMmt0WnAwbVhJZ1oySlRWdGpO?=
 =?utf-8?B?aVpwVHJxOGt0dlcrWHovSGU0eUs3dld5RVpBaWdKbVdKSnBycnVSWTEyMTdP?=
 =?utf-8?B?akl6MDJwNnBNMGJ1djYxdk9xb3dHU0R2THFWRXB1SWFDaFhCSHZOQVB4eEZh?=
 =?utf-8?B?L3BkYVBHM2JjWW4zcGJMTnRMRlF2RGpQT1FVL1ZWNys2S0s3MVdRUjROamhr?=
 =?utf-8?B?Mk9IcmliQVB6UEFKWXp0U1dnTlVvSGxXb3VaUlFtckhrdmhlS0FReTFRMFNN?=
 =?utf-8?B?QXovZFRzMEhRa01CNDhtbWZxSFpEeXQxbi9oZWd6bTRSYXNWNEVYSkpZNThs?=
 =?utf-8?B?YUREVzJ5Nm10MnlZVGpCb0xGNnpIQndEVmFBakJsTUVFdWlQM2RDZnc4eUVi?=
 =?utf-8?B?aG82ZVozdUxLZHU3ZFhNR2lVdnBuQXJGTU9vdUh4UFZkaHRlS2VselpoeGdt?=
 =?utf-8?B?TnVOQVFQdzFHQzFZdFlqN3FzcUY5RkN3MGgvVXR4SGNBZUw2ekVwMHdwSTVO?=
 =?utf-8?B?VWs4WlowZm5uUDF6NGg4OVJLaDhHVFJkQ2tTR0FRWmoxSnAzbjVxcThOVlBk?=
 =?utf-8?B?UmlVSnBqc1pEY01kNkpzTnIrb29YL0lQR1p1cis4Q1c0ajNpZ21nTStDK0tv?=
 =?utf-8?B?dS8yTEUyOHVZVEZJMDZGK0tncFZOMkltRlc0RDQ3dk9TZVVnQWtFQWR6TFJh?=
 =?utf-8?B?SElQeGszOWl4SXdzTkluYnZSbng5M0szRVZtbGxKV2dUS3k4Z0d3TzBlT3Q4?=
 =?utf-8?B?eWhDTTU0eVZjSDh2NWxxNTV0YTRRU0QwWTBrNHd4VkdQQ2lWcTNLYWdWenpM?=
 =?utf-8?B?MEN3VnNVVkRKOUhWZFpTZ1g3cVFVRE0xOXFtZzNsWW0yMWtNTEQySGJIT1gr?=
 =?utf-8?B?YXVvc254MzdoY2htazI3RnM4Y0xFdVBzelNydkJWVGFlaHE5MkhqajFodjk2?=
 =?utf-8?B?MGoxMkNQRVZJZlloRWxiTzd4V0d6bTl2L0dPeUhKMHIzQU1tdmxTS2UvdFNL?=
 =?utf-8?B?SFFhRk5xeGtjSHZPd0VaY3BlS3p5S0xDemdadS9OQUpyS25lcmRCWnJUd0Y3?=
 =?utf-8?B?WW5OYXUwdTdteFFGWXM2YTJ3bTNGZnRRT2RLbE5iS09uWFhoV1psSDRRM2Jn?=
 =?utf-8?B?NnBKTUU0YS92bjNjS0RZTXlETHpJelRteGs2cko2ekVCcGJQVFhJcW1TYzhJ?=
 =?utf-8?B?L1A5QTZVMUdKMFhRcU45REdYUWlFaWZpNDdtRWFUR3ZKUkhFN3VkUUE4U1Z5?=
 =?utf-8?B?M0pGaTZtaUcyYk4zN0VsTHJVa3F6NzdlVHFodGFPZnZROWJoV0d1RS80TXFM?=
 =?utf-8?B?bzkrdUpvYmdxcXdPVWI2bytpYTVGMTFIYWljUzA0cHhGOEFCT0dyZzh5czBY?=
 =?utf-8?B?eEd5S1FoMjJhVWk0c1RXZHorNE5xTDFadHBHbmdDTUo0eklSYkxZcVVWL3RY?=
 =?utf-8?B?Tnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 504a9f8f-cc64-4b78-93d5-08daffd7db8c
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4914.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 19:59:39.3914
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mjl05x60V6VkNqxPYA8znfHTHI76LunafK8iDcAxChJ30bQOIhO9YkAcb+EFi3/22BMmaP31NnpACtqTmpxgyU+gnkuSFb+PPKKRdPigoYI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7125
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/26/2023 11:55 AM, Jesse Brandeburg wrote:
> On 1/26/2023 5:55 AM, Natalia Petrova wrote:
>> The result of nlmsg_find_attr() 'br_spec' is dereferenced in
>> nla_for_each_nested(), but it can take null value in nla_find() function,
>> which will result in an error.
>>
>> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>>
>> Fixes: 51616018dd1b ("i40e: Add support for getlink, setlink ndo ops")
>> Signed-off-by: Natalia Petrova <n.petrova@fintech.ru>
>> ---
>>   drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c 
>> b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> index 53d0083e35da..4626d2a1af91 100644
>> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> @@ -13167,6 +13167,8 @@ static int i40e_ndo_bridge_setlink(struct 
>> net_device *dev,
>>       }
>>       br_spec = nlmsg_find_attr(nlh, sizeof(struct ifinfomsg), 
>> IFLA_AF_SPEC);
>> +    if (!br_spec)
>> +        return -EINVAL;
>>       nla_for_each_nested(attr, br_spec, rem) {
>>           __u16 mode;
> 
> Makes sense to me. Thanks.
> 
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> 

I presume that you meant this to be targeted to the "net" tree, which 
you should indicate with the subject line:
[PATCH net ...]

as per the netdev rules published [1], and generally you don't need a 
cover letter for a single patch.

[1] https://www.kernel.org/doc/html/v5.10/networking/netdev-FAQ.html