Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FBFC54EAA for ; Thu, 26 Jan 2023 20:34:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232414AbjAZUei (ORCPT ); Thu, 26 Jan 2023 15:34:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbjAZUef (ORCPT ); Thu, 26 Jan 2023 15:34:35 -0500 Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 676BE8A75; Thu, 26 Jan 2023 12:34:34 -0800 (PST) Received: by mail-il1-f172.google.com with SMTP id g16so1300027ilr.1; Thu, 26 Jan 2023 12:34:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d9CbIHhV+ARet+dyr9AydFAWYERzdT9Qwhwp8j9Ig0M=; b=bb6r2wVspmhCtcbjKgimk4Aud1E/NR1QMEH3feFYg7hi44lR0mQICAeKArA9dqz1nH UK+4CQrOggKWVZ3Ft5qBIS9Wx/PN4phkyO827xNTDv0emrhkeQqy6rBP5BgXv7ZqyVzx HXTGlSRgmuoUYK4ussf8LOMFfeWpAfPu+L8z34K+wBypTNoj64eyvhXo60s4Nwy5gvHZ gnp18bd6HBftaEdVs53cCQfQ8fBEg7YAHeq6Isu5TlgtjqAZWja+1C69xxpp3MS1SxUI Fce+0/5HrN91BRCq12GC1n8tdwzKFuqZXqh/ZsNhdoZDt3J8ubT/6RvTUb7DvWw9kAgB MOWQ== X-Gm-Message-State: AO0yUKV2LdBDxGNlEo1EQrseJUn9HCV+97UsUnLcu2mUqtd3/ZmdRr4j WCI3urONield2YB9ZnwTI7gJLOEnB4Yo8vWglRA= X-Google-Smtp-Source: AK7set+wQrMRe/lrAhLyqRwEYfdqTPCe8+lPbG6MzcJrW7lkO52XWabyd16pKXY4CHjWoS9/vexbJmpYyiV16gNlK5M= X-Received: by 2002:a92:1a41:0:b0:310:9d4d:80e9 with SMTP id z1-20020a921a41000000b003109d4d80e9mr1247755ill.151.1674765273679; Thu, 26 Jan 2023 12:34:33 -0800 (PST) MIME-Version: 1.0 References: <20230126194230.3339019-1-namhyung@kernel.org> In-Reply-To: From: Namhyung Kim Date: Thu, 26 Jan 2023 12:34:22 -0800 Message-ID: Subject: Re: [PATCH] perf script: Add 'cgroup' field for output To: Arnaldo Carvalho de Melo Cc: Arnaldo Carvalho de Melo , Jiri Olsa , Ingo Molnar , Peter Zijlstra , LKML , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, Stephane Eranian Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Thu, Jan 26, 2023 at 12:06 PM Arnaldo Carvalho de Melo wrote: > > > > On January 26, 2023 4:42:30 PM GMT-03:00, Namhyung Kim wrote: > >There's no field for the cgroup, let's add one. To do that, users need to > >specify --all-cgroup option for perf record to capture the cgroup info. > > > This information about the new field being only available when --all-cgroup is specified should be in the documentation (man page) and probably in the tool itself, refusing it when the needed command line isn't present. Ok, will update. Thanks, Namhyung