Message-ID: <350d21a9-ac48-7da8-aa5e-d51ad794730a@linuxfoundation.org>
Date:   Thu, 26 Jan 2023 13:43:13 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 0/3] selftests/tracing: Fix some testcases for recent
 change
Content-Language: en-US
To:     Steven Rostedt <rostedt@goodmis.org>,
        "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc:     Shuah Khan <shuah@kernel.org>, linux-kernel@vger.kernel.org,
        linux-trace-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <167309832823.640500.13244630381161014364.stgit@devnote3>
 <20230108163128.2860894d@rorschach.local.home>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20230108163128.2860894d@rorschach.local.home>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/8/23 14:31, Steven Rostedt wrote:
> On Sat,  7 Jan 2023 22:32:08 +0900
> "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> 
>> This includes some patches to fix 2 issues on ftrace selftests.
>>
>> - eprobe filter and eprobe syntax test case were introduced but it
>>    doesn't check whether the kernel supports eprobe filter. Thus the
>>    new test case fails on the kernel which has eprobe but not support
>>    eprobe filter. To solve this issue, add a filter description to
>>    README file [1/3] and run the filter syntax error test only if the
>>    description is found in the README file [2/3].
>>
>> - Recently objtool adds prefix symbols for the function padding nops,
>>    and the probepoint test case fails because this probepoint test case
>>    tests whether the kprobe event can probe the target function and the
>>    functions next to the target function. But the prefix symbols can not
>>    be probed. Thus these prefix symbols must be skipped [3/3].
>>
>> Thank you,
>>
>> ---
>>
>> Masami Hiramatsu (Google) (3):
>>        tracing/eprobe: Fix to add filter on eprobe description in README file
>>        selftests/ftrace: Fix eprobe syntax test case to check filter support
>>        selftests/ftrace: Fix probepoint testcase to ignore __pfx_* symbols
>>
>>
> 
> Reviewed-by: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- Steve
> 

For selftest patches in the series: (Assuming patches 2&3 depend on patch 1.)

Acked-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah