Date:   Fri, 27 Jan 2023 00:16:33 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
        Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Cai Huoqing <cai.huoqing@linux.dev>,
        Robin Murphy <robin.murphy@arm.com>,
        Jingoo Han <jingoohan1@gmail.com>, Frank Li <Frank.Li@nxp.com>,
        Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        caihuoqing <caihuoqing@baidu.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        linux-pci@vger.kernel.org, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 24/27] dmaengine: dw-edma: Relax driver config settings
Message-ID: <20230126211633.2sptj5jn4ccmykx4@mobilestation>
References: <20230126163750.ae6z3pkyd3o32byn@mobilestation>
 <20230126181954.GA1290077@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230126181954.GA1290077@bhelgaas>
Precedence: bulk

On Thu, Jan 26, 2023 at 12:19:54PM -0600, Bjorn Helgaas wrote:
> On Thu, Jan 26, 2023 at 07:37:50PM +0300, Serge Semin wrote:
> > On Wed, Jan 25, 2023 at 05:23:57PM -0600, Bjorn Helgaas wrote:
> 
> > > It's a pretty trivial update, so I just did it myself.  The result is
> > > at https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/log/?h=pci/ctrl/dwc&id=ecadcaed4ef7
> > > 
> > > I split this patch and tweaked some commit messages for consistency
> > > (including the "DW eDMA PCIe driver" change above).  "git diff -b"
> > > with Lorenzo's current branch (95624672bb3e ("PCI: dwc: Add DW eDMA
> > > engine support")) is empty except for a minor comment change.  
> > 
> > Great! Thanks. Although I've already created v10 beforehand but didn't
> > submitted it yet waiting for your response. The split up patches look
> > exactly like yours.
> > 
> > In addition to that since I was going to re-send v10 I also took into
> > account your comments regarding the patch:
> > [PATCH v9 19/27] dmaengine: dw-edma: Use non-atomic io-64 methods
> > Link: https://lore.kernel.org/linux-pci/20230113171409.30470-20-Sergey.Semin@baikalelectronics.ru/
> > I've dropped unneeded modification and unpinned another fixes patch
> > which turned out to be a part of those modifications. So if you
> > re-based your pci/ctrl/dwc branch with that patch replaced with the
> > patches attached to this email it would have been great. Otherwise
> > it's ok to merge the series as is.
> > 
> > Note in the attached "non-atomic io-64" patch I've already replaced
> > the commit log with the your short version.
> 

> Awesome, thanks!  I folded those updates in and updated my branch.
> 
> And merged the whole thing into the PCI "next" branch.
> 
> Thanks for all your work!

Great! Thanks to you too with reviewing and helping to merge the bits.
I've almost completed another series with a few more updates based on
the notes made by you and Mani during the review. I'll submit the
patchset soon.

-Serge(y)

> 
> Bjorn