Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761475AbXH2XFx (ORCPT ); Wed, 29 Aug 2007 19:05:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757895AbXH2XFr (ORCPT ); Wed, 29 Aug 2007 19:05:47 -0400 Received: from gate.crashing.org ([63.228.1.57]:45206 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755790AbXH2XFq (ORCPT ); Wed, 29 Aug 2007 19:05:46 -0400 In-Reply-To: <46D40510.3060805@scram.de> References: <46D40510.3060805@scram.de> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <611B8BA7-89B3-4DA0-A248-0FB57E4654ED@kernel.crashing.org> Cc: linuxppc-embedded@ozlabs.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit From: Kumar Gala Subject: Re: [PATCH] ppc32/8xx: Fix r3 trashing due to 8MB TLB page instantiation Date: Wed, 29 Aug 2007 18:08:00 -0500 To: Jochen Friedrich X-Mailer: Apple Mail (2.752.2) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1362 Lines: 42 On Aug 28, 2007, at 6:20 AM, Jochen Friedrich wrote: > Instantiation of 8MB pages on the TLB cache for the kernel static > mapping trashes r3 register on !CONFIG_8xx_CPU6 configurations. > This ensures r3 gets saved and restored. > > This has been posted to linuxppc-embedded by Marcelo Tosatti > , but only an incomplete version of the patch > has been applied in c51e078f82096a7d35ac8ec2416272e843a0e1c4. > This patch adds the rest of the fix. > > Signed-off-by: Jochen Friedrich > --- > arch/ppc/kernel/head_8xx.S | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > This can be pulled from git://git.bocc.de/dbox2.git ppc-fixes > diff --git a/arch/ppc/kernel/head_8xx.S b/arch/ppc/kernel/head_8xx.S > index 944c35c..eb8d26f 100644 > --- a/arch/ppc/kernel/head_8xx.S > +++ b/arch/ppc/kernel/head_8xx.S > @@ -495,9 +495,7 @@ LoadLargeDTLB: > lwz r11, 4(r0) > > lwz r12, 16(r0) > -#ifdef CONFIG_8xx_CPU6 > lwz r3, 8(r0) > -#endif > rfi > > /* This is the data TLB error on the MPC8xx. This could be due to do we need this in arch/powerpc as well? - k - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/