Message-ID: <5caf64b6-0e3c-4c24-4fe8-9ed2caf43822@redhat.com>
Date:   Thu, 26 Jan 2023 23:25:49 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] dma-buf: actually set signaling bit for private sub
 fences
Content-Language: en-US
To:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Arvind.Yadav@amd.com, sumit.semwal@linaro.org, gustavo@padovan.org
Cc:     dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230126002844.339593-1-dakr@redhat.com>
 <4b13c48e-1677-3947-42e5-5ba241bcb96a@amd.com>
From:   Danilo Krummrich <dakr@redhat.com>
Organization: RedHat
In-Reply-To: <4b13c48e-1677-3947-42e5-5ba241bcb96a@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 1/26/23 07:58, Christian König wrote:
> Am 26.01.23 um 01:28 schrieb Danilo Krummrich:
>> In dma_fence_allocate_private_stub() set the signaling bit of the newly
>> allocated private stub fence rather than the signaling bit of the
>> shared dma_fence_stub.
>>
>> Fixes: c85d00d4fd8b ("dma-buf: set signaling bit for the stub fence")
>> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
> 
> Good catch, Reviewed-by: Christian König <christian.koenig@amd.com>
> 
> Should I push it upstream as well or do you have commit access?

Thanks, I can push it to drm-misc-next.

> 
>> ---
>>   drivers/dma-buf/dma-fence.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
>> index 406b4e26f538..0de0482cd36e 100644
>> --- a/drivers/dma-buf/dma-fence.c
>> +++ b/drivers/dma-buf/dma-fence.c
>> @@ -167,7 +167,7 @@ struct dma_fence 
>> *dma_fence_allocate_private_stub(void)
>>                  0, 0);
>>       set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
>> -        &dma_fence_stub.flags);
>> +        &fence->flags);
>>       dma_fence_signal(fence);
>