Message-ID: <604dc49a-fd03-4407-0e13-d16022ba81c4@linuxfoundation.org>
Date:   Thu, 26 Jan 2023 15:54:27 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [RFC PATCH] selftests: Fix: search kernel headers in
 $(KHDR_INCLUDES)
Content-Language: en-US
To:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        Shuah Khan <shuah@kernel.org>
Cc:     linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>, stable@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20230117201724.11869-1-mathieu.desnoyers@efficios.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
In-Reply-To: <20230117201724.11869-1-mathieu.desnoyers@efficios.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/17/23 13:17, Mathieu Desnoyers wrote:
> Use $(KHDR_INCLUDES) as lookup path for kernel headers. This prevents
> building against kernel headers from the build environment in scenarios
> where kernel headers are installed into a specific output directory
> (O=...).
> 

The change looks good to me.
> [ Hopefully I did not break too many things with this selftests-wide
>    change. Additional testing would be welcome before merging, especially
>    given that whenever we get this wrong, it appears to fall-back on the
>    build environment system headers, which hides issues. This applies on
>    top of v6.2-rc3. ]
> 

One concern with treewide change is the merge conflicts. Selftests
go through several trees as you may already know.

Would it be possible for you send patch series instead? Patch series
will help us avoid merge conflict issues.

I will run tests on this patch and let you know in the meatime.

thanks,
-- Shuah