Date:   Thu, 26 Jan 2023 15:45:09 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>
CC:     Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/mbox: Add debug messages for supported mailbox
 commands
Message-ID: <63d310851dc19_ea222294b@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230119130450.107519-1-rrichter@amd.com>
 <Y84dleBbsQhE0Dic@aschofie-mobl2>
 <Y85+dwjO9JjtFtGa@rric.localdomain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y85+dwjO9JjtFtGa@rric.localdomain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RTc+PGXLtCTk6yrmzvJVDJ5tXurHie/NW2Z/ZVNHvKghNntvCs82U2Erk8/R?=
 =?us-ascii?Q?URl0aZ7YKIlGTrjJRVpLznJ1uQwCs6ot/hUSOEn2CX6WA2Wzn/4e7eL85d2H?=
 =?us-ascii?Q?9KM0ff74KJl5e/B66G5Oonw5am6VCB64T/HV/Zn8QHVRyvdldGP4+Fn+4zDG?=
 =?us-ascii?Q?/+TwzQ+yrR4D7/wwMnx2RfjOOaHEMd/IHASTqU956bsUyIBDk8N1DbpaufWy?=
 =?us-ascii?Q?YaNzc8xITLdxshbAyl3APq9rHnok4ehIUkLFGIzPCHGNbMuMIroszSvGLupM?=
 =?us-ascii?Q?Co8cHEgWpOzaX+TKwS2e4hfOtQ+EU7KS/NFi2IORhw7FlriB1jTz4Sq/aHc/?=
 =?us-ascii?Q?QOgxOjxMdmCKluJUp7eA5O7XThoet0B1A35XOPrJ5vjXkVlZrkOmnukdDYAx?=
 =?us-ascii?Q?8rWyS4nrOZ69HJ4VLDKqA1Bt2KCh5qn8ogPDo/Wglk5vlWiKvhDma55Ta/7C?=
 =?us-ascii?Q?Cnfpm9YbOF3Mr03whmfcsrqe/18UQ/RUSQMVTt4PJLzE9Cuz6AKji+y7il89?=
 =?us-ascii?Q?7lhDtq8Ezx31XbMLdvyL6RQ1wZQ0w5rwHpgzaQOgxwnPcV+iOShy20e36C4z?=
 =?us-ascii?Q?zNO7EFKsnpgUmrak7VPZJUAshBHFJ5UPf/Cg6O/rwM8qqXKbxJS91VV4w+KM?=
 =?us-ascii?Q?f3qu8N3zSHah+Mi4mW1be5RRiLbIdg4P9l7o5ixj7/K7CaWekLwOJR6vPrRs?=
 =?us-ascii?Q?WOMbiaM/7ouOt779FYxyJ4UkDfVRJoY08drMeQFFB+TMGHoX1jIq5TryRRCw?=
 =?us-ascii?Q?aK/EoMQ4xmngsK+yd27SipsXXyksTvdez6CzKPikLkWFJsjEcP1ErY8J/7dD?=
 =?us-ascii?Q?6476/O4JLYrQ1gvtBtOBz7RTeCTV1wGSSn0Kxn87/yMUQII7mjf4QkjmL+CN?=
 =?us-ascii?Q?2T7Ln7BEgM+O4mK6wlNl1P6xAnjrBPw9AnSxKtIiPylAwMmKXKQ3d+4dDDt/?=
 =?us-ascii?Q?oTHsOcvP8LqOubAL0p48liKUFQ7S4hKGkYg+RqSkYCgDE2hME6aQ/QneyIFV?=
 =?us-ascii?Q?Vb9PMl3L3r9JhgCoryuHM2d7U5zqCqD3fclCvJTMPItoYW6HAi6jWbVGViSg?=
 =?us-ascii?Q?hlnAet1yF8/E1W51NIsuHNVCUptmrxl979UNx2NDE2VPcmlIozrDzWedCTS6?=
 =?us-ascii?Q?SB/EXxdW5CYstygzRaTzNN9nnoFTsgprGcirFzBDTg/mUAe0AViBf47Y/TlV?=
 =?us-ascii?Q?NhTrZsM3mznUpDyeLNfuZ5eHWenMEzxhZpaOkq2fHpi59WIw6DiGYdfULMGO?=
 =?us-ascii?Q?oOfdqX7+EbtA6Au0Ds8l4u4yiMGMWgPRK4cGEDVHqW7wRDwdUROb1g5cmpKt?=
 =?us-ascii?Q?0GKGsR6vAaeK/EUjhl//ZoQiqVoCl4xX2W9WZ8gKby3/JjDdsjUGLWjr7vu1?=
 =?us-ascii?Q?psI+ZORBxaZEcWNNFtgG3l55/x6oCkPQzRYERAsl/B5MRwll9lw1bZ76WJ2u?=
 =?us-ascii?Q?nFLiSL4RnAhxpyyHxC5BXc/EMVZm+kqdRsIarUqZ//OJ3NOfMW/57too3i/A?=
 =?us-ascii?Q?9DLH+cfIS3nC4Gb7K7jfk6oT5abY7xS4d70CRrzHRgO9LSqRJ/nZvj9JjCLz?=
 =?us-ascii?Q?Gx2XygWc1bbgxMqPbOsb5OvPl7YRYXZsYPcVLcnIRg81Vy+qBXiVOTULSEvE?=
 =?us-ascii?Q?gw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fffba1ec-34d0-4982-145a-08dafff75d6a
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 23:45:11.7315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LJKQUOb5edIVMXv8hxPxy/IZFNO+tLjJ/X7bMzAo5rf/osIsmSXHKjOrcfhSJW7qbKnF5T/es+9HBw8Lg8EArPKDSTGiXt0FdJeBGVn0U34=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6844
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> Hi Alison,
> 
> On 22.01.23 21:39:33, Alison Schofield wrote:
> > On Thu, Jan 19, 2023 at 02:04:50PM +0100, Robert Richter wrote:
> > > Only unsupported mailbox commands are reported in debug messages. A
> > > list of supported commands is useful too. Change debug messages to
> > > also report the opcodes of supported commands.
> > 
> > Hi Robert,
> > I wonder if you can get this info another way. When I try this 
> > loading cxl_test today, I get 99 new messages. Is this going to
> > create too much noise with debug kernels?
> 
> There are 26 commands supported by the driver, so I assume there are
> at least 4 cards in your system? To me the number of messages looks ok
> for a debug kernel. And, most kernels have dyndbg enabled allowing to
> enable only messages of interest? Esp. if card initialization fails
> there is no way to get this information from userland. The list of
> unsupported commands is of less use than the one for supported. That
> is the intention for the change.

The debug message looks ok to me, I will just note that there has been
consideration for exporting the enabled commands list via
CXL_MEM_QUERY_COMMANDS [1]. I wouldn't be opposed to someone enabling that
as well, just need to be clear with userspace that not all kernels will
populate that status.

[1]: http://lore.kernel.org/r/63b4ec4e37cc1_5178e2941d@dwillia2-xfh.jf.intel.com.notmuch