Date:   Thu, 26 Jan 2023 15:45:43 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Robert Richter <rrichter@amd.com>,
        Alison Schofield <alison.schofield@intel.com>
CC:     Vishal Verma <vishal.l.verma@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        <linux-cxl@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/mbox: Add debug messages for supported mailbox
 commands
Message-ID: <63d310a768822_ea222294f0@dwillia2-xfh.jf.intel.com.notmuch>
References: <20230119130450.107519-1-rrichter@amd.com>
 <Y84dleBbsQhE0Dic@aschofie-mobl2>
 <Y85+dwjO9JjtFtGa@rric.localdomain>
 <Y87ff+zqVKf4oOJ/@aschofie-mobl2>
 <Y8/RuADVoRiC4d0+@rric.localdomain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y8/RuADVoRiC4d0+@rric.localdomain>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yqRugaxbCwHjZ0qfGbQYPbVQcYKxTGorhLLG3rgiumPtwRkJHTCU/HBnV5nL?=
 =?us-ascii?Q?cO3DZ4Puwt7w0nkxICEgy1WPgJ98JtOrhDlqICFZtLMUWhcN02Xwb9UB4G6F?=
 =?us-ascii?Q?Y7gxgIUIds/nwVGUbEVwOruw4+QKAo/ChHntz0RjqrjOm+hghxTkt5Lg+g3L?=
 =?us-ascii?Q?QYE7wtVSx11cblXLUfqCOZl7yei2WDZoeYzt3g04G3387hqJPHpA42QdkGnV?=
 =?us-ascii?Q?/Ui4Wqx2uLNJ7qu7i3L2NhKhmdgZq3Vt26VGTMoIuPRRdB/cr+kVC03riywT?=
 =?us-ascii?Q?bM39h42jT+2PWbjDUlOcDLXncJcJcYL2fXVo5tiJuMwjLCDdi+lBzyawiA6t?=
 =?us-ascii?Q?W+EvZoSG10v9xSLVJmwVf8i0VBz3/3QDMhiZQfSPZbv9n1PEZK66iEdCp/Nh?=
 =?us-ascii?Q?wTmUWi7Al2iPpCYduMHu8fw1V6GIINJX1ITcXoCntvGsSuCn0YgXiwS1MHDt?=
 =?us-ascii?Q?XGWYQ274LHNnES7XLinJHKaYQvrQx5WXb6gs3+RTSXpq2znfFYRueXr//L84?=
 =?us-ascii?Q?ILTTsLUnKYLB/0Vjlky3nJNVklwLWQSjOjUYDpyW09MYKTioUw0SkC6+GZw/?=
 =?us-ascii?Q?PaWxfnWJVnuXKWIunI9ac9gavOpSaCHo5hjkNF5so702kyzfba8scwnPSLUi?=
 =?us-ascii?Q?OByCx55yeiKPOP6DsvPCVuHjK9i9hH6oiaJ7Zl3D824idu7RhPOkpQ5NtnlZ?=
 =?us-ascii?Q?AmjRha6HagA3XuHOAnt3al4u+ML3O8TPUdF3BCNqpjRMSCZAa2uR3F3cWg0S?=
 =?us-ascii?Q?uwgGcvblcMwjob5U68LD6KddtD0jw1MhjF8+Ob/J7p63qB9sS5RBwHXkoz5f?=
 =?us-ascii?Q?kDOx7dTosTjoBwPe6E1SrKtw/xmH914pviW7PJUCt1OTDBl4JsdT3tHTPU5o?=
 =?us-ascii?Q?TDyo4y28hOuLQJHChIl8RVmFiVqXw6tPLdPJTa5I0xVaJM1ONCV4L3ILVcGf?=
 =?us-ascii?Q?rMeDPHF2d0YlAa/JWUqQd6mzKyiWcunBYha6L+W9Dn21Z3thJgD5RWibo6Hx?=
 =?us-ascii?Q?1i2dNEqaI4oe0Jme/4hKlppIV1J+rgp+Mq0Z0VD0kIrG6ZsPTuSdHtXrLoRt?=
 =?us-ascii?Q?kWOHp7fyHgxOE4cfl33rHi3oy7wgmGMiPcQPuuZTyB6KdV7Sxd5U5FJbYCHe?=
 =?us-ascii?Q?FGt5EMowph9aPmCJI+Psd2l7qfWAw/eW5fvvg8csyMhI+a9dGdn92iPoeTIq?=
 =?us-ascii?Q?mu+8DsqTcPguNMEGhU7xMbaHI4nKbOenWTlRZPyScKbu2JynIdn+wmWDxDMB?=
 =?us-ascii?Q?JAyANmZb1b0Z3/pSVxGgZQ9GMob1cuGlilAjXRKlzCM+B2L/+10PobdMg7yt?=
 =?us-ascii?Q?LtZm6z5dYY1b1LkEviWz4OmU+EzNGiWaDPrIFMS9yrjXOxrjUQg6vM656Lx/?=
 =?us-ascii?Q?NI+u0scoajWase+Oh0ql2EL6zwhgwkKxRmjbP8CYwiSWcTDOz/3/Hl7efeKH?=
 =?us-ascii?Q?liGhr+FD6joBPl3hOslinqZD0ZWNsIsmYKjAyMVYH3m2RKsHHjbIKQJYtOrK?=
 =?us-ascii?Q?Fie7JbCvzbsJ1rIOovj+Np7UVQ1DTUIcdeLxPV0FsTpxyS0pAXod0d2GBhBC?=
 =?us-ascii?Q?I9vv+zktVo6p+Z2hM+cbjmHVgxKOMxVC83StXoHNIqJbodF1raHQcuuCSAR9?=
 =?us-ascii?Q?jA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ee972902-6a54-4bbf-9da4-08dafff7719a
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 23:45:45.6185
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: okwamARSbaCGiLz8955o0qX6STFuJ709qfPrH5dMiAiWI5o1tfGfEUfmFNpeqH0wLGOSjswGlHaKI8tTwqePWvH0BjlsjTS2ZgZ09ghvsFY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6844
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Robert Richter wrote:
> On 23.01.23 11:26:55, Alison Schofield wrote:
> > On Mon, Jan 23, 2023 at 01:32:55PM +0100, Robert Richter wrote:
> > > Hi Alison,
> > > 
> > > On 22.01.23 21:39:33, Alison Schofield wrote:
> > > > On Thu, Jan 19, 2023 at 02:04:50PM +0100, Robert Richter wrote:
> > > > > Only unsupported mailbox commands are reported in debug messages. A
> > > > > list of supported commands is useful too. Change debug messages to
> > > > > also report the opcodes of supported commands.
> > > > 
> > > > Hi Robert,
> > > > I wonder if you can get this info another way. When I try this 
> > > > loading cxl_test today, I get 99 new messages. Is this going to
> > > > create too much noise with debug kernels?
> > > 
> > > There are 26 commands supported by the driver, so I assume there are
> > > at least 4 cards in your system? To me the number of messages looks ok
> > > for a debug kernel. And, most kernels have dyndbg enabled allowing to
> > > enable only messages of interest? Esp. if card initialization fails
> > > there is no way to get this information from userland. The list of
> > > unsupported commands is of less use than the one for supported. That
> > > is the intention for the change.
> > 
> > cxl_walk_cel() job is to create the enabled_cmds list for the device.
> > How about we use that language in the message, like:
> > 
> > 		set_bit(cmd->info.id, cxlds->enabled_cmds);
> > -               dev_dbg(cxlds->dev, "Opcode 0x%04x supported by driver\n", opcode);
> > +               dev_dbg(cxlds->dev, "Opcode 0x%04x enabled\n", opcode);
> > 
> > Because when we say, "Opcode 0x%04x supported by driver\n", that comes
> > with the assumption that the device supported it too. By saying
> > 'enabled', it's clear device and driver are aligned.
> 
> Yes, that message is more meaningful.
> 

Applied with this fixup.