Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760695AbXH3AFj (ORCPT ); Wed, 29 Aug 2007 20:05:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754539AbXH3AFc (ORCPT ); Wed, 29 Aug 2007 20:05:32 -0400 Received: from outbound.mse2.exchange.ms ([69.25.50.247]:47696 "EHLO mse2fe1.mse2.exchange.ms" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751712AbXH3AFb (ORCPT ); Wed, 29 Aug 2007 20:05:31 -0400 Message-ID: <46D609C5.2020906@bluelane.com> Date: Wed, 29 Aug 2007 17:05:25 -0700 From: Pete/Piet Delaney Reply-To: pete@bluelane.com Organization: Bluelane User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: pete@bluelane.com CC: Jason Wessel , Andrew Morton , kgdb-bugreport@lists.sourceforge.net, amitkale@linsyssoft.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Mariusz Kozlowski , Paul Mackerras Subject: Re: [Kgdb-bugreport] 2.6.23-rc3-mm1: kgdb build failure on powerpc References: <20070822020648.5ea3a612.akpm@linux-foundation.org> <200708222104.29432.m.kozlowski@tuxland.pl> <20070822124743.fc316963.akpm@linux-foundation.org> <46CCBC3C.7010307@windriver.com> <20070822165318.b82da13c.akpm@linux-foundation.org> <46CCFE2C.4050306@windriver.com> <46D604BF.7090905@bluelane.com> In-Reply-To: <46D604BF.7090905@bluelane.com> X-Enigmail-Version: 0.95.3 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 30 Aug 2007 00:05:30.0956 (UTC) FILETIME=[7A81A0C0:01C7EA99] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2225 Lines: 75 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Pete/Piet Delaney wrote: > Jason Wessel wrote: >> Andrew Morton wrote: >>> On Wed, 22 Aug 2007 17:44:12 -0500 >>> Jason Wessel wrote: >>> >>> >>>> + while (!atomic_read(&debugger_active)); >>>> >>> eek. We're in the process of hunting down and eliminating exactly this >>> construct. There have been cases where the compiler cached the >>> atomic_read() result in a register, turning the above into an infinite >>> loop. >>> >>> Plus we should never add power-burners like that into the kernel >>> anyway. That loop should have a cpu_relax() in it. Which will also >>> fix the >>> compiler problem described above. >>> >>> >> Agreed, and fixed with a cpu_relax. > >>> Thirdly, please always add a newline when coding statements like that: >>> >>> while (expr()) >>> ; >>> >> The other instances I found of the same problem in the kgdb core are >> fixed too. > >> I merged all the changes into the for_mm branch in the kgdb git tree. > > Where is the kgdb git tree? Trying: git clone http://master.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git - -piet > > -piet > >> Thanks, >> Jason. >> - >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > - - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFG1gnFJICwm/rv3hoRApOoAJ9BHXLsIuxDiOCaAFRfAZGwrDXATQCeLL3O bxtr3qz0soPRghPmtSZgOqc= =kQd1 -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/