Date:   Thu, 26 Jan 2023 16:49:19 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Ira Weiny <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Bjorn Helgaas <bhelgaas@google.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        "Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <linux-acpi@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: RE: [PATCH v7 1/8] cxl/mem: Read, trace, and clear events on driver
 load
Message-ID: <63d31f8fbb678_ea222294a3@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221216-cxl-ev-log-v7-0-2316a5c8f7d8@intel.com>
 <20221216-cxl-ev-log-v7-1-2316a5c8f7d8@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221216-cxl-ev-log-v7-1-2316a5c8f7d8@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4DXnQnvWINoNP15tRGJ236oFRJizi/bQtSHyT+NruMjVdM0LGw0uP/4+yQGJ?=
 =?us-ascii?Q?ZQWBf+98MmfI3D4vuQ4cDCmuDCCzsMqmX7YrGaAPPBOwCtiowq4nTZTddeSd?=
 =?us-ascii?Q?piIyRRZ65z0apSA8pxBLVSpcbE1utxKK2bpG1MTP4Qznbyvt/a12xxsZXnFr?=
 =?us-ascii?Q?F+HGS2sLz097juMTCRZvHn6gUHBnBdvVqcbz/JbHlmFo1Hogqn6gPYZiMLvn?=
 =?us-ascii?Q?xNqHsYB2noA+shP/klQEUv/OPmr5/OW2+cecl9QnO1GMjMMyDUDEraST+ZCQ?=
 =?us-ascii?Q?pKMTh0bCLqTWWdnqicpHfCuLFSl5a6crNjLB/xPJgRDgpGOzfwirJG9mobjx?=
 =?us-ascii?Q?QdMs6P/lTmKyVUnFlRebslUV9DfS1Tlgh4ResnNX1KI896MbDT8NXl7M96xu?=
 =?us-ascii?Q?UD+YYgXP2K5VpNpxw0DhSZYWuCUv1L8TKmw2Jr/GuPEMtYzp+NT7SRT90q7E?=
 =?us-ascii?Q?EvPHSOA+lcuq1oChgZt7HGPCJBQdTOvmox+5UXl03pLxsjndnQGZMjhWipCa?=
 =?us-ascii?Q?bT/gBZxBNOxWnufxJR+9rrGrJ8Vehg+mDTFQYnyb4xVqoP2R9HytfTWccIx+?=
 =?us-ascii?Q?ggNiK+W6Bwd1uk4a+Yo3j4llC1vSRh3bCKrw6CF1S/mwKxDToNPAdhjLyXrK?=
 =?us-ascii?Q?JcO5088R9ZCpArRbvLCnHPvQFJ0XKzqK4Tm8+MpQvnPQRsMwyy0pzm7aOdcy?=
 =?us-ascii?Q?afoPbe39B2dCBmLyhmkMqyieZGj+x38kS+TUeErh4v069I5IZAkhfZHKEvdU?=
 =?us-ascii?Q?fLpx8hO6qNgDXmoHocvxgyDl3wvaj4eQ5N3NoRcswbnFFo7DB6uW3yi3OUQF?=
 =?us-ascii?Q?YYVj4LFo0PdOmO6ph/xFM//zZKkMvnXf8SNTqytrrt1WoyQ9RjSpcXR4EYhP?=
 =?us-ascii?Q?I3I3ssss67bWS5hF7uAa9hzW6UGrIR8Gm8+a/mxqE3j1QBzVuUIBwcMqB3nX?=
 =?us-ascii?Q?BL2eKR3XBksRMOoYfyKVSEc+wbNbbGyuHLRjD0arMhYuDVrB7q168dACoYdE?=
 =?us-ascii?Q?Wl86Ogwbf3Eu+PduGlLqbDzt/YMoDhEJS01loqSVftTVycRs7yGuw1IbUMzO?=
 =?us-ascii?Q?nHp+pBGYTES4hgh8QA4I0/4JlSSwCtIw7G9ljaVs72rYZC65E6EuPjRjNNZ5?=
 =?us-ascii?Q?E3u9khLR9C25v+rNYqu2K72bY5DtpsjE5iZHsO7jsUIKttJ8UVv2T9Y/q4bK?=
 =?us-ascii?Q?Q/arWcFMTBWy12p05zKa9fMIy14B38igwDb5PmzqOh3gX8xN0SRxije2MhxY?=
 =?us-ascii?Q?UALg5XeDzgMOlhxewSyD+xsVC8jFVVNph0X00Zb9r6Y5+YK2+KDyg9HL0qT4?=
 =?us-ascii?Q?ZNJSxAVjRetaa08SQl2lZn9S/Ab/e2d2FMyqkcTtX/u5RwFajvEZPp20CDYy?=
 =?us-ascii?Q?wlmRQtm3aNSxvHUEbV02OFQiDok0nQ/cNpOeMgiL5HvfPJOLfeRVoErfviMv?=
 =?us-ascii?Q?R9ppJeC4B/JpCkQ39FySsEHSI9b1jmAETA3/AZH4FILFXSXB/ZCI5zemBkSr?=
 =?us-ascii?Q?GyXVSWtDV67vimJrAW/K0XDz8XTGZev0uPUudzkHdtEv1fxNz+dYn69JnwzQ?=
 =?us-ascii?Q?9SOF+6E0GNiIq4mrFUS2E6dmhunZTkwfIqSm+VOjwPbCjnVxngw6c6OmZL0+?=
 =?us-ascii?Q?Dw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: fc813a4a-4c72-445c-52fd-08db000054ad
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 00:49:22.5265
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oRdTuyWepp4zc4GTQhCNoEIHgURHFMwbhkGZpYynsUywCrKwOz1F+MCsUHW598EZ+lKDtSlICY/MUTDQh47kD9gBrkmkqgKsl6rYmQIxU6w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4801
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ira Weiny wrote:
> CXL devices have multiple event logs which can be queried for CXL event
> records.  Devices are required to support the storage of at least one
> event record in each event log type.
> 
> Devices track event log overflow by incrementing a counter and tracking
> the time of the first and last overflow event seen.
> 
> Software queries events via the Get Event Record mailbox command; CXL
> rev 3.0 section 8.2.9.2.2 and clears events via CXL rev 3.0 section
> 8.2.9.2.3 Clear Event Records mailbox command.
> 
> If the result of negotiating CXL Error Reporting Control is OS control,
> read and clear all event logs on driver load.
> 
> Ensure a clean slate of events by reading and clearing the events on
> driver load.
> 
> The status register is not used because a device may continue to trigger
> events and the only requirement is to empty the log at least once.  This
> allows for the required transition from empty to non-empty for interrupt
> generation.  Handling of interrupts is in a follow on patch.
> 
> The device can return up to 1MB worth of event records per query.
> Allocate a shared large buffer to handle the max number of records based
> on the mailbox payload size.
> 
> This patch traces a raw event record and leaves specific event record
> type tracing to subsequent patches.  Macros are created to aid in
> tracing the common CXL Event header fields.
> 
> Each record is cleared explicitly.  A clear all bit is specified but is
> only valid when the log overflows.
> 
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
[..]
> diff --git a/drivers/cxl/core/trace.h b/drivers/cxl/core/trace.h
> index 20ca2fe2ca8e..6898212fcb47 100644
> --- a/drivers/cxl/core/trace.h
> +++ b/drivers/cxl/core/trace.h
> @@ -6,7 +6,9 @@
>  #if !defined(_CXL_EVENTS_H) || defined(TRACE_HEADER_MULTI_READ)
>  #define _CXL_EVENTS_H
>  
> +#include <asm-generic/unaligned.h>
>  #include <cxl.h>
> +#include <cxlmem.h>
>  #include <linux/tracepoint.h>
>  
>  #define CXL_RAS_UC_CACHE_DATA_PARITY	BIT(0)
> @@ -103,6 +105,124 @@ TRACE_EVENT(cxl_aer_correctable_error,
>  	)
>  );
>  
> +#include <linux/tracepoint.h>

missed this earlier, no need to include this again. Will drop it in my
local tree.