Message-ID: <70ab19eb-c41a-980d-46f6-2bb02163974e@infradead.org>
Date:   Thu, 26 Jan 2023 16:57:18 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [RFC] mm: Allow ZONE_DMA32 to be disabled via kernel command line
Content-Language: en-US
To:     Dave Hansen <dave.hansen@intel.com>,
        Georgi Djakov <quic_c_gdjako@quicinc.com>,
        catalin.marinas@arm.com, will@kernel.org
Cc:     dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com,
        linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, djakov@kernel.org
References: <20230126164352.17562-1-quic_c_gdjako@quicinc.com>
 <dca84e05-e376-c593-74fa-37c58f30767a@intel.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <dca84e05-e376-c593-74fa-37c58f30767a@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/26/23 10:51, Dave Hansen wrote:
> On 1/26/23 08:43, Georgi Djakov wrote:
>> From: Chris Goldsworthy <quic_cgoldswo@quicinc.com>

  
>> +static int __init early_disable_dma32(char *buf)
>> +{
>> +	if (!buf)
>> +		return -EINVAL;
>> +
>> +	if (!strcmp(buf, "on"))
>> +		disable_dma32 = true;
>> +
>> +	return 0;
>> +}
>> +early_param("disable_dma32", early_disable_dma32);
> 
> Ick.  Is there no way to do this other than a cross-arch copy/paste?

I think that using __setup() instead of early_param() would allow that.

-- 
~Randy