MIME-Version: 1.0
References: <20230123153745.3185032-1-robdclark@gmail.com> <20230125040403epcms1p1646e9668b87df3e9c344ad58d39b6eb6@epcms1p1>
 <CGME20230123153745epcas1p17e57cf83ed371e86258139473befc615@epcms1p3>
 <CAF6AEGud-ESF=VgcaSFzKsWas0H5eSXZDdZGcnd8Ju=pr-W2EQ@mail.gmail.com> <20230125054626epcms1p38d34dc65cbc9cb29dd707a4b2cac8fb4@epcms1p3>
In-Reply-To: <20230125054626epcms1p38d34dc65cbc9cb29dd707a4b2cac8fb4@epcms1p3>
From:   Rob Clark <robdclark@gmail.com>
Date:   Thu, 26 Jan 2023 19:08:01 -0800
Message-ID: <CAF6AEGvkepf4eLKqXYkadOvtu_7ehCzmgoiq3_s7qvJXi_n3sw@mail.gmail.com>
Subject: Re: Re: [PATCH] PM / devfreq: Fix build issues with devfreq disabled
To:     myungjoo.ham@samsung.com
Cc:     Chanwoo Choi <cw00.choi@samsung.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "freedreno@lists.freedesktop.org" <freedreno@lists.freedesktop.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Clark <robdclark@chromium.org>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chia-I Wu <olvaffe@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jan 24, 2023 at 9:46 PM MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
>
> >On Tue, Jan 24, 2023 at 8:04 PM MyungJoo Ham <myungjoo.ham@samsung.com> wrote:
> >>
> >> >Sender : Rob Clark <robdclark@gmail.com>
> >> >Date : 2023-01-24 00:37 (GMT+9)
> >> >Title : [PATCH] PM / devfreq: Fix build issues with devfreq disabled
> >> >
> >> >From: Rob Clark <robdclark@chromium.org>
> >> >
> >> >The existing no-op shims for when PM_DEVFREQ (or an individual governor)
> >> >only do half the job.  The governor specific config/tuning structs need
> >> >to be available to avoid compile errors in drivers using devfreq.
> >> >
> >> >Fixes: 6563f60f14cb ("drm/msm/gpu: Add devfreq tuning debugfs")
> >> >Signed-off-by: Rob Clark <robdclark@chromium.org>
> >>
> >> Doesn't this imply that DRM_MSM should depend on PM_DEVFREQ ?
> >>
> >> It appears that gpu/drm/msm/DRM_MSM uses PM_DEVFREQ without actually
> >> declaring the dependency on PM_DEVFREQ.
> >> You cannot use SIMPLE_ONDEMAND without DEVFREQ.
> >
> >Possibly that would resolve some issues, and that might have been my
> >mistake in assuming that depending on SIMPLE_ONDEMAND implied a
> >dependency on DEFREQ (which seems like a reasonable assumption, IMHO)
> >
> >But AFAICT some kernel configs that could otherwise use DRM_MSM don't
> >support PM_DEVFREQ.. either way, lets solve this properly and remove
> >needless dependencies on devfreq.
> >
> >BR,
> >-R
>
> Ok. You are enabling struct and enum only and that looks harmless.
>
> PTAL, Chanwoo.
>
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Thanks, if possible, an ack to land this via msm-next would avoid
build break headaches with COMPILE_TEST=y and other more obscure
setups

BR,
-R