MIME-Version: 1.0
References: <20230127041200.29094-1-quic_namajain@quicinc.com>
In-Reply-To: <20230127041200.29094-1-quic_namajain@quicinc.com>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Fri, 27 Jan 2023 07:42:55 +0200
Message-ID: <CAA8EJpr96GppHmG86b2i3HhBV_OykpgV3h2MA=5ODYBwHVuDQw@mail.gmail.com>
Subject: Re: [PATCH v2] soc: qcom: socinfo: Add support for new field in
 revision 17
To:     Naman Jain <quic_namajain@quicinc.com>
Cc:     Bjorn Andersson <andersson@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Trilok Soni <quic_tsoni@quicinc.com>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        quic_pkondeti@quicinc.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 27 Jan 2023 at 06:12, Naman Jain <quic_namajain@quicinc.com> wrote:
>
> Add support for new field coming with socinfo structure under v17 to get
> hardware platform's oem variant id. This is to enable OEMs to have minor
> changes in the board, but to use the same platform subtype as the one
> supported by Qualcomm. The new field is to be used in platform overlay
> file. Default value is 0, reserved for Qualcomm platforms. Also, add
> debugfs support to read this field for a device.
>
> Signed-off-by: Naman Jain <quic_namajain@quicinc.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
> v1 -> v2: Removed change-id, included SOB line
>
>  drivers/soc/qcom/socinfo.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 10efdbcfdf05..10cdd32ce74d 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -174,6 +174,8 @@ struct socinfo {
>         __le32  pcode;
>         __le32  npartnamemap_offset;
>         __le32  nnum_partname_mapping;
> +       /* Version 17 */
> +       __le32 oem_variant;
>  };
>
>  #ifdef CONFIG_DEBUG_FS
> @@ -196,6 +198,7 @@ struct socinfo_params {
>         u32 nmodem_supported;
>         u32 feature_code;
>         u32 pcode;
> +       u32 oem_variant;
>  };
>
>  struct smem_image_version {
> @@ -519,6 +522,11 @@ static void socinfo_debugfs_init(struct qcom_socinfo *qcom_socinfo,
>                            &qcom_socinfo->info.fmt);
>
>         switch (qcom_socinfo->info.fmt) {
> +       case SOCINFO_VERSION(0, 17):
> +               qcom_socinfo->info.oem_variant = __le32_to_cpu(info->oem_variant);
> +               debugfs_create_u32("oem_variant", 0444, qcom_socinfo->dbg_root,
> +                                  &qcom_socinfo->info.oem_variant);
> +               fallthrough;
>         case SOCINFO_VERSION(0, 16):
>                 qcom_socinfo->info.feature_code = __le32_to_cpu(info->feature_code);
>                 qcom_socinfo->info.pcode = __le32_to_cpu(info->pcode);
> --
> 2.17.1
>


-- 
With best wishes
Dmitry