Date:   Fri, 27 Jan 2023 07:30:42 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Al Viro <viro@zeniv.linux.org.uk>
Cc:     Christoph Hellwig <hch@lst.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fs: build the legacy direct I/O code conditionally
Message-ID: <20230127063042.GA3174@lst.de>
References: <20230125065839.191256-1-hch@lst.de> <20230125065839.191256-3-hch@lst.de> <Y9LulMOE1BnUMP2l@ZenIV>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y9LulMOE1BnUMP2l@ZenIV>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Thu, Jan 26, 2023 at 09:20:20PM +0000, Al Viro wrote:
> On Wed, Jan 25, 2023 at 07:58:39AM +0100, Christoph Hellwig wrote:
> > Add a new LEGACY_DIRECT_IO config symbol that is only selected by the
> > file systems that still use the legacy blockdev_direct_IO code, so that
> > kernels without support for those file systems don't need to build the
> > code.
> 
> Looks sane...  FWIW, I've got this in the misc pile; doesn't seem to
> conflict anything in your series, thankfully...

Yes, this looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

If someone had time to convert ocfs2 to iomap we could also kill
the entire __blockdev_direct_IO variant.