Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0668C54EAA for ; Fri, 27 Jan 2023 06:53:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231594AbjA0Gxz (ORCPT ); Fri, 27 Jan 2023 01:53:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231912AbjA0Gxm (ORCPT ); Fri, 27 Jan 2023 01:53:42 -0500 Received: from mail.zytor.com (unknown [IPv6:2607:7c80:54:3::138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 685FB30DF for ; Thu, 26 Jan 2023 22:53:33 -0800 (PST) Received: from [127.0.0.1] ([73.223.250.219]) (authenticated bits=0) by mail.zytor.com (8.17.1/8.17.1) with ESMTPSA id 30R6qhuh3764081 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Thu, 26 Jan 2023 22:52:44 -0800 DKIM-Filter: OpenDKIM Filter v2.11.0 mail.zytor.com 30R6qhuh3764081 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zytor.com; s=2023010601; t=1674802366; bh=b3YKjhFfbcn5/+mWnBhEeUVeuE8HPWoX5snX+0lZVVA=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=XB4jlMmsK9Zy+2cyyf6zHN5KWWZ58SEa3ySitW5VxHSJxxq/VlF/vPtI/8zcLKuME NEWeCFPfWTKL8whIeftkgjfOet9uz7FrLYt+TFiwiJBH4QeBufdVjBBaV4oSVXZB8E 9GAmNONMnkxWY5sT8u7JuD+h7D3HXQTj4tZGdI71ZODR6dJUTLnJ4ajsBh1P4RYP1y AO6vjgQPtwPNXjVQ0juDp28gjk/XqTNG78DpvgopfYSfo0v7k3noYICRey++3k+scp +v/rVGCMQA6S41VwOmMnt9SGf6wRdOGsZm/rtWs1MJVEQwvWyCIXwCkcvWuxX0IhDs 6qjnhQOgNmUzw== Date: Thu, 26 Jan 2023 22:52:43 -0800 From: "H. Peter Anvin" To: Christoph Hellwig , Dave Hansen CC: Georgi Djakov , catalin.marinas@arm.com, will@kernel.org, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hch@lst.de, m.szyprowski@samsung.com, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, djakov@kernel.org Subject: Re: [RFC] mm: Allow ZONE_DMA32 to be disabled via kernel command line User-Agent: K-9 Mail for Android In-Reply-To: <20230127063555.GA3300@lst.de> References: <20230126164352.17562-1-quic_c_gdjako@quicinc.com> <20230127063555.GA3300@lst.de> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On January 26, 2023 10:35:55 PM PST, Christoph Hellwig wrote= : >On Thu, Jan 26, 2023 at 10:51:17AM -0800, Dave Hansen wrote: >>=20 >> Also, what are the practical implications here? There are obviously an >> ever decreasing number of 32-bit DMA devices out there=2E Somebody tha= t >> has one and uses this option might be sad because now they're stuck >> using ZONE_DMA which is quite tiny=2E >>=20 >> What other ZONE_DMA32 users are left? Will anyone else care? There is >> some DMA32 slab and vmalloc() functionality remaining=2E Is it impacte= d? > >DMA32 never supported lab=2E But < 64-bit DMA device are unfortunately >still not uncommon, and configuring out ZONE_DMA32 breaks them pretty >badly as we guarantee that a DMA mask of 32-bit always works=2E > >So I'm not only very much against this patch, but also the currently >existing way to configure out ZONE_DMA32 on arm64, which needs to >go away=2E > >If people want ZONE_DMA32 to go away we need something to replace >it first, like a large enough CMA region in the 32-bit addressable >range=2E Not to mention all kinds of odd masks like 30, 31, 39, 40, 46, =2E=2E=2E b= its=2E