Message-ID: <081122e1-ecfe-9441-fb91-e1887f148529@amd.com>
Date:   Fri, 27 Jan 2023 08:49:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH] dma-buf: actually set signaling bit for private sub
 fences
Content-Language: en-US
To:     Danilo Krummrich <dakr@redhat.com>, Arvind.Yadav@amd.com,
        sumit.semwal@linaro.org, gustavo@padovan.org
Cc:     dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230126002844.339593-1-dakr@redhat.com>
 <4b13c48e-1677-3947-42e5-5ba241bcb96a@amd.com>
 <5caf64b6-0e3c-4c24-4fe8-9ed2caf43822@redhat.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <5caf64b6-0e3c-4c24-4fe8-9ed2caf43822@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFVuYzBiK0NWbkF1Y2RKeXoyZnpIWE95S0VSNFQ5M3hiSWFGam9raEFseDBi?=
 =?utf-8?B?RmRLeGY3K3laaGx4QmNieWV1MEJBMzJHSHU3UUlGL3laWlhMMGt6TjNYR3RP?=
 =?utf-8?B?M0VkM1VzU2ovbGxVUElOU2ZIdlkrZkh2MU9YZTVtY3RTNVFhMzJMSTVjelVX?=
 =?utf-8?B?dFNqMHh4NTlGMU50QVZOYXh5YlJxd1RnRDQvcERlLzRMTUsrSFRlcEFKZThB?=
 =?utf-8?B?dm5iamZsamZUeUh4dUlmQ2JxNmJlaDFwR1ErVS9GTUlQNzd4cWJoVUhJL0hN?=
 =?utf-8?B?WkJxdWtHREs5ZjZRTWlDcVNtdzNncUJEWkNJMWh3VG5iQnMxSHV0REYzVHJG?=
 =?utf-8?B?eElXOGR3RnhPWXNNcExuN3JIWjNLbU1SOW5SR1M3Z1FEQjcwU0EydHRWMjZV?=
 =?utf-8?B?bEhEM3N1RElXd2hmQkJob3lpQWlMdm5INzVhZmhWcjgxQUtPZ3RjSVJLVTFR?=
 =?utf-8?B?M0QvbFpIcXIyTTRIWTZLS2FCdUgxbHlTTTdQbHlaWTJjSGs5akFSOW9vSkNr?=
 =?utf-8?B?amgyNnZRZHdrZ2ZMa2FDN2lqYW5VZTlGMWplbGVZd3lwd21lMnJOWFhCSTBn?=
 =?utf-8?B?OEtEMFlIT25tS3FGUlQxczFMUDRIUmN3ZnNjTGFwY3RhNkJFajBtQk5KMmpZ?=
 =?utf-8?B?c1RsSHlFMkFBSEUrL1VsWXZycVpXVlJPVXcvTXFKcWpCU0c0YU1Ud2c4MDlW?=
 =?utf-8?B?b1pBVFFMeFlSZlY1OFI5WnZ1b0VmamVRUWlFU0wxNkNHcDVlbjNLNTJpWjRk?=
 =?utf-8?B?NDFZQVFWRjQzNUhCbEs0WitsQWxwM1FidTNiUTZiN1RsNGwrNEFQcDZsRmNT?=
 =?utf-8?B?SXFZK3oxZ21FMWVQaFVGVUtnQjNmSWlBTEZQbEgzOFJxNFVqVHRQVHVDS09R?=
 =?utf-8?B?MW1QbVhUSzNhdTVJYnlzQS9uelJ3azZCTGdRNjRJdk9oN2dHaWQ4YUk3Q09p?=
 =?utf-8?B?c1BRWkZEeFlaVzNpUjg0OGxOVFZCTjB6MFR6c0tCSGd4M0VHQ2Q4dmovcHpU?=
 =?utf-8?B?K2pIRFhLRlVxS2E0Tkdld2NFclVMUCt5aUo4S3ZrL3daRE1wU2hPellhMWNM?=
 =?utf-8?B?TFl1MHAyUk9UTk5MeGlxK3pqZnFqaCtQTDdxeGx6em9pYlVORzNBeXJsNFg4?=
 =?utf-8?B?aEREMTBrY05kUGlFTSt3akttN0RjYzVKNVZMSGJIT2Q1bHhtazBWNS9jREY1?=
 =?utf-8?B?UlRBeDFKZGlodEYyUWNHRmJTZzlYdTlXNE9mQVR0MEJVblIySHJJTkJwWHdM?=
 =?utf-8?B?UnF6VTVBU1VOZjBjZHBnY25uWVNyUmlpYUtoVUk1QmxPYlNQN2pEOXN2UW5Y?=
 =?utf-8?B?cnBUOWRCR01NbXhRMEh4b04yQ3NZRUNCbFMrem9wS2Jzd3JUc1B6OW5xMmtX?=
 =?utf-8?B?dmhYaCs5ak9tV09nb3IyNlkrRTI1SlMydWpNV0tNUVlqamdoalR6ZEVJcnRr?=
 =?utf-8?B?d2N4YUt3SUsxMWFwOVpZNmRDemJqeHVjUmx1MGR3RnQvZHUrZHIraHRSWHBr?=
 =?utf-8?B?K1BCWldNcnFQTGJ5bVlYQVRPTDU3a2J2SkMwaGZHWGhWajdSNVUzSElFSkZV?=
 =?utf-8?B?R2VGK1BtMDhLQ28vWXJMblAzcnZYcU9SVUV0QTVtdGk5S21NcmhTVG9QNWVN?=
 =?utf-8?B?QjNmOVd1WFBsU0s4UllKU3dXVnhCL215VkNMbjA2bjZyeTY1UC9GYnhQTDhn?=
 =?utf-8?B?Znd2VERXbVdLRnlldXFCTnZkT1dWcGd5VERsOTJPamNCVEMxVk9tNHJGOHBo?=
 =?utf-8?B?ZEU3bXpod1ZZVXVUcHR2Y2p3T3JBc01jU3Z4bVZWMUUvWE5TWFBzb2YvbWp3?=
 =?utf-8?B?TWZJUi93SlUvNWkwa2xLeFZNYW1yNVV6WkpzOWFNbFYvZEFBcStDNWZwVE9s?=
 =?utf-8?B?eiswZXEwMzRlSHN2Q1FuVzNGU2JEVXdSdGV5VkI4ZVRNaXR6S2hKSTZKV3N0?=
 =?utf-8?B?bFAyYzBBbldrWFcvSWJKekdZbmtsVU1jKzZVTzd0K2U0dWUvMlZBdnAwMWVh?=
 =?utf-8?B?NndoL0JwY2k2a0hBa1BwTmV4dk01ZlIwL3dKcEkzTnMremdFRXQ1OHRzY1Zv?=
 =?utf-8?B?ZXlMRVljRzJsTkthQ3dlMWxDNzJMTm4zRzNUb1gydUt2aS9jeGxoUmx5ZkVO?=
 =?utf-8?B?alFYTHd5M1hBWllIanU0MVdoL09mY0M1MmZQZ25XckZkY21oQUJadXFkem9o?=
 =?utf-8?Q?DvjSSxOoctePrXPOycZLCjVObXBspe9yxkgnvlaxl47i?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f474f936-0ed7-4cd2-2258-08db003b05bd
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 07:49:30.5689
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e9o3CJ8CtC+hgnJyDw+0RcjPlLUmxYqVLegbNV9CqqhzjrgKaTKNMR0eCTLvVNSK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7489
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 26.01.23 um 23:25 schrieb Danilo Krummrich:
> On 1/26/23 07:58, Christian König wrote:
>> Am 26.01.23 um 01:28 schrieb Danilo Krummrich:
>>> In dma_fence_allocate_private_stub() set the signaling bit of the newly
>>> allocated private stub fence rather than the signaling bit of the
>>> shared dma_fence_stub.
>>>
>>> Fixes: c85d00d4fd8b ("dma-buf: set signaling bit for the stub fence")
>>> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
>>
>> Good catch, Reviewed-by: Christian König <christian.koenig@amd.com>
>>
>> Should I push it upstream as well or do you have commit access?
>
> Thanks, I can push it to drm-misc-next.

This is clearly a bug fix so better push this to drm-misc-fixes and 
maybe even add a CC:stable tag.

Christian.

>
>>
>>> ---
>>>   drivers/dma-buf/dma-fence.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
>>> index 406b4e26f538..0de0482cd36e 100644
>>> --- a/drivers/dma-buf/dma-fence.c
>>> +++ b/drivers/dma-buf/dma-fence.c
>>> @@ -167,7 +167,7 @@ struct dma_fence 
>>> *dma_fence_allocate_private_stub(void)
>>>                  0, 0);
>>>       set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
>>> -        &dma_fence_stub.flags);
>>> +        &fence->flags);
>>>       dma_fence_signal(fence);
>>
>