Date:   Fri, 27 Jan 2023 09:30:45 +0100
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     linux-renesas-soc@vger.kernel.org,
        Prabhakar <prabhakar.csengg@gmail.com>,
        Cong Dang <cong.dang.xn@renesas.com>,
        Hai Pham <hai.pham.ud@renesas.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] memory: renesas-rpc-if: Fix PHYCNT.STRTIM setting
Message-ID: <Y9OLtbN5uhyPYxyj@ninjato>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        linux-renesas-soc@vger.kernel.org,
        Prabhakar <prabhakar.csengg@gmail.com>,
        Cong Dang <cong.dang.xn@renesas.com>,
        Hai Pham <hai.pham.ud@renesas.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        linux-kernel@vger.kernel.org
References: <20230126173513.36659-1-wsa+renesas@sang-engineering.com>
 <CAMuHMdX6epwBa9fT9MoU=oC9k6YV2L9NXOEd84QkLnSr2vkDBA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="NfKNJifiYwgwGQjp"
Content-Disposition: inline
In-Reply-To: <CAMuHMdX6epwBa9fT9MoU=oC9k6YV2L9NXOEd84QkLnSr2vkDBA@mail.gmail.com>
Precedence: bulk


--NfKNJifiYwgwGQjp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


> > -       rpc->type =3D (uintptr_t)of_device_get_match_data(dev);
> > +       rpc->size =3D resource_size(res);
>=20
> Nit: No need to move the initialization of rpc->size.

True. It is more cosmetic to have all rpc->* inits in one block. But I
think it is worth it.

> > +       regmap_update_bits(rpc->regmap, RPCIF_PHYCNT,
> > +                          /* create mask with all affected bits set */
> > +                          RPCIF_PHYCNT_STRTIM(BIT(fls(rpc->info->strti=
m)) - 1),
>=20
> Note that this relies on the strtim value being 4 or higher.
> As this value is not user-configurable, but fixed in the driver,
> it's probably OK.

If there was a chance that newer SoCs use such a value, I'd go for the
seperate mask. But I am confident this time has passed and the next
value is likely >15.


> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks!


--NfKNJifiYwgwGQjp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmPTi7EACgkQFA3kzBSg
KbaRJw//YW0YKRPlT/6a0FFg8SORd6sO441UTATLVZ0ympE/xONAi3MFvXRA5dcm
3wERZCptTfasVuep84BIzN6ZhLpaIAZACPKyUlxDil79WUBqaO77x6IrijyEf8EL
wV0+NLbC9h8MIkymj1LmeADCN4YqNn+ERXlNyv5SAUgXtDs3wwvQnDH35+Km8qDY
GMTgHG+vsTeL/XAuvMg33c3zVK7QfUH+oqGDtP3TyVD5FGITcwfSaeOe2HqAjf+1
JL8I9Od4VJ4ORk+6HhyGKOxQ/d4sWkHl6SpfB6wQ1ByvrAqCYvgmvU91hAMWeigR
EDtmVhu9EgpeBKGzty0CkLxlD2uIPDXh4atKqvB4JaaSEoOvnQF7WLHqNwKiq/aY
WWKljcoNnVZwZLrxp9+fyPH39hrvmgLlxLjIrfRVoL0785GopiklZ35K6Y2GPOpP
xsTtt+8K8cX0IJITl0/Iqoyf1pSsIHxjBfnWfkmjwHF6JSuWWl4ttXwaMks8ZEca
pz79+1oT5cBHyl0Wgm0PAuTJzBkIkAzqwr9YRTMmhmfeqwFgxPY+oOEvfiNQNuKW
4lMQnmbcmpQmI2gMmO7Ui7m38ZvIr4ZdV0IwEpyhdInbk0E5KmFPZ+XAlHq0n0z2
anh8w7hkDgjuX1VRpLk+uwcFax8UPDh827iba6ueRbaJHLHX0zY=
=Zhfj
-----END PGP SIGNATURE-----

--NfKNJifiYwgwGQjp--