MIME-Version: 1.0
References: <20230126112129.4602-1-johan+linaro@kernel.org>
 <CAMj1kXEUKChvqA8D_T3Bt-pQhvjBmsGxyy69uqDqyn0EBmQ1pw@mail.gmail.com> <Y9OLG5/yeuG6KT0f@hovoldconsulting.com>
In-Reply-To: <Y9OLG5/yeuG6KT0f@hovoldconsulting.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Fri, 27 Jan 2023 09:38:03 +0100
Message-ID: <CAMj1kXHiWBA99KG_OXD12rGH3zk84dii3LWZ6OybahudXp3vwA@mail.gmail.com>
Subject: Re: [PATCH] efivarfs: fix NULL-deref on mount when no efivars
To:     Johan Hovold <johan@kernel.org>
Cc:     Jeremy Kerr <jk@ozlabs.org>,
        Maximilian Luz <luzmaximilian@gmail.com>,
        linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Steev Klimaszewski <steev@kali.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 27 Jan 2023 at 09:28, Johan Hovold <johan@kernel.org> wrote:
>
> On Thu, Jan 26, 2023 at 09:32:27PM +0100, Ard Biesheuvel wrote:
> > On Thu, 26 Jan 2023 at 12:23, Johan Hovold <johan+linaro@kernel.org> wrote:
> > >
> > > The VFS calls kill_sb() also in case mount fails in get_tree().
> > >
> > > Add the missing check to make sure that efivars has been registered also
> > > to kill_sb() to avoid dereferencing a NULL pointer when trying to remove
> > > efivar entries.
> > >
> > > Fixes: c3fd71b428b8 ("efivarfs: always register filesystem")
> > > Reported-by: Steev Klimaszewski <steev@kali.org>
> > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> >
> > Thanks - I have squashed this with the original patch.
>
> Thanks, Ard. And sorry about not catching this before posting.
>

No worries.