Message-ID: <871ab2c5-5f11-5ed8-9e2f-500e0cbcdb19@oracle.com>
Date:   Fri, 27 Jan 2023 14:12:46 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH 5/8] PCI: rockchip: Added dtsi entry for PCIe endpoint
 controller
Content-Language: en-US
To:     Rick Wertenbroek <rick.wertenbroek@gmail.com>,
        alberto.dassatti@heig-vd.ch
Cc:     xxm@rock-chips.com, wenrui.li@rock-chips.com,
        rick.wertenbroek@heig-vd.ch, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Heiko Stuebner <heiko@sntech.de>,
        Shawn Lin <shawn.lin@rock-chips.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jani Nikula <jani.nikula@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mikko Kovanen <mikko.kovanen@aavamobile.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-pci@vger.kernel.org
References: <20230126135049.708524-1-rick.wertenbroek@gmail.com>
 <20230126135049.708524-6-rick.wertenbroek@gmail.com>
From:   ALOK TIWARI <alok.a.tiwari@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20230126135049.708524-6-rick.wertenbroek@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGtJTjZDRWU4ZmkrZXNucHphTHk1Zkx5T0E5ZGdKV1NLVWxqVHViK29lWitm?=
 =?utf-8?B?N2xNVDFYQll2bldicEx3VVRmWWR3ay92MGFwalFVbkN4WGttdnpTdERhWm5N?=
 =?utf-8?B?ZFp3THNWWlpJWUk1aXJEUjdSd3hTc0VKRHNWMGVGaTkwSjU2Tkh0WUNRL1Zt?=
 =?utf-8?B?V2RMNTRIMGNleVh3RXE1emZnZkM3UWtWMnRGTjVoQm9rRkVQN2w5UUJHajdE?=
 =?utf-8?B?cWluYkVJamZWbkdQL2p2dGc5d2pTNHpXK3VjWHVBOFUrS1lVWTltTFVtSnFl?=
 =?utf-8?B?ZklMNHR2UzFNUmxualZHUXBsWXpNK3d1YVczaEpDai9NejE0SGQ1dVFyWEhh?=
 =?utf-8?B?Vk1BSjZERG5raDlOazVSTVpZdXdOQWtyN0dPaVJJUmxqNDdMS3BKUGpiVkZH?=
 =?utf-8?B?bk9wSU4vT2xNTGRnZGQ3N1BSd00xTGptRHRqRDgra2REVVlBMFI2Z0J0bXBP?=
 =?utf-8?B?OHBjNEI0TGw1b2s4bEFQQk0wRzRwa3JrY1hJb2Joc3ZVVTBjQm1xcWU1K0Ri?=
 =?utf-8?B?TnEvS3B5ckNpKytHcU1OVU9mcUJEWFpJWC9hRHVTVmxJTlIxMnFGZXFvYVlJ?=
 =?utf-8?B?aXVPZEV0ZkZJamttQzBlWjhIMmo4anBUU1EzanpaTDk3bDJva2JQOGZ3REIw?=
 =?utf-8?B?N1AxU0pmSEJrekwybm5HN2xQeUROamhtOTVKR2MrSHRRcGZORFhJNXAxK3kx?=
 =?utf-8?B?WUljWUx1RG1lV0Y5VC9pNEExbFY4K1hhUDV5dWs5K3kzVHFVc1UzYzZIS0ZG?=
 =?utf-8?B?cUZPVWpjNWtJS2ROVmhOejNVRzBEeFJmQ0tkQVBpOFh1WWE4NWg0d1Nmd1k2?=
 =?utf-8?B?U1VCRzRkcThweFRzVU9vOTJzN0hZemQ0UWd0OWY4dmR0aVZPaitGWHMyeC9V?=
 =?utf-8?B?SnlrZW0wcVZnSjNVQUsrN1h3TGRLamw5WEFtb0hpYWkxWTFyczdTVm8wcXVx?=
 =?utf-8?B?S1NyL0JLWUxXNnFic1RVVHE3RlQxdGc5QWt5M3Ara0RNMTgrT3kzVlpuU2Q1?=
 =?utf-8?B?aG1XbUlvbXE0MzJsOVZTSkZvMlZvdHpVNHJBbmhVZXgxS29XNVVzbjZVNDRL?=
 =?utf-8?B?czV1YVA1M0l1SEIrS0lRbldjYlhxalFqQiszeUhOOXpkRWh3UTVTL3NLd2g5?=
 =?utf-8?B?UWljUElaa0VCWkxudlBGa2Z1ZWtBNkcvdHhMamZCTE9JSENVYm45cjJaSGFr?=
 =?utf-8?B?c0hza1U4NWZkdWM1eGNUWVhqYVdjeVlCaDl3Q3FxcVZlLytsNkhjdTdGdjJx?=
 =?utf-8?B?ZU85Q0ZSeDdlWUd0cEpRd281anpmdDU5dUdlQzVsYTFSMks4aU5Bdk56NnJt?=
 =?utf-8?B?MS9zcVJvVEVZYWszcjFMVElraFYyK1IxZFFyeFBDWUVYSVNoT2diY3lYbDZQ?=
 =?utf-8?B?bW9aRHZ1ay9TQk9QVVlzalBRSGhvc1k3b1g5L1IrMWFRQWYycHVvRzlvaEtX?=
 =?utf-8?B?Y3h4TmV6TDdBUFVXZm1YeHNreTArelZsa0FSb3pqd2JKSW9tVDFmYzJ0eEdj?=
 =?utf-8?B?OFZ4M3ZnL0FaRFZYWlkzb3FYTnlNTnVwbXhVV1hudXFzWkVJbjZVQW9QKzRa?=
 =?utf-8?B?cTltclZEVUhvWTRFNHZtVFdSaktpaE4yaHBDeE4rTytpYk80N2cyNkptdDNB?=
 =?utf-8?B?ZXZGZVBYQnlRQ1FqcWRzWmd4WFh0RVJURTdaVnNYRG1lak1CVm9pK3ZBNUdQ?=
 =?utf-8?B?ZllqZGZxQmlVcW1Teno5SEg3UjhSeWt4S0N2Q1hRK3lrRlJTZm1xZlU1Smsz?=
 =?utf-8?B?cjhYOFl4VXcyalhWQUlGMWo3dmswTXlpRnl4UHk5azVpUVIrZGtHRkVicVl3?=
 =?utf-8?B?bnJUNXF4RmZaWiswL2lwd0dadUZKVjRmdFkxbUoweng4ZkJBbmt2bWQyd2tH?=
 =?utf-8?B?cnNsZTB0VHN0RjFvUjVQYUhTM3JjK3Y3S3NubnAwTVozMVNWclUrOC9zY0Iy?=
 =?utf-8?B?OFZzRjNUZUp0YVgzTit0UjQ4NGFuTFNqa3JFTjZCb0Y0ODE5TUVta3RpQ1JB?=
 =?utf-8?B?MHZSTkI0Y2ZyZ2hSczFsT20wSW1Yd3hoMlNYeEtrSkdGcGpCc1Zhb1lnMEgv?=
 =?utf-8?B?QkRhZUhCQ3ZYSExwT2Z2bi9PVmhNUDF4L01mVEQ1SDEwSzBQVW9Wa2dMK0s5?=
 =?utf-8?B?S3FoaG81RFlnbFZZa2ZIK3p3WE0reGlzWDVaaVJqYjd3N0F0bUVhdmoyQWlW?=
 =?utf-8?B?S3c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?elVaV3F4YTJ2R1g5dzk0L2xpV1gxb214TG9OK2NKblpoSHI3SjN4WGJDTC9L?=
 =?utf-8?B?enlMbWdPOU1RRUNxcWsyVk1QVThZanJGZXgzMnMydmZ6aVpzaDBUSlcrUS85?=
 =?utf-8?B?bjBJcis5eXFuWENmVnRBWGhjNVUxM2ZLUnJQMTZQdXJ4RGlzU3BaVlFhOHho?=
 =?utf-8?B?eW9TZmorYmM2VkU5RFU2RHdqdVoxVnFWZm1NL3dJUnp5ZGw2N1RRRnpPVzRo?=
 =?utf-8?B?dDdlMzZ2OExud0V2VHQ0c2JzQnVuUWRaSjYrTmNiVndPa2ZlY2FLZE5aQTNn?=
 =?utf-8?B?RkFJQnBlNzlsTEdJcWlWUU5ZODNVdmN3TnRjb1pVSUI0YThMK0NqN3E0MVJC?=
 =?utf-8?B?ejFab3pHVU1rS1UxcmpSTHJ3bmlKUnppeXlRS1BkVDNUcERTWFF4YmY4aEl1?=
 =?utf-8?B?Zjgra1dyZXczTXh4YmNMbDBldWJhb0ZCbzBuNCsvaUI4NE5ISng2eHVidkZG?=
 =?utf-8?B?SlBWTnRiYXZoZlM1bzNjVXZZcm1FQ1RJQk1weW8wdEZOVlk3MXpPb3JjQnlE?=
 =?utf-8?B?bWdsaVhXNi9PSHcvaXQyOThKUWJQSWZ1SitQM0FwRitCVTl5anpDU3VyNzVV?=
 =?utf-8?B?SVdvTnRlUnMrY2k4L1BIdFpBUlMxejNpV2EyZHB6aW1iU3AwaE9ndktwRWtF?=
 =?utf-8?B?cHZnQTVmcUo1SmY4b1FjSGhpbXpodW5DTHIxaElMTzIwM3JTRU11RXRQS2tw?=
 =?utf-8?B?dWQ1SGFMdzlsVVRVYWVIUVhjd28yZ0gvUXRZd3l3UmJNeXcvMVExNy8yT1hG?=
 =?utf-8?B?TXRJMHhDT0Nnb0lvT0poWnpPN0haR25rVmZoODJpQkJpK0dHa3U0OWtwcFpF?=
 =?utf-8?B?bUwrclVoRmxJdXVaSVdyMGJoR2VEOUJRK3Z2UlYyOEdqd3lveWErYjJXWFFX?=
 =?utf-8?B?RExObUM2U1BqS054QUxXTmRDWlFNaW94V05wWHE5U0FVRDN1MmJkek1kTS9N?=
 =?utf-8?B?S25iU2JuL2xnTWJrcHU3TTBwN29zR0t4UFROWDZ5U3h3TTl0K3M5ZHk3aFRM?=
 =?utf-8?B?dDRvZHJMdy9Hait5ck05Mk5HczlzT05ydUJ5djZHQXB4bUdwL2RRNWljcUNy?=
 =?utf-8?B?c0N5eEpMWHhkMHdDSlNTaVVTMDd4Y242LzQwb3pjOFdyZTNWd25xMk1QNG1k?=
 =?utf-8?B?eDJrN1kzS2lSdEV6eWsvTjFMdEUvSis2a1JlRXErZGFRV3pJdkJsVE1mQzhJ?=
 =?utf-8?B?TVh4NjVXSkhDNjlVUFcyYXFRdEsrNHJVUHZpa2tMaVhWdkx6UjAxbzh0SHVY?=
 =?utf-8?B?TC84NExwd0tSOHB5T3hOa1VxK2xQazlHUUttMGVmc0lyb1dqaGpZZFFhb1gv?=
 =?utf-8?B?WlA5ZFczcFRHcDFWS0ZkdmFkYnA5S3NHMVZnaEV3eUI1SFJKaThvNW95azI4?=
 =?utf-8?B?WXFqYUt5OWszdTYyNUFzSXozTkhNWlZaUE5DRUNkRW5ZRW16dk5DVU1QdjVT?=
 =?utf-8?B?U2NsWTNjU3laVTNtQnFrZ1doSFJ5TlZQRWh3eDlsVlRGajJZVytnc2xDR0Zq?=
 =?utf-8?B?L1U2U3B3eTN5Wm55M2ZTOFJ2Rk11cVFhMzFLclBJUm9VZEJIT3p6ajdubTVL?=
 =?utf-8?Q?nlc1auvT26zfRf6YBZFQvSXIE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9594593c-2fce-4b33-382d-08db00427d9a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4581.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2023 08:42:58.1125
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KWzOiwHFbwVIZX8ivaU1Uk/w1j760ko0Ls0QVndnjFsGPximkhEWl4+NdjT89IG7M4gi+t+nKkw8N7KAdDheLACV3pA98U0WK96PL0l/TbI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5701
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1
 definitions=2023-01-27_04,2023-01-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2301270081
X-Proofpoint-GUID: rZrlxRNkDu7oAaFT6eH9hIBVJaQ9xNYy
X-Proofpoint-ORIG-GUID: rZrlxRNkDu7oAaFT6eH9hIBVJaQ9xNYy
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

   DTC     arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dtb
../arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi:460.3-52: Warning 
(pci_device_reg): /pcie@f8000000/pcie@0,0:reg: PCI reg address is not 
configuration space
   DTC arch/arm64/boot/dts/amlogic/meson-gxm-s912-libretech-pc.dtb
../arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi:460.3-52: Warning 
(pci_device_reg): /pcie@f8000000/pcie@0,0:reg: PCI reg address is not 
configuration space
   HDRINST usr/include/linux/aio_abi.h
   HDRINST usr/include/linux/am437x-vpfe.h
../arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi:460.3-52: Warning 
(pci_device_reg): /pcie@f8000000/pcie@0,0:reg: PCI reg address is not 
configuration space
   DTC     arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dtb


Thanks,

Alok

On 1/26/2023 7:20 PM, Rick Wertenbroek wrote:
> Added missing PCIe endpoint controller entry in the device tree. This
> entry is documented in :
> Documentation/devicetree/bindings/pci/rockchip-pcie-ep.txt
> The status is disabled by default, so it will not be loaded unless
> explicitly chosen to.
>
> Signed-off-by: Rick Wertenbroek <rick.wertenbroek@gmail.com>
> ---
>   arch/arm64/boot/dts/rockchip/rk3399.dtsi | 25 ++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index 9d5b0e8c9..5f7251118 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -265,6 +265,31 @@ pcie0_intc: interrupt-controller {
>   		};
>   	};
>   
> +	pcie0_ep: pcie-ep@f8000000 {
> +		compatible = "rockchip,rk3399-pcie-ep";
> +		#address-cells = <3>;
> +		#size-cells = <2>;
> +		rockchip,max-outbound-regions = <32>;
> +		clocks = <&cru ACLK_PCIE>, <&cru ACLK_PERF_PCIE>,
> +			<&cru PCLK_PCIE>, <&cru SCLK_PCIE_PM>;
> +		clock-names = "aclk", "aclk-perf",
> +				"hclk", "pm";
> +		max-functions = /bits/ 8 <8>;
> +		num-lanes = <4>;
> +		reg = <0x0 0xfd000000 0x0 0x1000000>, <0x0 0xfa000000 0x0 0x2000000>;
> +		reg-names = "apb-base", "mem-base";
> +		resets = <&cru SRST_PCIE_CORE>, <&cru SRST_PCIE_MGMT>,
> +			<&cru SRST_PCIE_MGMT_STICKY>, <&cru SRST_PCIE_PIPE> ,
> +			<&cru SRST_PCIE_PM>, <&cru SRST_P_PCIE>, <&cru SRST_A_PCIE>;
> +		reset-names = "core", "mgmt", "mgmt-sticky", "pipe",
> +				"pm", "pclk", "aclk";
> +		phys = <&pcie_phy 0>, <&pcie_phy 1>, <&pcie_phy 2>, <&pcie_phy 3>;
> +		phy-names = "pcie-phy-0", "pcie-phy-1", "pcie-phy-2", "pcie-phy-3";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pcie_clkreqnb_cpm>;
> +		status = "disabled";
> +	};
> +
>   	gmac: ethernet@fe300000 {
>   		compatible = "rockchip,rk3399-gmac";
>   		reg = <0x0 0xfe300000 0x0 0x10000>;