Date:   Fri, 27 Jan 2023 10:38:01 +0000
From:   Lee Jones <lee@kernel.org>
To:     Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc:     linux-fpga@vger.kernel.org, Xu Yilun <yilun.xu@intel.com>,
        Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
        Moritz Fischer <mdf@kernel.org>,
        Matthew Gerlach <matthew.gerlach@linux.intel.com>,
        Russ Weight <russell.h.weight@intel.com>,
        Tianfei zhang <tianfei.zhang@intel.com>,
        Mark Brown <broonie@kernel.org>,
        Marco Pagani <marpagan@redhat.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 07/11] mfd: intel-m10-bmc: Prefix register defines
 with M10BMC_N3000
Message-ID: <Y9OpiT8tyXPWbvdK@google.com>
References: <20230116100845.6153-1-ilpo.jarvinen@linux.intel.com>
 <20230116100845.6153-8-ilpo.jarvinen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230116100845.6153-8-ilpo.jarvinen@linux.intel.com>
Precedence: bulk

On Mon, 16 Jan 2023, Ilpo Järvinen wrote:

> Prefix the M10BMC defines register defines with M10BMC_N3000 to make it
> more obvious these are related to some board type. All current
> non-N3000 board types have the same layout so they'll be reused. The
> less generic makes it more obvious they're not meant for the
> generic/interface agnostic code.
> 
> Reviewed-by: Russ Weight <russell.h.weight@intel.com>
> Reviewed-by: Xu Yilun <yilun.xu@intel.com>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/mfd/intel-m10-bmc-core.c  | 14 +++----
>  drivers/mfd/intel-m10-bmc-spi.c   | 52 ++++++++++++------------
>  include/linux/mfd/intel-m10-bmc.h | 66 +++++++++++++++----------------
>  3 files changed, 66 insertions(+), 66 deletions(-)

Applied, thanks

-- 
Lee Jones [李琼斯]